From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 54DF9A0096 for ; Mon, 8 Apr 2019 10:53:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AE8A2BD8; Mon, 8 Apr 2019 10:53:19 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 22653DED for ; Mon, 8 Apr 2019 10:53:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B62D0220EB; Mon, 8 Apr 2019 04:53:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 08 Apr 2019 04:53:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qsTK41VgOOZaIVHYBazsYPgNM0K7PiREnvQ2XeZJpPQ=; b=meTZ+EIA9G77 QVxMU9QtsdlnEfaWw3kMBFrrHXLpSTOsGauUlNKJivhUx3IX2wUpBXLA0iyRqmif 2aXJKxhmF5S7sx+RN9/iH3ztbZKBqdHSclHPYHFWns1EoTf3lTeprlsdL91JosWK Ylz+kxFJfmCaAlK6pKzE4poeC4laYWc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qsTK41VgOOZaIVHYBazsYPgNM0K7PiREnvQ2XeZJp PQ=; b=6Ow/ym2YhRYkd8cIijX0SSwmCEmliFXatgKOtvyGb8bv075SgFZxxmN3I Es4tWuSNW3e5Xdbl0v8zVEfTOKj514GeeDwcjhIWpZfceCTlfmI0YnCnAy7lrUQv nTo1a969eUvGpiKldKFZdz40tK6rHi29bM8S4aLX83gW0Ri68jgxeqsEkiCD3XtM 4gnndhKDFtu5MXjpd70Favxa9DzAaSUQnulG29ARob1rP8WEK9fYfXhzCeH7GV7+ FwdY/zRZm5KM1dp319+tBx/i1lyhyAqU6JEbogFaajn3bG38YoY+OlEL3w2pJSKo 6/HwaqAkh1CbFLBZKi0W4Lr4cxf+g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudefgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CC2521031A; Mon, 8 Apr 2019 04:53:13 -0400 (EDT) From: Thomas Monjalon To: Alan Dewar Cc: Ferruh Yigit , cristian.dumitrescu@intel.com, tomasz.kantecki@intel.com, Stephen Hemminger , dev@dpdk.org, Alan Dewar Date: Mon, 08 Apr 2019 10:53:12 +0200 Message-ID: <2596922.ozHIldrUZQ@xps> In-Reply-To: References: <1516032969-23894-1-git-send-email-alan.dewar@att.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7] sched: make RED scaling configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408085312.MPEJIob8K0SI-MhSpV7Eo5Nr7adLUKa1uwf6eQk-uIE@z> 08/04/2019 10:24, Alan Dewar: > On Fri, Apr 5, 2019 at 4:36 PM Ferruh Yigit wrote: > > On 1/16/2018 4:07 PM, alangordondewar@gmail.com wrote: > > > From: Alan Dewar > > > > > > The RED code stores the weighted moving average in a 32-bit integer as > > > a pseudo fixed-point floating number with 10 fractional bits. Twelve > > > other bits are used to encode the filter weight, leaving just 10 bits > > > for the queue length. This limits the maximum queue length supported > > > by RED queues to 1024 packets. > > > > > > Introduce a new API to allow the RED scaling factor to be configured > > > based upon maximum queue length. If this API is not called, the RED > > > scaling factor remains at its default value. > > > > > > Added some new RED scaling unit-tests to test with RED queue-lengths > > > up to 8192 packets long. > > > > > > Signed-off-by: Alan Dewar > > > > Hi Cristian, Alan, > > > > The v7 of this patch is sting without any comment for more than a year. > > What is the status of this patch? Is it still valid? What is blocking it? > > > > For reference patch: > > https://patches.dpdk.org/patch/33837/ > > We are still using this patch against DPDK 17.11 and 18.11 as part of > the AT&T Vyatta NOS. It is needed to make WRED queues longer than > 1024 packets work correctly. I'm afraid that I have no idea what is > holding it up from being merged. It will be in a release when it will be merged in the git tree dpdk-next-qos, managed by Cristian.