From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CA20BA0096 for ; Mon, 8 Apr 2019 11:22:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0B132C55; Mon, 8 Apr 2019 11:22:04 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B7C632B95; Mon, 8 Apr 2019 11:22:02 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1CCFF308402A; Mon, 8 Apr 2019 09:22:02 +0000 (UTC) Received: from localhost (dhcp-192-206.str.redhat.com [10.33.192.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E2D45D717; Mon, 8 Apr 2019 09:21:59 +0000 (UTC) Date: Mon, 8 Apr 2019 11:21:57 +0200 From: Jens Freimann To: Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org, maxime.coquelin@redhat.com Message-ID: <20190408092157.6d452opyioqp5fkd@jenstp.localdomain> References: <20190405000343.24424-1-stephen@networkplumber.org> <20190405163115.5068-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Disposition: inline In-Reply-To: <20190405163115.5068-1-stephen@networkplumber.org> User-Agent: NeoMutt/20180716-1376-5d6ed1 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 08 Apr 2019 09:22:02 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] virtio: fix buffer leak on vlan insert X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408092157.JaOKN3Hr4u9a2lW1IcsWYPsub2aYBPMEEDphSFlSBEw@z> On Fri, Apr 05, 2019 at 09:31:15AM -0700, Stephen Hemminger wrote: >The function rte_vlan_insert may allocate a new buffer for the >vlan header and return a different mbuf than originally passed. >In this case, the stored mbuf in txm[] array could point to wrong >buffer. > >Fixes: dd856dfcb9e7 ("virtio: use any layout on Tx") >Signed-off-by: Stephen Hemminger >--- >v2 - catch a couple more places. > The virtio code needs some refactoring to not have 3 copies of same > loop... > > drivers/net/virtio/virtio_rxtx.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Added stable@ back to Cc list as it was for v1. Reviewed-by: Jens Freimann