From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"rasland@mellanox.com" <rasland@mellanox.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] app/testpmd: fix mempool free on exit
Date: Mon, 8 Apr 2019 13:39:03 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260D86619@IRSMSX108.ger.corp.intel.com> (raw)
Message-ID: <20190408133903.sO1_oib2khOI2OjMN4AwNbMcyYN0dWIB5BSgLOEZC4U@z> (raw)
In-Reply-To: <12ce667683e47d94bb0debea9af481b87a3fba6f.1554354506.git.shahafs@mellanox.com>
> -----Original Message-----
> From: Shahaf Shuler [mailto:shahafs@mellanox.com]
> Sent: Thursday, April 4, 2019 6:15 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; rasland@mellanox.com; thomas@monjalon.net; Yigit,
> Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
> Subject: [PATCH v2 1/3] app/testpmd: fix mempool free on exit
>
> Allocated mempools were never free. it is bad practice.
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
next prev parent reply other threads:[~2019-04-08 13:46 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:34 [dpdk-dev] [PATCH 0/3] DMA map anonymous memory to eth devices Shahaf Shuler
2019-04-01 10:34 ` Shahaf Shuler
2019-04-01 10:34 ` [dpdk-dev] [PATCH 1/3] app/testpmd: fix mempool free on exit Shahaf Shuler
2019-04-01 10:34 ` Shahaf Shuler
2019-04-01 10:34 ` [dpdk-dev] [PATCH 2/3] app/testpmd: support creation of no IOVA contig mempools Shahaf Shuler
2019-04-01 10:34 ` Shahaf Shuler
2019-04-01 13:50 ` Burakov, Anatoly
2019-04-01 13:50 ` Burakov, Anatoly
2019-04-02 7:02 ` Shahaf Shuler
2019-04-02 7:02 ` Shahaf Shuler
2019-04-02 15:15 ` Burakov, Anatoly
2019-04-02 15:15 ` Burakov, Anatoly
2019-04-03 5:47 ` Shahaf Shuler
2019-04-03 5:47 ` Shahaf Shuler
2019-04-01 10:34 ` [dpdk-dev] [PATCH 3/3] app/testpmd: map anonymous memory for eth devices Shahaf Shuler
2019-04-01 10:34 ` Shahaf Shuler
2019-04-01 13:28 ` Burakov, Anatoly
2019-04-01 13:28 ` Burakov, Anatoly
2019-04-02 7:04 ` Shahaf Shuler
2019-04-02 7:04 ` Shahaf Shuler
2019-04-04 5:14 ` [dpdk-dev] [PATCH v2 0/3] DMA map anonymous memory to " Shahaf Shuler
2019-04-04 5:14 ` Shahaf Shuler
2019-04-04 5:14 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: fix mempool free on exit Shahaf Shuler
2019-04-04 5:14 ` Shahaf Shuler
2019-04-08 13:39 ` Iremonger, Bernard [this message]
2019-04-08 13:39 ` Iremonger, Bernard
2019-04-04 5:14 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: support creation of no IOVA contig mempools Shahaf Shuler
2019-04-04 5:14 ` Shahaf Shuler
2019-04-04 9:36 ` Burakov, Anatoly
2019-04-04 9:36 ` Burakov, Anatoly
2019-04-04 5:14 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: map anonymous memory for eth devices Shahaf Shuler
2019-04-04 5:14 ` Shahaf Shuler
2019-04-04 9:38 ` Burakov, Anatoly
2019-04-04 9:38 ` Burakov, Anatoly
2019-04-04 19:34 ` [dpdk-dev] [PATCH v3 0/3] DMA map anonymous memory to " Shahaf Shuler
2019-04-04 19:34 ` Shahaf Shuler
2019-04-04 19:34 ` [dpdk-dev] [PATCH v3 1/3] app/testpmd: fix mempool free on exit Shahaf Shuler
2019-04-04 19:34 ` Shahaf Shuler
2019-04-05 14:41 ` Ferruh Yigit
2019-04-05 14:41 ` Ferruh Yigit
2019-04-04 19:34 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: support creation of no IOVA contig mempools Shahaf Shuler
2019-04-04 19:34 ` Shahaf Shuler
2019-04-04 19:35 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: map anonymous memory for eth devices Shahaf Shuler
2019-04-04 19:35 ` Shahaf Shuler
2019-04-05 0:17 ` [dpdk-dev] [PATCH v3 0/3] DMA map anonymous memory to " Ferruh Yigit
2019-04-05 0:17 ` Ferruh Yigit
2019-04-07 5:02 ` [dpdk-dev] [PATCH v4 " Shahaf Shuler
2019-04-07 5:02 ` Shahaf Shuler
2019-04-07 5:02 ` [dpdk-dev] [PATCH v4 1/3] app/testpmd: fix mempool free on exit Shahaf Shuler
2019-04-07 5:02 ` Shahaf Shuler
2019-04-08 14:14 ` Iremonger, Bernard
2019-04-08 14:14 ` Iremonger, Bernard
2019-04-07 5:02 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: support creation of no IOVA contig mempools Shahaf Shuler
2019-04-07 5:02 ` Shahaf Shuler
2019-04-07 5:02 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: map anonymous memory for eth devices Shahaf Shuler
2019-04-07 5:02 ` Shahaf Shuler
2019-04-11 14:07 ` [dpdk-dev] [PATCH v4 0/3] DMA map anonymous memory to " Ferruh Yigit
2019-04-11 14:07 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260D86619@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).