From: Andrius Sirvys <andrius.sirvys@intel.com>
To: dev@dpdk.org
Cc: kevin.laatz@intel.com, stable@dpdk.org,
Andrius Sirvys <andrius.sirvys@intel.com>,
ciara.power@intel.com
Subject: [dpdk-dev] [PATCH v2] usertools: replace unsafe input function
Date: Mon, 8 Apr 2019 14:40:48 +0100 [thread overview]
Message-ID: <1554730848-97709-1-git-send-email-andrius.sirvys@intel.com> (raw)
Message-ID: <20190408134048.wT13FclWkIZ__3YVHdrz5nMiV8SGiqQIwnwnqp75d5U@z> (raw)
In-Reply-To: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com>
LGTM static code analysis tool reports that the function 'input' is
unsafe. Changed to use raw_input which then converts it using
ast.literal_eval() which is safe.
Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry")
Cc: ciara.power@intel.com
Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
---
v2:raw_input doesn't exist in Python 3, added a clause
to check python version
---
usertools/dpdk-telemetry-client.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index ce0c7a9..5f6c47b 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -14,6 +14,11 @@
API_UNREG = "{\"action\":2,\"command\":\"clients\",\"data\":{\"client_path\":\""
DEFAULT_FP = "/var/run/dpdk/default_client"
+try:
+ raw_input # Python 2
+except NameError:
+ raw_input = input # Python 3
+
class Socket:
def __init__(self):
--
2.7.4
next prev parent reply other threads:[~2019-04-08 13:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 16:43 [dpdk-dev] [PATCH] " Andrius Sirvys
2019-03-20 16:43 ` Andrius Sirvys
2019-04-03 10:31 ` Laatz, Kevin
2019-04-03 10:31 ` Laatz, Kevin
2019-04-03 10:44 ` Burakov, Anatoly
2019-04-03 10:44 ` Burakov, Anatoly
2019-04-03 13:30 ` Bruce Richardson
2019-04-03 13:30 ` Bruce Richardson
2019-04-03 14:29 ` Burakov, Anatoly
2019-04-03 14:29 ` Burakov, Anatoly
2019-04-03 14:48 ` Burakov, Anatoly
2019-04-03 14:48 ` Burakov, Anatoly
2019-04-03 14:58 ` Burakov, Anatoly
2019-04-03 14:58 ` Burakov, Anatoly
2019-04-03 15:10 ` Richardson, Bruce
2019-04-03 15:10 ` Richardson, Bruce
2019-04-08 13:40 ` Andrius Sirvys [this message]
2019-04-08 13:40 ` [dpdk-dev] [PATCH v2] " Andrius Sirvys
2019-04-09 9:10 ` Burakov, Anatoly
2019-04-09 9:10 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554730848-97709-1-git-send-email-andrius.sirvys@intel.com \
--to=andrius.sirvys@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).