From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id BA3654D27 for ; Tue, 9 Apr 2019 19:14:51 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id e24so10072852pfi.12 for ; Tue, 09 Apr 2019 10:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PXe5EnrleJP5QRUyBNxWsxiDViQcYz4fVWqWuVvtvFE=; b=DlUGG43A317wdtgE2s6gsJ/GdzG2Fc22P9pRbEAN6cXPMhf5bBjBnUvB/X4trB+NQ9 cX47f5Vmzoh5ohWQma4ssn30lzSwD0FhTS86JGHZUp/mSoDUDVndzwCYJ5ERuYDCuPZB f37UMWlFpsrMFnmsIun5W0C2AlJ6WBx3iu4mrecKudjshvKw2FcJIK/BhXlAVUvsl8Wm /lGGGeEALqmj8Am8jV2Fvzk+VJL8c+Gsfsgm38PIhaQCwoz4mLKC+GumYCS6LqfpFsT1 S6Mw41bM6oDWfOFl3cl7l+AxfsplLYj/fUK79c870XDNDADnQzZR8A/6Li+gGhvQKpuU cZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PXe5EnrleJP5QRUyBNxWsxiDViQcYz4fVWqWuVvtvFE=; b=th7VpkZ3fl/bUpCVXi/JjGuZbUaqvIBMvfFjbj9axvQQxcrGxEC+9e5pWk5wwYZdqg U+J9LnEUN7oI/2Gy1ONXR0VI4WlcXbIss23QVMyKESgSo67a1BXLHIHZyKzJ7ZQiP0hU dnZZHbgv9rBqBA3t0/vYSBc9cbGZTM+zzEQG3CQbNd8Cn1VLGdC0fv2vnJH+40Bns5Ci r97cQId0oSovgCqDQkTDB7wdM0fzGe1Ukp0ZaZXbisHTJjB8iFEl9woho5dOu+x0E6ZG 1jQDNJQ9bbrobMYLG1IX4GDLklmT5K3RD6jBCCK2AkRIsxsw9sBTozMPA1R332m+eqUs Zu2Q== X-Gm-Message-State: APjAAAVWGIg46h68B0YvRyvEGyK022XeGIV4dBNlCSn+FILzI8EElWt3 ze8WfIPyDILZZqDZ/ej1IFbayw== X-Google-Smtp-Source: APXvYqyMA2p8cUJy/fCfTSXgOu8SQJjVPZbPFBd3X24HiU2HAQnMZwFwXky2vKC8L39RUzl3BW0/gQ== X-Received: by 2002:a65:51c9:: with SMTP id i9mr35997114pgq.187.1554830090648; Tue, 09 Apr 2019 10:14:50 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o89sm59817871pfi.178.2019.04.09.10.14.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 10:14:50 -0700 (PDT) Date: Tue, 9 Apr 2019 10:14:46 -0700 From: Stephen Hemminger To: "Iremonger, Bernard" Cc: "dev@dpdk.org" Message-ID: <20190409101446.6fe3cd62@shemminger-XPS-13-9360> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D8555E@IRSMSX108.ger.corp.intel.com> References: <20180618213557.15209-2-stephen@networkplumber.org> <20190402203907.28679-1-stephen@networkplumber.org> <20190402203907.28679-3-stephen@networkplumber.org> <8CEF83825BEC744B83065625E567D7C260D8555E@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 17:14:52 -0000 On Mon, 8 Apr 2019 13:07:33 +0000 "Iremonger, Bernard" wrote: > Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, April 2, 2019 9:39 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 > > addresses > > > > The l3fwd example should use the IPv4 addresses defined in RFC5735 and the > > IPv6 addresses defined in RFC5180 for the L3 forwarding example Longest Prefix > > Match table. > > There should probably be a fixes line. > Also the commit line should have the "fix" keyword. The original behavior was not a bug. It was just a poor design choice. Therefore the lack of fixes tag is intentional. Also didn't want this patch to make it into stable release and risk breaking some existing test bed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EEEE9A0096 for ; Tue, 9 Apr 2019 19:14:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B7444D3A; Tue, 9 Apr 2019 19:14:53 +0200 (CEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id BA3654D27 for ; Tue, 9 Apr 2019 19:14:51 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id e24so10072852pfi.12 for ; Tue, 09 Apr 2019 10:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PXe5EnrleJP5QRUyBNxWsxiDViQcYz4fVWqWuVvtvFE=; b=DlUGG43A317wdtgE2s6gsJ/GdzG2Fc22P9pRbEAN6cXPMhf5bBjBnUvB/X4trB+NQ9 cX47f5Vmzoh5ohWQma4ssn30lzSwD0FhTS86JGHZUp/mSoDUDVndzwCYJ5ERuYDCuPZB f37UMWlFpsrMFnmsIun5W0C2AlJ6WBx3iu4mrecKudjshvKw2FcJIK/BhXlAVUvsl8Wm /lGGGeEALqmj8Am8jV2Fvzk+VJL8c+Gsfsgm38PIhaQCwoz4mLKC+GumYCS6LqfpFsT1 S6Mw41bM6oDWfOFl3cl7l+AxfsplLYj/fUK79c870XDNDADnQzZR8A/6Li+gGhvQKpuU cZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PXe5EnrleJP5QRUyBNxWsxiDViQcYz4fVWqWuVvtvFE=; b=th7VpkZ3fl/bUpCVXi/JjGuZbUaqvIBMvfFjbj9axvQQxcrGxEC+9e5pWk5wwYZdqg U+J9LnEUN7oI/2Gy1ONXR0VI4WlcXbIss23QVMyKESgSo67a1BXLHIHZyKzJ7ZQiP0hU dnZZHbgv9rBqBA3t0/vYSBc9cbGZTM+zzEQG3CQbNd8Cn1VLGdC0fv2vnJH+40Bns5Ci r97cQId0oSovgCqDQkTDB7wdM0fzGe1Ukp0ZaZXbisHTJjB8iFEl9woho5dOu+x0E6ZG 1jQDNJQ9bbrobMYLG1IX4GDLklmT5K3RD6jBCCK2AkRIsxsw9sBTozMPA1R332m+eqUs Zu2Q== X-Gm-Message-State: APjAAAVWGIg46h68B0YvRyvEGyK022XeGIV4dBNlCSn+FILzI8EElWt3 ze8WfIPyDILZZqDZ/ej1IFbayw== X-Google-Smtp-Source: APXvYqyMA2p8cUJy/fCfTSXgOu8SQJjVPZbPFBd3X24HiU2HAQnMZwFwXky2vKC8L39RUzl3BW0/gQ== X-Received: by 2002:a65:51c9:: with SMTP id i9mr35997114pgq.187.1554830090648; Tue, 09 Apr 2019 10:14:50 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o89sm59817871pfi.178.2019.04.09.10.14.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 10:14:50 -0700 (PDT) Date: Tue, 9 Apr 2019 10:14:46 -0700 From: Stephen Hemminger To: "Iremonger, Bernard" Cc: "dev@dpdk.org" Message-ID: <20190409101446.6fe3cd62@shemminger-XPS-13-9360> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D8555E@IRSMSX108.ger.corp.intel.com> References: <20180618213557.15209-2-stephen@networkplumber.org> <20190402203907.28679-1-stephen@networkplumber.org> <20190402203907.28679-3-stephen@networkplumber.org> <8CEF83825BEC744B83065625E567D7C260D8555E@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409171446.ywS1-XG0GrWiWLtzbbjbizqYTo-RBr2MqfKbwqxvajk@z> On Mon, 8 Apr 2019 13:07:33 +0000 "Iremonger, Bernard" wrote: > Hi Stephen, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, April 2, 2019 9:39 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 > > addresses > > > > The l3fwd example should use the IPv4 addresses defined in RFC5735 and the > > IPv6 addresses defined in RFC5180 for the L3 forwarding example Longest Prefix > > Match table. > > There should probably be a fixes line. > Also the commit line should have the "fix" keyword. The original behavior was not a bug. It was just a poor design choice. Therefore the lack of fixes tag is intentional. Also didn't want this patch to make it into stable release and risk breaking some existing test bed.