From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 475644F91; Tue, 9 Apr 2019 12:40:09 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 03:40:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="141267012" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga007.fm.intel.com with SMTP; 09 Apr 2019 03:40:01 -0700 Received: by (sSMTP sendmail emulation); Tue, 09 Apr 2019 11:40:00 +0100 Date: Tue, 9 Apr 2019 11:40:00 +0100 From: Bruce Richardson To: David Marchand Cc: dev , dpdk stable Message-ID: <20190409103959.GA671@bricha3-MOBL.ger.corp.intel.com> References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-5-bruce.richardson@intel.com> <20190409100341.GB655@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 10:40:10 -0000 On Tue, Apr 09, 2019 at 12:34:06PM +0200, David Marchand wrote: > On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > > On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > > <[1][2]bruce.richardson@intel.com> wrote: > > > > The definition of CPU_AND differs from Linux to BSD, so we > need to > > use > > RTE_CPU_AND instead. > > Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample > application for > > PQoS CAT and CDP") > > Cc: [2][3]stable@dpdk.org > > > > This creates a dependency on backporting c3568ea37670 ("eal: > restrict > > control threads to startup CPU affinity") which introduced the > > RTE_CPU_AND macro. > > -- > > David Marchand > > > Shall I drop the stable reference from the v2, then? > > We can backport in 18.11, as I would expect c3568ea37670 to be > backported. > The question is more what we want to do with 17.11. > We could backport only the macro bits from this patch if needed. > -- Yes. I'll leave the stable cc and then each maintainer can decide themselves on backport. I'll include note in the patch (below cutline) to call out dependency explicitly. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A5BD9A0096 for ; Tue, 9 Apr 2019 12:40:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5BD14F9B; Tue, 9 Apr 2019 12:40:12 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 475644F91; Tue, 9 Apr 2019 12:40:09 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 03:40:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="141267012" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga007.fm.intel.com with SMTP; 09 Apr 2019 03:40:01 -0700 Received: by (sSMTP sendmail emulation); Tue, 09 Apr 2019 11:40:00 +0100 Date: Tue, 9 Apr 2019 11:40:00 +0100 From: Bruce Richardson To: David Marchand Cc: dev , dpdk stable Message-ID: <20190409103959.GA671@bricha3-MOBL.ger.corp.intel.com> References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-5-bruce.richardson@intel.com> <20190409100341.GB655@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409104000.E1Ja8z6_24HUytxV6GNxTHa11DoYTZedNrotJRo7S1Q@z> On Tue, Apr 09, 2019 at 12:34:06PM +0200, David Marchand wrote: > On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > > On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > > <[1][2]bruce.richardson@intel.com> wrote: > > > > The definition of CPU_AND differs from Linux to BSD, so we > need to > > use > > RTE_CPU_AND instead. > > Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample > application for > > PQoS CAT and CDP") > > Cc: [2][3]stable@dpdk.org > > > > This creates a dependency on backporting c3568ea37670 ("eal: > restrict > > control threads to startup CPU affinity") which introduced the > > RTE_CPU_AND macro. > > -- > > David Marchand > > > Shall I drop the stable reference from the v2, then? > > We can backport in 18.11, as I would expect c3568ea37670 to be > backported. > The question is more what we want to do with 17.11. > We could backport only the macro bits from this patch if needed. > -- Yes. I'll leave the stable cc and then each maintainer can decide themselves on backport. I'll include note in the patch (below cutline) to call out dependency explicitly. /Bruce