From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id A692A58C4 for ; Tue, 9 Apr 2019 22:06:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B16BA31D; Tue, 9 Apr 2019 16:06:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 09 Apr 2019 16:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=EvN2RhvXxqPYcZlrutxd4ZThQFrtDI0x/cwZIwAFzJI=; b=jlICcMGMMEAt S5f3+iE2T9e1IE1ivoJxXf1/Z4Rpc6HKFPA8LOXfQf3lMEObZcRZXm6QIgdqL1f3 x+qaG3kQV4D4CKy7RPt1u6MIjDFSeHk7Zq4iwlnX2WPY8MgshklM/SR87mtjn7qP AXwMoI8gpyehLEIwhHBvV0LmPyMw8hE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=EvN2RhvXxqPYcZlrutxd4ZThQFrtDI0x/cwZIwAFz JI=; b=E5ugZJXVCvhX40JAZaEGpwKq/N9q79pJj12ly8tV9fhG2Yv7cQUXZDV8F HUu7jZcaa3wFECYdLo80QHxV3VINb05whm67uQDl3M3kPLPo3zxiicFR46B77P9X BZxM++csKct+0Foq3S3eXXqwTcI46+09bJwqDAPWpKC5XEdvSrYCtCmsdQ66gM7N cONR5T0NnOmdUXhHkQjTiFDIXZ31Jkjsj/dmyWx2M/RhF4F3VK77C8pOKSwlILWn loeojerftV9kHOreT27c0QPKErzvtGHfz4JNFa1wklSFrI52UFwJvggUnavoUhBJ dA2jka8+dcAqJezxAnVfLX+dxEVcg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudehgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenuchmihhsshhinhhgucfvqfcufhhivghlugculdeftd dmnecujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepvfhh ohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqe enucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhm pehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 38FE3E409D for ; Tue, 9 Apr 2019 16:06:39 -0400 (EDT) From: Thomas Monjalon To: Cc: dev@dpdk.org Date: Tue, 9 Apr 2019 22:06:34 +0200 Message-Id: <20190409200636.2193-1-thomas@monjalon.net> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190409194904.6822-1-thomas@monjalon.net> References: <20190409194904.6822-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 0/2] fix big endian build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 20:06:42 -0000 There are at least 4 issues when compiling with a big endian toolchain. 2 of them are fixed in this patchset. The remaining ones are in ice and bnxt PMDs. About ice, the error is: drivers/net/ice/base/ice_flex_pipe.c:302:8: error: ‘state.entry_idx’ may be used uninitialized in this function It is not obvious to fix, there may be few places where a struct should be initialized. Please fix it soon. About bnxt, the issue looks like a mistake reproduced several times: drivers/net/bnxt/bnxt_ethdev.c:2652:19: error: invalid use of void expression rte_cpu_to_le_32(rte_write32(reg_base, (uint8_t *)bp->bar0 + win_off)); The pattern "rte_cpu_to_le_32(rte_write32(" can be seen 4 times. The result of the endian conversion is never used. Please fix it soon. Thomas Monjalon (2): mbuf: fix big endian build net/enetc: fix big endian build v2 for checkpatch drivers/net/enetc/enetc_rxtx.c | 5 +++-- lib/librte_mbuf/rte_mbuf.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 164CEA0096 for ; Tue, 9 Apr 2019 22:06:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3DD6F5920; Tue, 9 Apr 2019 22:06:42 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id A692A58C4 for ; Tue, 9 Apr 2019 22:06:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B16BA31D; Tue, 9 Apr 2019 16:06:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 09 Apr 2019 16:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=EvN2RhvXxqPYcZlrutxd4ZThQFrtDI0x/cwZIwAFzJI=; b=jlICcMGMMEAt S5f3+iE2T9e1IE1ivoJxXf1/Z4Rpc6HKFPA8LOXfQf3lMEObZcRZXm6QIgdqL1f3 x+qaG3kQV4D4CKy7RPt1u6MIjDFSeHk7Zq4iwlnX2WPY8MgshklM/SR87mtjn7qP AXwMoI8gpyehLEIwhHBvV0LmPyMw8hE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=EvN2RhvXxqPYcZlrutxd4ZThQFrtDI0x/cwZIwAFz JI=; b=E5ugZJXVCvhX40JAZaEGpwKq/N9q79pJj12ly8tV9fhG2Yv7cQUXZDV8F HUu7jZcaa3wFECYdLo80QHxV3VINb05whm67uQDl3M3kPLPo3zxiicFR46B77P9X BZxM++csKct+0Foq3S3eXXqwTcI46+09bJwqDAPWpKC5XEdvSrYCtCmsdQ66gM7N cONR5T0NnOmdUXhHkQjTiFDIXZ31Jkjsj/dmyWx2M/RhF4F3VK77C8pOKSwlILWn loeojerftV9kHOreT27c0QPKErzvtGHfz4JNFa1wklSFrI52UFwJvggUnavoUhBJ dA2jka8+dcAqJezxAnVfLX+dxEVcg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudehgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenuchmihhsshhinhhgucfvqfcufhhivghlugculdeftd dmnecujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepvfhh ohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqe enucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhm pehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 38FE3E409D for ; Tue, 9 Apr 2019 16:06:39 -0400 (EDT) From: Thomas Monjalon To: Cc: dev@dpdk.org Date: Tue, 9 Apr 2019 22:06:34 +0200 Message-Id: <20190409200636.2193-1-thomas@monjalon.net> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190409194904.6822-1-thomas@monjalon.net> References: <20190409194904.6822-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 0/2] fix big endian build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409200634.eDP-yyEnEI4QrHoowK_HlMwVNGm4_FS2Vh9MyTF_T94@z> There are at least 4 issues when compiling with a big endian toolchain. 2 of them are fixed in this patchset. The remaining ones are in ice and bnxt PMDs. About ice, the error is: drivers/net/ice/base/ice_flex_pipe.c:302:8: error: ‘state.entry_idx’ may be used uninitialized in this function It is not obvious to fix, there may be few places where a struct should be initialized. Please fix it soon. About bnxt, the issue looks like a mistake reproduced several times: drivers/net/bnxt/bnxt_ethdev.c:2652:19: error: invalid use of void expression rte_cpu_to_le_32(rte_write32(reg_base, (uint8_t *)bp->bar0 + win_off)); The pattern "rte_cpu_to_le_32(rte_write32(" can be seen 4 times. The result of the endian conversion is never used. Please fix it soon. Thomas Monjalon (2): mbuf: fix big endian build net/enetc: fix big endian build v2 for checkpatch drivers/net/enetc/enetc_rxtx.c | 5 +++-- lib/librte_mbuf/rte_mbuf.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) -- 2.21.0