From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EBD18A0096 for ; Wed, 10 Apr 2019 00:55:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C5665587; Wed, 10 Apr 2019 00:55:56 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 669D3548B for ; Wed, 10 Apr 2019 00:55:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 15:55:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,331,1549958400"; d="scan'208";a="290165751" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga004.jf.intel.com with ESMTP; 09 Apr 2019 15:55:53 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.31]) by IRSMSX151.ger.corp.intel.com ([169.254.4.174]) with mapi id 14.03.0415.000; Tue, 9 Apr 2019 23:55:52 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon , Olivier Matz CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 1/2] mbuf: fix big endian build Thread-Index: AQHU7w/KxFi8rAds0k+hG2Sl+NzeIaY0cDEw Date: Tue, 9 Apr 2019 22:55:51 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772580148A94ED9@irsmsx105.ger.corp.intel.com> References: <20190409194904.6822-1-thomas@monjalon.net> <20190409200636.2193-1-thomas@monjalon.net> <20190409200636.2193-2-thomas@monjalon.net> In-Reply-To: <20190409200636.2193-2-thomas@monjalon.net> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzJkNTRjNTctZGIyNy00NjQyLWI2YjgtNTkzMDM3NjhjMjJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZkpsXC9mZ1paeGdNS00yN2pVTHNpUjZXbkdWT0VCTlNHS3A0bkxSVStcLzFhUGRkcnpkZ2VcL0ZuV29zWG1BNFpGbCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] mbuf: fix big endian build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409225551.UeMMkXj5Oslp1nyBcfBmy1MHIWBKLWYigqB2g1ZSPM8@z> >=20 > Compilation was failing when using a big endian toolchain: >=20 > rte_mbuf.h:504:2: error: expected ',' or '}' before 'RTE_MBUF_L3_LEN_OFS' >=20 > Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value= ") > Cc: konstantin.ananyev@intel.com >=20 > Signed-off-by: Thomas Monjalon > --- > lib/librte_mbuf/rte_mbuf.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index f7886dcb3..7dd2e7fb3 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -500,7 +500,7 @@ enum { > RTE_MBUF_OUTL2_LEN_BITS, > #if RTE_BYTE_ORDER =3D=3D RTE_BIG_ENDIAN > RTE_MBUF_L2_LEN_OFS =3D > - sizeof(uint64_t) * CHAR_BIT - RTE_MBUF_L2_LEN_BITS > + sizeof(uint64_t) * CHAR_BIT - RTE_MBUF_L2_LEN_BITS, > RTE_MBUF_L3_LEN_OFS =3D RTE_MBUF_L2_LEN_OFS - RTE_MBUF_L3_LEN_BITS, > RTE_MBUF_L4_LEN_OFS =3D RTE_MBUF_L3_LEN_OFS - RTE_MBUF_L4_LEN_BITS, > RTE_MBUF_TSO_SEGSZ_OFS =3D RTE_MBUF_L4_LEN_OFS - RTE_MBUF_TSO_SEGSZ_BIT= S, > -- Thanks for fixing Acked-by: Konstantin Ananyev > 2.21.0