Fix unchecked return value for fcntl. Coverity issue: 277210 Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Cc: stable@dpdk.org Signed-off-by: Chenbo Xia <chenbo.xia@intel.com> --- drivers/net/virtio/virtio_user/vhost_user.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c index 827a48ad6..4b74bd2d8 100644 --- a/drivers/net/virtio/virtio_user/vhost_user.c +++ b/drivers/net/virtio/virtio_user/vhost_user.c @@ -394,7 +394,10 @@ virtio_user_start_server(struct virtio_user_dev *dev, struct sockaddr_un *un) return -1; flag = fcntl(fd, F_GETFL); - fcntl(fd, F_SETFL, flag | O_NONBLOCK); + if (fcntl(fd, F_SETFL, flag | O_NONBLOCK) < 0) { + PMD_DRV_LOG(ERR, "fcntl failed, %s", strerror(errno)); + return -1; + } return 0; } -- 2.17.1
Fix unchecked return value for fcntl. Coverity issue: 277210 Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Cc: stable@dpdk.org Signed-off-by: Chenbo Xia <chenbo.xia@intel.com> --- drivers/net/virtio/virtio_user/vhost_user.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c index 827a48ad6..4b74bd2d8 100644 --- a/drivers/net/virtio/virtio_user/vhost_user.c +++ b/drivers/net/virtio/virtio_user/vhost_user.c @@ -394,7 +394,10 @@ virtio_user_start_server(struct virtio_user_dev *dev, struct sockaddr_un *un) return -1; flag = fcntl(fd, F_GETFL); - fcntl(fd, F_SETFL, flag | O_NONBLOCK); + if (fcntl(fd, F_SETFL, flag | O_NONBLOCK) < 0) { + PMD_DRV_LOG(ERR, "fcntl failed, %s", strerror(errno)); + return -1; + } return 0; } -- 2.17.1
Fix unchecked return value for fcntl. Coverity issue: 277210 Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Cc: stable@dpdk.org Signed-off-by: Chenbo Xia <chenbo.xia@intel.com> --- Acked-by: Rami Rosen <ramirose@gmail.com>
Fix unchecked return value for fcntl. Coverity issue: 277210 Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Cc: stable@dpdk.org Signed-off-by: Chenbo Xia <chenbo.xia@intel.com> --- Acked-by: Rami Rosen <ramirose@gmail.com>
On Wed, Apr 10, 2019 at 02:44:05AM +0000, Chenbo Xia wrote:
>Fix unchecked return value for fcntl.
>
>Coverity issue: 277210
>Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
>Cc: stable@dpdk.org
>
>Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
>---
> drivers/net/virtio/virtio_user/vhost_user.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
On Wed, Apr 10, 2019 at 02:44:05AM +0000, Chenbo Xia wrote:
>Fix unchecked return value for fcntl.
>
>Coverity issue: 277210
>Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
>Cc: stable@dpdk.org
>
>Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
>---
> drivers/net/virtio/virtio_user/vhost_user.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
On Wed, Apr 10, 2019 at 02:44:05AM +0000, Chenbo Xia wrote:
> Fix unchecked return value for fcntl.
>
> Coverity issue: 277210
> Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
> drivers/net/virtio/virtio_user/vhost_user.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
On Wed, Apr 10, 2019 at 02:44:05AM +0000, Chenbo Xia wrote:
> Fix unchecked return value for fcntl.
>
> Coverity issue: 277210
> Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
> drivers/net/virtio/virtio_user/vhost_user.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
On 4/10/19 4:44 AM, Chenbo Xia wrote:
> Fix unchecked return value for fcntl.
>
> Coverity issue: 277210
> Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> Cc:stable@dpdk.org
>
> Signed-off-by: Chenbo Xia<chenbo.xia@intel.com>
> ---
> drivers/net/virtio/virtio_user/vhost_user.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
On 4/10/19 4:44 AM, Chenbo Xia wrote:
> Fix unchecked return value for fcntl.
>
> Coverity issue: 277210
> Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> Cc:stable@dpdk.org
>
> Signed-off-by: Chenbo Xia<chenbo.xia@intel.com>
> ---
> drivers/net/virtio/virtio_user/vhost_user.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
Setting the flags of tapfd may fail and the return value should be checked. Coverity issue: 140739 Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost") Cc: stable@dpdk.org Signed-off-by: Chenbo Xia <chenbo.xia@intel.com> --- drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c index 2fa4f0d66..acddefa33 100644 --- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c +++ b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c @@ -128,7 +128,10 @@ vhost_kernel_open_tap(char **p_ifname, int hdr_size, int req_mq, goto error; } - fcntl(tapfd, F_SETFL, O_NONBLOCK); + if (fcntl(tapfd, F_SETFL, O_NONBLOCK) < 0) { + PMD_DRV_LOG(ERR, "fcntl tapfd failed: %s", strerror(errno)); + goto error; + } if (ioctl(tapfd, TUNSETVNETHDRSZ, &hdr_size) < 0) { PMD_DRV_LOG(ERR, "TUNSETVNETHDRSZ failed: %s", strerror(errno)); -- 2.17.1
On 7/29/20 3:12 PM, Chenbo Xia wrote:
> Setting the flags of tapfd may fail and the return value
> should be checked.
>
> Coverity issue: 140739
> Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
> drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
> index 2fa4f0d66..acddefa33 100644
> --- a/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
> +++ b/drivers/net/virtio/virtio_user/vhost_kernel_tap.c
> @@ -128,7 +128,10 @@ vhost_kernel_open_tap(char **p_ifname, int hdr_size, int req_mq,
> goto error;
> }
>
> - fcntl(tapfd, F_SETFL, O_NONBLOCK);
> + if (fcntl(tapfd, F_SETFL, O_NONBLOCK) < 0) {
> + PMD_DRV_LOG(ERR, "fcntl tapfd failed: %s", strerror(errno));
> + goto error;
> + }
>
> if (ioctl(tapfd, TUNSETVNETHDRSZ, &hdr_size) < 0) {
> PMD_DRV_LOG(ERR, "TUNSETVNETHDRSZ failed: %s", strerror(errno));
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
On 7/29/20 3:12 PM, Chenbo Xia wrote:
> Setting the flags of tapfd may fail and the return value
> should be checked.
>
> Coverity issue: 140739
> Fixes: e3b434818bbb ("net/virtio-user: support kernel vhost")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
> drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied to dpdk-next-virtio/master.
Thanks,
Maxime