From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 37B54A0096 for ; Wed, 10 Apr 2019 13:27:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 843225592; Wed, 10 Apr 2019 13:27:45 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60088.outbound.protection.outlook.com [40.107.6.88]) by dpdk.org (Postfix) with ESMTP id 74CC35589; Wed, 10 Apr 2019 13:27:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TBaXusvGejEDywA5Z5COWxxrIJv6TtREXRZMejm2rDg=; b=XOJh8DON5TMOoKcsuJLHRA5dMmbXBnnnKCFJ7WfCXFyoMCYsUA38kmS2vV11jZTgrk32NWlOjK17m7LWoCqS7NF0Knb/unB0sS50f/xGr4bZ8/2SY2NQ5w7AA65SMuzE91fCMrtwsBVX9l8rf1iyTOO2xTTp0ER3DOUidafGyXA= Received: from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by VE1PR04MB6461.eurprd04.prod.outlook.com (20.179.233.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Wed, 10 Apr 2019 11:27:41 +0000 Received: from VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0]) by VE1PR04MB6365.eurprd04.prod.outlook.com ([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016; Wed, 10 Apr 2019 11:27:41 +0000 From: Gagandeep Singh To: Thomas Monjalon , Pankaj Chauhan CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2 2/2] net/enetc: fix big endian build Thread-Index: AdTvj4ymiBX56z1PTQm4IFpXkFSCqw== Date: Wed, 10 Apr 2019 11:27:41 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=G.Singh@nxp.com; x-originating-ip: [92.120.0.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 829aa72f-fb2c-4a11-456a-08d6bda78b7e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6461; x-ms-traffictypediagnostic: VE1PR04MB6461: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-forefront-prvs: 00032065B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(396003)(136003)(376002)(39860400002)(189003)(199004)(13464003)(486006)(53546011)(476003)(6116002)(81166006)(86362001)(6306002)(66066001)(55016002)(6436002)(8936002)(25786009)(6506007)(7696005)(4326008)(99286004)(229853002)(53936002)(9686003)(97736004)(68736007)(6246003)(102836004)(8676002)(508600001)(106356001)(7736002)(110136005)(305945005)(72206003)(54906003)(105586002)(5660300002)(186003)(14444005)(5024004)(71190400001)(71200400001)(256004)(2906002)(3846002)(33656002)(74316002)(81156014)(14454004)(966005)(6636002)(316002)(26005)(52536014); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6461; H:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: /UTGhjUkYXGA0BiVKaN+I4JavgHuYsPPKMDe1AC9/5Ze8XJojG6PUWzmjHK5JdzQWAVvklURICVKAYuJbGqY/WXG2+v/umhZvqmiKHk2zreQIPw92ziM66aL87IIB2fLyEfK2GEbrWx/XdrIlyLRIr+FJaNEO+hY8NvdJUVx3MnKTFT41Tmx5IzyWSRz+k6+vOdqmTdUmW4l7wmX6y1tUYm9Lr+meYmZtlhJ7wAZNDDBYzuJqwyBOpGG8l6oVmTy9K5aTsowdPBgBpeoKXz9XInDIazHo8dRN7RrLLPKfRo2OCXOWF5UNJvVCrt8S2XwjgtiTMDyhY+5xMgW/F7nu0EWkoVI/lIdZ0DIcuhsuzYCk/n9DgHpatom5gPZsN5cY/hQHvAkM7XEF5Mc5mCMotPaK3FmS8eWxqXzSioNdGs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 829aa72f-fb2c-4a11-456a-08d6bda78b7e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2019 11:27:41.6279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6461 Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/enetc: fix big endian build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410112741.fkSgzvJq9E-yRpEf3cyxToPF74s_X1UvuAXAKp8bUWY@z> > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, April 10, 2019 1:37 AM > To: Gagandeep Singh ; Pankaj Chauhan > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [EXT] [PATCH v2 2/2] net/enetc: fix big endian build >=20 > WARNING: This email was created outside of NXP. DO NOT CLICK links or > attachments unless you recognize the sender and know the content is safe. >=20 >=20 >=20 > Compilation was failing when using a big endian toolchain: >=20 > drivers/net/enetc/enetc_rxtx.c:92:21: error: > passing argument 1 of 'rte_constant_bswap64' > makes integer from pointer without a cast >=20 > Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") > Cc: g.singh@nxp.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Thomas Monjalon > --- > drivers/net/enetc/enetc_rxtx.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxt= x.c > index 631e2430d..ef0d7919f 100644 > --- a/drivers/net/enetc/enetc_rxtx.c > +++ b/drivers/net/enetc/enetc_rxtx.c > @@ -88,8 +88,9 @@ enetc_refill_rx_ring(struct enetc_bdr *rx_ring, const i= nt > buff_cnt) > rx_swbd =3D &rx_ring->q_swbd[i]; > rxbd =3D ENETC_RXBD(*rx_ring, i); > for (j =3D 0; j < buff_cnt; j++) { > - rx_swbd->buffer_addr =3D > - rte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_p= ool)); > + rx_swbd->buffer_addr =3D (void *)(uintptr_t) > + rte_cpu_to_le_64((uint64_t)(uintptr_t) > + rte_mbuf_raw_alloc(rx_ring->mb_po= ol)); > rxbd->w.addr =3D (uint64_t)(uintptr_t) > rx_swbd->buffer_addr->buf_addr + > rx_swbd->buffer_addr->data_off; > -- > 2.21.0 Hi Thomas, I have sent a patch-set for ENETC driver having some changes in "enetc_refi= ll_rx_ring". Is it ok for you if I can merge your changes with my patch-set and push the= m in v2? https://patches.dpdk.org/project/dpdk/list/?series=3D4173=20 Thanks, Gagan