From: Ayuj Verma <ayverma@marvell.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
"arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
Shally Verma <shallyv@marvell.com>,
"Sunila Sahu" <ssahu@marvell.com>,
Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>,
Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP
Date: Wed, 10 Apr 2019 12:33:23 +0000 [thread overview]
Message-ID: <MN2PR18MB2542D178B107E3DF570BF8F2AD2E0@MN2PR18MB2542.namprd18.prod.outlook.com> (raw)
Message-ID: <20190410123323.4Yj3LQiJgt3iQlQTcefL6Q-A2O8ZrcQfDgNPCwyo7Zw@z> (raw)
In-Reply-To: <20190409145532.GA693@bricha3-MOBL.ger.corp.intel.com>
Hi Bruce,
Have you gone through patch-set v1<http://mails.dpdk.org/archives/dev/2019-April/128407.html>
What's your opinion on them.
Thanks and regards
Ayuj Verma
________________________________
From: Bruce Richardson <bruce.richardson@intel.com>
Sent: 09 April 2019 20:25:32
To: Ayuj Verma
Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; arkadiuszx.kusztal@intel.com; pablo.de.lara.guarch@intel.com; Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev@dpdk.org
Subject: [EXT] Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP
External Email
----------------------------------------------------------------------
On Tue, Apr 09, 2019 at 05:03:39PM +0530, Ayuj Verma wrote:
> Return -ENOTSUP for unsupported tests
>
I disagree with this, since TEST_SKIPPED is the correct return value for
unsupported test conditions IMHO. If part of the current infrastructure
doesn't support that return value, I think the infrastructure should be
updated.
Ref: http://mesonbuild.com/Unit-tests.html#skipped-tests-and-hard-errors
/Bruce
next prev parent reply other threads:[~2019-04-10 12:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 11:33 [dpdk-dev] [PATCH v2] fix return value for skipped tests Ayuj Verma
2019-04-09 11:33 ` Ayuj Verma
2019-04-09 11:33 ` [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Ayuj Verma
2019-04-09 11:33 ` Ayuj Verma
2019-04-09 14:55 ` Bruce Richardson
2019-04-09 14:55 ` Bruce Richardson
2019-04-10 12:33 ` Ayuj Verma [this message]
2019-04-10 12:33 ` [dpdk-dev] [EXT] " Ayuj Verma
2019-04-10 12:48 ` Bruce Richardson
2019-04-10 12:48 ` Bruce Richardson
2019-04-09 15:17 ` [dpdk-dev] " Trahe, Fiona
2019-04-09 15:17 ` Trahe, Fiona
2019-04-12 7:08 ` Ayuj Verma
2019-04-12 7:08 ` Ayuj Verma
2019-04-12 10:25 ` Trahe, Fiona
2019-04-12 10:25 ` Trahe, Fiona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB2542D178B107E3DF570BF8F2AD2E0@MN2PR18MB2542.namprd18.prod.outlook.com \
--to=ayverma@marvell.com \
--cc=adesai@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=kkotamarthy@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=shallyv@marvell.com \
--cc=ssahu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).