From: Bruce Richardson <bruce.richardson@intel.com>
To: Ayuj Verma <ayverma@marvell.com>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
"arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>,
Shally Verma <shallyv@marvell.com>,
Sunila Sahu <ssahu@marvell.com>,
Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>,
Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP
Date: Wed, 10 Apr 2019 13:48:20 +0100 [thread overview]
Message-ID: <20190410124820.GA718@bricha3-MOBL.ger.corp.intel.com> (raw)
Message-ID: <20190410124820.6kRSmew0tL_E4_tUgAKi_wKu5oPJDIgV8nCUD5ETIoA@z> (raw)
In-Reply-To: <MN2PR18MB2542D178B107E3DF570BF8F2AD2E0@MN2PR18MB2542.namprd18.prod.outlook.com>
On Wed, Apr 10, 2019 at 12:33:23PM +0000, Ayuj Verma wrote:
> Hi Bruce,
>
> Have you gone through patch-set [1]v1
>
> What's your opinion on them.
>
> Thanks and regards
>
> Ayuj Verma
Looked at http://mails.dpdk.org/archives/dev/2019-April/128407.html
I like the idea of tracking the skips, and I suggest you go further and
actually track the -ENOTSUP errors as skips too. I don't see any change in
the reported output in that patch though - how are the skips reported if at
all?
/Bruce
next prev parent reply other threads:[~2019-04-10 12:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 11:33 [dpdk-dev] [PATCH v2] fix return value for skipped tests Ayuj Verma
2019-04-09 11:33 ` Ayuj Verma
2019-04-09 11:33 ` [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Ayuj Verma
2019-04-09 11:33 ` Ayuj Verma
2019-04-09 14:55 ` Bruce Richardson
2019-04-09 14:55 ` Bruce Richardson
2019-04-10 12:33 ` [dpdk-dev] [EXT] " Ayuj Verma
2019-04-10 12:33 ` Ayuj Verma
2019-04-10 12:48 ` Bruce Richardson [this message]
2019-04-10 12:48 ` Bruce Richardson
2019-04-09 15:17 ` [dpdk-dev] " Trahe, Fiona
2019-04-09 15:17 ` Trahe, Fiona
2019-04-12 7:08 ` Ayuj Verma
2019-04-12 7:08 ` Ayuj Verma
2019-04-12 10:25 ` Trahe, Fiona
2019-04-12 10:25 ` Trahe, Fiona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410124820.GA718@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=adesai@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=ayverma@marvell.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=kkotamarthy@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=shallyv@marvell.com \
--cc=ssahu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).