From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3A99C7D4A for ; Wed, 10 Apr 2019 14:48:26 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 05:48:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="222217013" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by orsmga001.jf.intel.com with SMTP; 10 Apr 2019 05:48:22 -0700 Received: by (sSMTP sendmail emulation); Wed, 10 Apr 2019 13:48:21 +0100 Date: Wed, 10 Apr 2019 13:48:20 +0100 From: Bruce Richardson To: Ayuj Verma Cc: "akhil.goyal@nxp.com" , "fiona.trahe@intel.com" , "arkadiuszx.kusztal@intel.com" , "pablo.de.lara.guarch@intel.com" , Shally Verma , Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" Message-ID: <20190410124820.GA718@bricha3-MOBL.ger.corp.intel.com> References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com> <20190409145532.GA693@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 12:48:28 -0000 On Wed, Apr 10, 2019 at 12:33:23PM +0000, Ayuj Verma wrote: > Hi Bruce, > > Have you gone through patch-set [1]v1 > > What's your opinion on them. > > Thanks and regards > > Ayuj Verma Looked at http://mails.dpdk.org/archives/dev/2019-April/128407.html I like the idea of tracking the skips, and I suggest you go further and actually track the -ENOTSUP errors as skips too. I don't see any change in the reported output in that patch though - how are the skips reported if at all? /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4E1ACA0096 for ; Wed, 10 Apr 2019 14:48:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E5ED1B0FB; Wed, 10 Apr 2019 14:48:31 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 3A99C7D4A for ; Wed, 10 Apr 2019 14:48:26 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 05:48:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="222217013" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by orsmga001.jf.intel.com with SMTP; 10 Apr 2019 05:48:22 -0700 Received: by (sSMTP sendmail emulation); Wed, 10 Apr 2019 13:48:21 +0100 Date: Wed, 10 Apr 2019 13:48:20 +0100 From: Bruce Richardson To: Ayuj Verma Cc: "akhil.goyal@nxp.com" , "fiona.trahe@intel.com" , "arkadiuszx.kusztal@intel.com" , "pablo.de.lara.guarch@intel.com" , Shally Verma , Sunila Sahu , Kanaka Durga Kotamarthy , Arvind Desai , "dev@dpdk.org" Message-ID: <20190410124820.GA718@bricha3-MOBL.ger.corp.intel.com> References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com> <20190409145532.GA693@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410124820.6kRSmew0tL_E4_tUgAKi_wKu5oPJDIgV8nCUD5ETIoA@z> On Wed, Apr 10, 2019 at 12:33:23PM +0000, Ayuj Verma wrote: > Hi Bruce, > > Have you gone through patch-set [1]v1 > > What's your opinion on them. > > Thanks and regards > > Ayuj Verma Looked at http://mails.dpdk.org/archives/dev/2019-April/128407.html I like the idea of tracking the skips, and I suggest you go further and actually track the -ENOTSUP errors as skips too. I don't see any change in the reported output in that patch though - how are the skips reported if at all? /Bruce