From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id EA331A0096
	for <public@inbox.dpdk.org>; Wed, 10 Apr 2019 22:58:45 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D754F1B3AC;
	Wed, 10 Apr 2019 22:58:44 +0200 (CEST)
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com
 [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 2CC581B142
 for <dev@dpdk.org>; Wed, 10 Apr 2019 22:58:43 +0200 (CEST)
Received: from pps.filterd (m0098393.ppops.net [127.0.0.1])
 by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id
 x3AKsJAC101912 for <dev@dpdk.org>; Wed, 10 Apr 2019 16:58:42 -0400
Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205])
 by mx0a-001b2d01.pphosted.com with ESMTP id 2rsmj1hjtr-1
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)
 for <dev@dpdk.org>; Wed, 10 Apr 2019 16:58:42 -0400
Received: from localhost
 by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
 Violators will be prosecuted
 for <dev@dpdk.org> from <drc@linux.vnet.ibm.com>;
 Wed, 10 Apr 2019 21:58:41 +0100
Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25)
 by e15.ny.us.ibm.com (146.89.104.202) with IBM ESMTP SMTP Gateway: Authorized
 Use Only! Violators will be prosecuted; 
 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256)
 Wed, 10 Apr 2019 21:58:37 +0100
Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com
 [9.57.199.106])
 by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
 x3AKwauT32833638
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Wed, 10 Apr 2019 20:58:36 GMT
Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id 2EF9B2805E;
 Wed, 10 Apr 2019 20:58:36 +0000 (GMT)
Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id 89F3928058;
 Wed, 10 Apr 2019 20:58:35 +0000 (GMT)
Received: from davids-mbp.usor.ibm.com (unknown [9.70.85.33])
 by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP;
 Wed, 10 Apr 2019 20:58:35 +0000 (GMT)
To: Thomas Monjalon <thomas@monjalon.net>
Cc: ferruh.yigit@intel.com, arybchenko@solarflare.com, dev@dpdk.org,
 radhika.chirra@ibm.com, stable@dpdk.org, Vivian Kong <vivkong@ca.ibm.com>
References: <1554927376-93022-1-git-send-email-drc@linux.vnet.ibm.com>
 <1741590.oPye4Mstr3@xps>
From: David Christensen <drc@linux.vnet.ibm.com>
Date: Wed, 10 Apr 2019 13:58:35 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1741590.oPye4Mstr3@xps>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-TM-AS-GCONF: 00
x-cbid: 19041020-0068-0000-0000-000003B35118
X-IBM-SpamModules-Scores: 
X-IBM-SpamModules-Versions: BY=3.00010904; HX=3.00000242; KW=3.00000007;
 PH=3.00000004; SC=3.00000284; SDB=6.01187222; UDB=6.00621858; IPR=6.00967985; 
 MB=3.00026382; MTD=3.00000008; XFM=3.00000015; UTC=2019-04-10 20:58:39
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 19041020-0069-0000-0000-0000481CB924
Message-Id: <a8c995fe-d809-be32-9222-c48a14ac36a7@linux.vnet.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, ,
 definitions=2019-04-10_09:, , signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1904100136
Subject: Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in
 eth_dev_pci_specific_init
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190410205835.6BSl_9XY_ZkxNFxG7BPxF1sODzLf404cXjNuc-_RT0c@z>

> This is a duplicate of this patch:
> 
> https://patches.dpdk.org/patch/52505/
> 
> You are from 2 different Linux teams at IBM,
> you hit the same issue at the same time,
> you both miss to give an explanation,
> funny.

We both work for infrastructure teams who are supporting a project team 
that is developing a DPDK application that runs across multiple CPU 
architectures and encountered the error.

The error comes from g++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0:

[CXX]       g++ -o utils/pcap_handle.o -c utils/pcap_handle.cc -g3 
-ggdb3 -mcpu=native -mtune=native -isystem 
/home/rchirra/gen/io/ppc64include -std=gnu++11 -flax-vector-conversions 
-Werror -isystem /home/rchirra/gen/io

In file included from drivers/pmd.cc:7:0:
/home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:
In function ‘int eth_dev_pci_specific_init(rte_eth_dev*, void*)’:
/home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:75:35: 
error: invalid conversion from ‘void*’ to ‘rte_pci_device*’ [-fpermissive]
   struct rte_pci_device *pci_dev = bus_device;
                                    ^~~~~~~~~~
make[1]: *** [drivers/pmd.o] Error 1

Do you believe that more permissive compiler flags are the better answer?

Dave