* [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code
@ 2019-04-10 13:13 David Hunt
2019-04-10 13:13 ` David Hunt
2019-04-10 23:58 ` Rami Rosen
0 siblings, 2 replies; 6+ messages in thread
From: David Hunt @ 2019-04-10 13:13 UTC (permalink / raw)
To: dev; +Cc: david.hunt, stable
A for loop to MAX_VFS had a break as the last line, so the w++
would never get called, breaking out of the loop after the
first iteration. Remove the break so that the loop can execute
properly.
Fixes: ace158c4a821 ("examples/vm_power: add check for port count")
Coverity issue: 337682
Signed-off-by: David Hunt <david.hunt@intel.com>
---
examples/vm_power_manager/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c
index 893bf4cdd..9b11f66f9 100644
--- a/examples/vm_power_manager/main.c
+++ b/examples/vm_power_manager/main.c
@@ -390,7 +390,6 @@ main(int argc, char **argv)
break;
}
printf("\n");
- break;
}
}
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code
2019-04-10 13:13 [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code David Hunt
@ 2019-04-10 13:13 ` David Hunt
2019-04-10 23:58 ` Rami Rosen
1 sibling, 0 replies; 6+ messages in thread
From: David Hunt @ 2019-04-10 13:13 UTC (permalink / raw)
To: dev; +Cc: david.hunt, stable
A for loop to MAX_VFS had a break as the last line, so the w++
would never get called, breaking out of the loop after the
first iteration. Remove the break so that the loop can execute
properly.
Fixes: ace158c4a821 ("examples/vm_power: add check for port count")
Coverity issue: 337682
Signed-off-by: David Hunt <david.hunt@intel.com>
---
examples/vm_power_manager/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c
index 893bf4cdd..9b11f66f9 100644
--- a/examples/vm_power_manager/main.c
+++ b/examples/vm_power_manager/main.c
@@ -390,7 +390,6 @@ main(int argc, char **argv)
break;
}
printf("\n");
- break;
}
}
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code
2019-04-10 13:13 [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code David Hunt
2019-04-10 13:13 ` David Hunt
@ 2019-04-10 23:58 ` Rami Rosen
2019-04-10 23:58 ` Rami Rosen
2019-04-22 21:05 ` Thomas Monjalon
1 sibling, 2 replies; 6+ messages in thread
From: Rami Rosen @ 2019-04-10 23:58 UTC (permalink / raw)
To: David Hunt; +Cc: dev, stable
David Hunt <david.hunt@intel.com>:
> A for loop to MAX_VFS had a break as the last line, so the w++
> would never get called, breaking out of the loop after the
> first iteration. Remove the break so that the loop can execute
> properly.
>
> Fixes: ace158c4a821 ("examples/vm_power: add check for port count")
> Coverity issue: 337682
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>
Acked-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code
2019-04-10 23:58 ` Rami Rosen
@ 2019-04-10 23:58 ` Rami Rosen
2019-04-22 21:05 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Rami Rosen @ 2019-04-10 23:58 UTC (permalink / raw)
To: David Hunt; +Cc: dev, stable
David Hunt <david.hunt@intel.com>:
> A for loop to MAX_VFS had a break as the last line, so the w++
> would never get called, breaking out of the loop after the
> first iteration. Remove the break so that the loop can execute
> properly.
>
> Fixes: ace158c4a821 ("examples/vm_power: add check for port count")
> Coverity issue: 337682
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>
Acked-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code
2019-04-10 23:58 ` Rami Rosen
2019-04-10 23:58 ` Rami Rosen
@ 2019-04-22 21:05 ` Thomas Monjalon
2019-04-22 21:05 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-22 21:05 UTC (permalink / raw)
To: David Hunt; +Cc: dev, Rami Rosen, stable
> > A for loop to MAX_VFS had a break as the last line, so the w++
> > would never get called, breaking out of the loop after the
> > first iteration. Remove the break so that the loop can execute
> > properly.
> >
> > Fixes: ace158c4a821 ("examples/vm_power: add check for port count")
> > Coverity issue: 337682
> >
> > Signed-off-by: David Hunt <david.hunt@intel.com>
>
> Acked-by: Rami Rosen <ramirose@gmail.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code
2019-04-22 21:05 ` Thomas Monjalon
@ 2019-04-22 21:05 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-22 21:05 UTC (permalink / raw)
To: David Hunt; +Cc: dev, Rami Rosen, stable
> > A for loop to MAX_VFS had a break as the last line, so the w++
> > would never get called, breaking out of the loop after the
> > first iteration. Remove the break so that the loop can execute
> > properly.
> >
> > Fixes: ace158c4a821 ("examples/vm_power: add check for port count")
> > Coverity issue: 337682
> >
> > Signed-off-by: David Hunt <david.hunt@intel.com>
>
> Acked-by: Rami Rosen <ramirose@gmail.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-22 21:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 13:13 [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code David Hunt
2019-04-10 13:13 ` David Hunt
2019-04-10 23:58 ` Rami Rosen
2019-04-10 23:58 ` Rami Rosen
2019-04-22 21:05 ` Thomas Monjalon
2019-04-22 21:05 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).