From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 18184A0096
for <public@inbox.dpdk.org>; Thu, 11 Apr 2019 11:16:58 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C20AD5B3A;
Thu, 11 Apr 2019 11:16:57 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id 71F4F54AE
for <dev@dpdk.org>; Thu, 11 Apr 2019 11:16:56 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
11 Apr 2019 02:16:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,336,1549958400"; d="scan'208";a="163329653"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
by fmsmga001.fm.intel.com with ESMTP; 11 Apr 2019 02:16:54 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.30]) by
IRSMSX152.ger.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0415.000;
Thu, 11 Apr 2019 10:16:54 +0100
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Dumitrescu, Cristian"
<cristian.dumitrescu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v3] meter: replace color definitions with
rte_color values
Thread-Index: AQHU67eP6gmhxA1ObkKlgqes9BmTv6Y13giAgADY32A=
Date: Thu, 11 Apr 2019 09:16:52 +0000
Message-ID:
<54CBAA185211B4429112C315DA58FF6D3373467B@IRSMSX103.ger.corp.intel.com>
References: <20190405120023.121419-1-jasvinder.singh@intel.com>
<20190405135441.40049-1-jasvinder.singh@intel.com>
<3EB4FA525960D640B5BDFFD6A3D891268E871CE0@IRSMSX108.ger.corp.intel.com>
<2927364.25GnhlBk6h@xps>
In-Reply-To: <2927364.25GnhlBk6h@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWMzNjM5YWMtOWE1Ny00MmY5LTk4ZWEtMmQ3ZWE2MWRlYWZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidGE5eWZVT2dtWkIrck83amwzOWRHYlRcL2VGcnNmd2NGSDFBRk80dDhVM2lMcWtEdXFKSnYxcm0rckVtZ0w3c1UifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.200.100
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v3] meter: replace color definitions with
rte_color values
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190411091652.njx5Hdm8ZmqjU1tntT3ZC4dVIZ727veBiLDdJyumTKw@z>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, April 10, 2019 10:20 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] meter: replace color definitions with
> rte_color values
>=20
> > > This patch implements the changes proposed in the deprecation
> > > note[1]. Replace multiple color definitions in various places such
> > > as rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined
> > > in rte_meter.h.
> > >
> > > This is simple search and replace exercise without any
> > > implementation change.
> > >
> > > [1] https://mails.dpdk.org/archives/dev/2019-January/123861.html
> > >
> > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> >
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>=20
> There is a compilation failure:
>=20
> examples/qos_sched/cfg_file.c:67:20: error:
> use of undeclared identifier 'e_RTE_METER_COLORS'
> for (k =3D 0; k < e_RTE_METER_COLORS; k++) {
>=20
Sent version 4 with fix. Thank you.=20