From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 104D829AC; Fri, 12 Apr 2019 07:21:39 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 22:21:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,340,1549958400"; d="scan'208";a="133620852" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by orsmga008.jf.intel.com with ESMTP; 11 Apr 2019 22:21:37 -0700 Date: Fri, 12 Apr 2019 13:21:09 +0800 From: Tiwei Bie To: Mohammad Abdul Awal Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com, stable@dpdk.org Message-ID: <20190412052109.GA22046@dpdk-tbie.sh.intel.com> References: <20190411144840.19942-1-mohammad.abdul.awal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190411144840.19942-1-mohammad.abdul.awal@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3] vhost: fix null pointer checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 05:21:41 -0000 On Thu, Apr 11, 2019 at 03:48:40PM +0100, Mohammad Abdul Awal wrote: > Null value for parameters will cause segfault. > > Fixes: d7280c9fff ("vhost: support selective datapath") > Fixes: 72e8543093 ("vhost: add API to get MTU value") > Fixes: a277c71598 ("vhost: refactor code structure") > Fixes: ca33faf9ef ("vhost: introduce API to fetch negotiated features") > Fixes: eb32247457 ("vhost: export guest memory regions") > Fixes: 40ef286f23 ("vhost: export vhost vring info") > Fixes: bd2e0c3fe5 ("vhost: add APIs for live migration") > Fixes: 0b8572a0c1 ("vhost: add external message handling to the API") > Fixes: b4953225ce ("vhost: add APIs for datapath configuration") > Fixes: 5fbb3941da ("vhost: introduce driver features related APIs") > Fixes: 292959c719 ("vhost: cleanup unix socket") > Cc: stable@dpdk.org > > Signed-off-by: Mohammad Abdul Awal > --- > v3: fixed per review comments > > v2: fixed per review comments > > lib/librte_vhost/socket.c | 8 +++++++- > lib/librte_vhost/vdpa.c | 5 ++++- > lib/librte_vhost/vhost.c | 16 ++++++++-------- > 3 files changed, 19 insertions(+), 10 deletions(-) Reviewed-by: Tiwei Bie From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AFF96A0096 for ; Fri, 12 Apr 2019 07:21:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E98BD3256; Fri, 12 Apr 2019 07:21:42 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 104D829AC; Fri, 12 Apr 2019 07:21:39 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 22:21:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,340,1549958400"; d="scan'208";a="133620852" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by orsmga008.jf.intel.com with ESMTP; 11 Apr 2019 22:21:37 -0700 Date: Fri, 12 Apr 2019 13:21:09 +0800 From: Tiwei Bie To: Mohammad Abdul Awal Cc: dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com, stable@dpdk.org Message-ID: <20190412052109.GA22046@dpdk-tbie.sh.intel.com> References: <20190411144840.19942-1-mohammad.abdul.awal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190411144840.19942-1-mohammad.abdul.awal@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3] vhost: fix null pointer checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412052109.WwJiG411J2tS8gTOKzqIftQ0Cu9zMTKUbZbi585GbdM@z> On Thu, Apr 11, 2019 at 03:48:40PM +0100, Mohammad Abdul Awal wrote: > Null value for parameters will cause segfault. > > Fixes: d7280c9fff ("vhost: support selective datapath") > Fixes: 72e8543093 ("vhost: add API to get MTU value") > Fixes: a277c71598 ("vhost: refactor code structure") > Fixes: ca33faf9ef ("vhost: introduce API to fetch negotiated features") > Fixes: eb32247457 ("vhost: export guest memory regions") > Fixes: 40ef286f23 ("vhost: export vhost vring info") > Fixes: bd2e0c3fe5 ("vhost: add APIs for live migration") > Fixes: 0b8572a0c1 ("vhost: add external message handling to the API") > Fixes: b4953225ce ("vhost: add APIs for datapath configuration") > Fixes: 5fbb3941da ("vhost: introduce driver features related APIs") > Fixes: 292959c719 ("vhost: cleanup unix socket") > Cc: stable@dpdk.org > > Signed-off-by: Mohammad Abdul Awal > --- > v3: fixed per review comments > > v2: fixed per review comments > > lib/librte_vhost/socket.c | 8 +++++++- > lib/librte_vhost/vdpa.c | 5 ++++- > lib/librte_vhost/vhost.c | 16 ++++++++-------- > 3 files changed, 19 insertions(+), 10 deletions(-) Reviewed-by: Tiwei Bie