From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 33D4D1B2B3 for <dev@dpdk.org>; Sat, 13 Apr 2019 00:06:54 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id z9so5803759pgu.10 for <dev@dpdk.org>; Fri, 12 Apr 2019 15:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ftSVIBqJL6BvKqbaCzaHtE9y3TZ6fmLJeAnkizpe/to=; b=i+WxOThp+ye5tYYYBhEzP1pEsWGlh2lFt3SXnIVpKkXRARtCD+RSCw5SiC0IeG0MmL /rUaEQ55mBw5L6+KTAF+dBmqB7eWQ3tRk9tp9IHby4Liq9O4Yl7Qu18Zf9EKQrqVJzk9 DnWf09HAN9NdIBtY0yoNU+nzQO7FU0Pa3njB9G1Cf66wctTbkwHHQ++jzvBCKnouZTCc K2YJd4wqyV1R6iuJ1TvL4jznqItR4/1nT4gvL42/H4mZ8dvCTOzxnPBw/5RFRoARqy0Z gGsP9o6mjWPq6QUkfXE+nfZxnnU5Z+KtWMUCQ80wHcW65PLYOYPJhIhpSpJ7V+pPY3PE 8wEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ftSVIBqJL6BvKqbaCzaHtE9y3TZ6fmLJeAnkizpe/to=; b=kzvyFgJqcQxMHVBF7qRGFA8OmuN/SyMyVAtiBMitJIqNhmjpnqqp+nxM46o9BJfCsG 7f+hth7AjPtXnVgQcBsqxtioLSH7I9yY5C1EkyVfxrCb9FEVZ0BZ8jr0UeNxLIfP5Z+p 9vD5gKjERyMqLSASqvh1J1bedWygM3SeeYiHsGULAo+DJIm/nvybhuT53b/GSIPgUwGo ayjmzDTgtm7KfPebBkUW6Drhz8nihWdvSxV92eCbQnpKsmNh/ogP3tk9syXddz1TR+iZ NpG98S32FtlLf8onhdu74NjUACJBzVKSY6PlEhU1IVmXHCCyRMoicrvR03Y4+3JECR5Y 3S4g== X-Gm-Message-State: APjAAAU1giPNlUdjp+BFjGcdqrGtR/0ZIg+s8wYPneWuWdc4IQa7r6as RaqzNcJltv2a11hqBQP9926fiQ== X-Google-Smtp-Source: APXvYqz2pfiaYnxkUgKXYEdS0Aapg0Qp9rew4REtq1qAoJ3/TOU04fQE7uJpw+q9DXHK+PKkGK+N7Q== X-Received: by 2002:a63:c61:: with SMTP id 33mr51507189pgm.293.1555106813156; Fri, 12 Apr 2019 15:06:53 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m7sm58404736pgg.62.2019.04.12.15.06.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 15:06:53 -0700 (PDT) Date: Fri, 12 Apr 2019 15:06:50 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Cc: konstantin.ananyev@intel.com, paulmck@linux.ibm.com, marko.kovacevic@intel.com, dev@dpdk.org, gavin.hu@arm.com, dharmik.thakkar@arm.com, malvika.gupta@arm.com Message-ID: <20190412150650.3709358e@shemminger-XPS-13-9360> In-Reply-To: <20190412202039.46902-2-honnappa.nagarahalli@arm.com> References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-2-honnappa.nagarahalli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 12 Apr 2019 22:06:54 -0000 On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote: > Add RCU library supporting quiescent state based memory reclamation method. > This library helps identify the quiescent state of the reader threads so > that the writers can free the memory associated with the lock less data > structures. > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > Reviewed-by: Steve Capper <steve.capper@arm.com> > Reviewed-by: Gavin Hu <gavin.hu@arm.com> > Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> After evaluating long term API/ABI issues, I think you need to get rid of almost all use of inline and visible structures. Yes it might be marginally slower, but you thank me the first time you have to fix something. Even the log macro should be private. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CFCB1A0096 for <public@inbox.dpdk.org>; Sat, 13 Apr 2019 00:06:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 04F521B3A5; Sat, 13 Apr 2019 00:06:55 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 33D4D1B2B3 for <dev@dpdk.org>; Sat, 13 Apr 2019 00:06:54 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id z9so5803759pgu.10 for <dev@dpdk.org>; Fri, 12 Apr 2019 15:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ftSVIBqJL6BvKqbaCzaHtE9y3TZ6fmLJeAnkizpe/to=; b=i+WxOThp+ye5tYYYBhEzP1pEsWGlh2lFt3SXnIVpKkXRARtCD+RSCw5SiC0IeG0MmL /rUaEQ55mBw5L6+KTAF+dBmqB7eWQ3tRk9tp9IHby4Liq9O4Yl7Qu18Zf9EKQrqVJzk9 DnWf09HAN9NdIBtY0yoNU+nzQO7FU0Pa3njB9G1Cf66wctTbkwHHQ++jzvBCKnouZTCc K2YJd4wqyV1R6iuJ1TvL4jznqItR4/1nT4gvL42/H4mZ8dvCTOzxnPBw/5RFRoARqy0Z gGsP9o6mjWPq6QUkfXE+nfZxnnU5Z+KtWMUCQ80wHcW65PLYOYPJhIhpSpJ7V+pPY3PE 8wEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ftSVIBqJL6BvKqbaCzaHtE9y3TZ6fmLJeAnkizpe/to=; b=kzvyFgJqcQxMHVBF7qRGFA8OmuN/SyMyVAtiBMitJIqNhmjpnqqp+nxM46o9BJfCsG 7f+hth7AjPtXnVgQcBsqxtioLSH7I9yY5C1EkyVfxrCb9FEVZ0BZ8jr0UeNxLIfP5Z+p 9vD5gKjERyMqLSASqvh1J1bedWygM3SeeYiHsGULAo+DJIm/nvybhuT53b/GSIPgUwGo ayjmzDTgtm7KfPebBkUW6Drhz8nihWdvSxV92eCbQnpKsmNh/ogP3tk9syXddz1TR+iZ NpG98S32FtlLf8onhdu74NjUACJBzVKSY6PlEhU1IVmXHCCyRMoicrvR03Y4+3JECR5Y 3S4g== X-Gm-Message-State: APjAAAU1giPNlUdjp+BFjGcdqrGtR/0ZIg+s8wYPneWuWdc4IQa7r6as RaqzNcJltv2a11hqBQP9926fiQ== X-Google-Smtp-Source: APXvYqz2pfiaYnxkUgKXYEdS0Aapg0Qp9rew4REtq1qAoJ3/TOU04fQE7uJpw+q9DXHK+PKkGK+N7Q== X-Received: by 2002:a63:c61:: with SMTP id 33mr51507189pgm.293.1555106813156; Fri, 12 Apr 2019 15:06:53 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m7sm58404736pgg.62.2019.04.12.15.06.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 15:06:53 -0700 (PDT) Date: Fri, 12 Apr 2019 15:06:50 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Cc: konstantin.ananyev@intel.com, paulmck@linux.ibm.com, marko.kovacevic@intel.com, dev@dpdk.org, gavin.hu@arm.com, dharmik.thakkar@arm.com, malvika.gupta@arm.com Message-ID: <20190412150650.3709358e@shemminger-XPS-13-9360> In-Reply-To: <20190412202039.46902-2-honnappa.nagarahalli@arm.com> References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-2-honnappa.nagarahalli@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190412220650.0QTPCkc3o1t_eSGQSuOQcWRTeXA4vGYZ8Rf9BJNwU90@z> On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote: > Add RCU library supporting quiescent state based memory reclamation method. > This library helps identify the quiescent state of the reader threads so > that the writers can free the memory associated with the lock less data > structures. > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > Reviewed-by: Steve Capper <steve.capper@arm.com> > Reviewed-by: Gavin Hu <gavin.hu@arm.com> > Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> After evaluating long term API/ABI issues, I think you need to get rid of almost all use of inline and visible structures. Yes it might be marginally slower, but you thank me the first time you have to fix something. Even the log macro should be private.