From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 1A7941B3AC for ; Sat, 13 Apr 2019 00:08:37 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id y13so5754715pfm.11 for ; Fri, 12 Apr 2019 15:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m60TVmwpuyrux+OiJhSpTVhu6eWHGuxZeClEKOclqzk=; b=IIBDnMEaEGJ+Ub5ZCUE+SV1qu9TulHFh3Ww9GJQv41v0bIySGZ1Z5P9IpRxLS/u7uX IfHK+Efilc8A8/Sz4Hohr3k3IWlGM47p695+ckKKO1fUxNJ6J9DJhZXOqFTZKJrIeiTr /h3GRNOTr6fM+ghHNdXCmgARK3CLoIIeHmLTXFqTvLn7dHHVWRkl+dIt1GcvqVeai8bd RiPrKvniq2lHqBzfFF2ZHmzgQsYRh2pg6w60VQQUQkp//1Z1Ee757JvnTbgeJq50LfIx mt+w7VXMG6322Gh1DwQYoFzamvw2l8b0sOGeKGr10bFcTQt6z/jjgmHFXwcalPVMAh/I hG1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m60TVmwpuyrux+OiJhSpTVhu6eWHGuxZeClEKOclqzk=; b=UmHPqdm8digiyYGw870blf77B4puZWoUgadG29uo1k1deJQfG5xCAmUC1cRsCoKziw Zq/i7EGvnnS3fCXmJVVXbdLsjFkM6r1T5TurQpimjf4mcgtf7WsXRl6/98zDqYDXMajs V5bPRMwOVyTCI0eNrDTmN8cg16d3OevVqnbXrNrBAHJa6ZhsUQq7STeeU8JJpcmalWqk 1RDG6UYP1Fbt6nuV1kOA4QG178Z/PjIlsy6Aro1bdnCcEXNvEfEbXSedLuDzf6j5+4wN CBaAw0dX+EB+83SibWM6oMeemdJW0THcWfwyFvN9kF2Nho/r0vOi3M89DM2mhH/e48Zq g6TQ== X-Gm-Message-State: APjAAAW9pt9zytdn+qNFRaxs+mWfvYdBkPOe4fa161NbgMb5O2gvHKv8 jogF/Xj+OV35jn3z3d2mqSdkyw== X-Google-Smtp-Source: APXvYqwP01JQIwa80yc623Mj/8jINZURzPfCdRPVYEfe1g97b64YK52NGyac2VGaHeZgswrsHdiP6Q== X-Received: by 2002:a62:1197:: with SMTP id 23mr60325772pfr.210.1555106916450; Fri, 12 Apr 2019 15:08:36 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l19sm10748127pfi.87.2019.04.12.15.08.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 15:08:36 -0700 (PDT) Date: Fri, 12 Apr 2019 15:08:33 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Chas Williams , "John W. Linville" Message-ID: <20190412150833.63c41806@shemminger-XPS-13-9360> In-Reply-To: <7e03b000-f4d4-71c3-5978-8a8623d7ace5@intel.com> References: <20190408160419.7409-1-stephen@networkplumber.org> <20190408164112.12471-1-stephen@networkplumber.org> <7e03b000-f4d4-71c3-5978-8a8623d7ace5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 22:08:38 -0000 On Fri, 12 Apr 2019 17:28:17 +0100 Ferruh Yigit wrote: > On 4/8/2019 5:41 PM, Stephen Hemminger wrote: > > If the af_packet transmit is sending a VLAN packet, > > and the transmit path to the kernel os full, then it would > > mismanage the outgoing mbuf. The original mbuf would end up > > being freed twice, once by AF_PACKET PMD and once by caller. > > This comment is valid with your new patch [1] that updates 'rte_vlan_insert()' > to duplicate the mbuf, right? > > That patch looks like won't make the release, so I suggest this one wait that > patch, although this is harmless on its own, commit log is misleading. > > [1] > https://patches.dpdk.org/patch/51870/ It was always true, even with existing vlan_insert. Existing vlan_insert has issues if it ever creates a clone packet. Existing vlan_insert can duplicate mbuf through clone From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A1045A0096 for ; Sat, 13 Apr 2019 00:08:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34D661B3AD; Sat, 13 Apr 2019 00:08:39 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 1A7941B3AC for ; Sat, 13 Apr 2019 00:08:37 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id y13so5754715pfm.11 for ; Fri, 12 Apr 2019 15:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m60TVmwpuyrux+OiJhSpTVhu6eWHGuxZeClEKOclqzk=; b=IIBDnMEaEGJ+Ub5ZCUE+SV1qu9TulHFh3Ww9GJQv41v0bIySGZ1Z5P9IpRxLS/u7uX IfHK+Efilc8A8/Sz4Hohr3k3IWlGM47p695+ckKKO1fUxNJ6J9DJhZXOqFTZKJrIeiTr /h3GRNOTr6fM+ghHNdXCmgARK3CLoIIeHmLTXFqTvLn7dHHVWRkl+dIt1GcvqVeai8bd RiPrKvniq2lHqBzfFF2ZHmzgQsYRh2pg6w60VQQUQkp//1Z1Ee757JvnTbgeJq50LfIx mt+w7VXMG6322Gh1DwQYoFzamvw2l8b0sOGeKGr10bFcTQt6z/jjgmHFXwcalPVMAh/I hG1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m60TVmwpuyrux+OiJhSpTVhu6eWHGuxZeClEKOclqzk=; b=UmHPqdm8digiyYGw870blf77B4puZWoUgadG29uo1k1deJQfG5xCAmUC1cRsCoKziw Zq/i7EGvnnS3fCXmJVVXbdLsjFkM6r1T5TurQpimjf4mcgtf7WsXRl6/98zDqYDXMajs V5bPRMwOVyTCI0eNrDTmN8cg16d3OevVqnbXrNrBAHJa6ZhsUQq7STeeU8JJpcmalWqk 1RDG6UYP1Fbt6nuV1kOA4QG178Z/PjIlsy6Aro1bdnCcEXNvEfEbXSedLuDzf6j5+4wN CBaAw0dX+EB+83SibWM6oMeemdJW0THcWfwyFvN9kF2Nho/r0vOi3M89DM2mhH/e48Zq g6TQ== X-Gm-Message-State: APjAAAW9pt9zytdn+qNFRaxs+mWfvYdBkPOe4fa161NbgMb5O2gvHKv8 jogF/Xj+OV35jn3z3d2mqSdkyw== X-Google-Smtp-Source: APXvYqwP01JQIwa80yc623Mj/8jINZURzPfCdRPVYEfe1g97b64YK52NGyac2VGaHeZgswrsHdiP6Q== X-Received: by 2002:a62:1197:: with SMTP id 23mr60325772pfr.210.1555106916450; Fri, 12 Apr 2019 15:08:36 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l19sm10748127pfi.87.2019.04.12.15.08.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 15:08:36 -0700 (PDT) Date: Fri, 12 Apr 2019 15:08:33 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Chas Williams , "John W. Linville" Message-ID: <20190412150833.63c41806@shemminger-XPS-13-9360> In-Reply-To: <7e03b000-f4d4-71c3-5978-8a8623d7ace5@intel.com> References: <20190408160419.7409-1-stephen@networkplumber.org> <20190408164112.12471-1-stephen@networkplumber.org> <7e03b000-f4d4-71c3-5978-8a8623d7ace5@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190412220833.hLNC05L4GPh2N9Lilaijl95_xnZpZm-ZwVvDx2ZZwu8@z> On Fri, 12 Apr 2019 17:28:17 +0100 Ferruh Yigit wrote: > On 4/8/2019 5:41 PM, Stephen Hemminger wrote: > > If the af_packet transmit is sending a VLAN packet, > > and the transmit path to the kernel os full, then it would > > mismanage the outgoing mbuf. The original mbuf would end up > > being freed twice, once by AF_PACKET PMD and once by caller. > > This comment is valid with your new patch [1] that updates 'rte_vlan_insert()' > to duplicate the mbuf, right? > > That patch looks like won't make the release, so I suggest this one wait that > patch, although this is harmless on its own, commit log is misleading. > > [1] > https://patches.dpdk.org/patch/51870/ It was always true, even with existing vlan_insert. Existing vlan_insert has issues if it ever creates a clone packet. Existing vlan_insert can duplicate mbuf through clone