From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6ADCBA0096 for <public@inbox.dpdk.org>; Sat, 13 Apr 2019 01:06:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8AD51B3B5; Sat, 13 Apr 2019 01:06:34 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id D806B1B3AD for <dev@dpdk.org>; Sat, 13 Apr 2019 01:06:32 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id w24so5807462plp.2 for <dev@dpdk.org>; Fri, 12 Apr 2019 16:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hjUAPH75tkftBiza5Or9HamwaLNEm/6sh8rXsfWkJAE=; b=wGC1wxI9FnqDM5Th3akwmg3viTCIGdYWeCzyo2ODRmOd38WcocXISRKXPPrXGrq5CG 6knnuF237NgD3KQoMnUjLz/a2/Ulh+M3VFc304jD6dj5jctJCqq6CZBXIynejqCL4aK1 Bqf0wRCu+3sVZICLuCT7g9C6nc5LgH3BGjxCAgk6IFTyOSxWccudD8qDNQoijhO0UvYb geN1hY++PAioPfpg/xuQYOtrJFSI8fbS01xeEbjIJmcwj5QRil4lFRDtPqLNsfAqlK0J 0Z659m186DZ4lc+GuWzEJOuMG5fBaxOT5X9VcbK1T4jZSB3WhgecDJdvzpy9bH+T3W0H HmhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hjUAPH75tkftBiza5Or9HamwaLNEm/6sh8rXsfWkJAE=; b=Wmk4cdJ0mTuRlB3XFzpI6pA49vwG1S/UdAolrIniZFQJlqyycEHHNx6AOoDHpcOeGk jlfoaCBtIjVRE4ac0xtGpDEP71bSAbhq1YblZQAE/XkzroRhdSHD66wMg8t574/KPzoc wHFygiNYiXhDOaHSlI7pn0D7wPHvSiiuGrxQr3ZHMUJoS8XRagJ+Oj0UhlIaU7FOrsb/ LVYfaV0MR2AbtGMUP2BzXvApBgAMQeTld0Z5CCcw+5QRERdM1akwQigzfVv67GwCxdRq y4pMubj6nGej9xdtKu0Zr6+zZf9+Mt0Z8yHI47JUWvYlaPX9BLef/uQbF5FBLU0mO8Mq wvcA== X-Gm-Message-State: APjAAAWaqjzG8Qrvg5sKLbXbLQceR4kExnuqKzikyI1yjkwBwibIDAGR idxcxHbM/w4Xl0f8Fy99XoFuTg== X-Google-Smtp-Source: APXvYqw/1juqa+QQYXr0vHThl2PBcP0mneSfmclLmlabEMg9GW2DYoBnHPo03kR96akfqSKLB5ZDpw== X-Received: by 2002:a17:902:9a95:: with SMTP id w21mr57742265plp.74.1555110391779; Fri, 12 Apr 2019 16:06:31 -0700 (PDT) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 10sm54007979pft.100.2019.04.12.16.06.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Apr 2019 16:06:31 -0700 (PDT) Date: Fri, 12 Apr 2019 16:06:29 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> Cc: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>, "paulmck@linux.ibm.com" <paulmck@linux.ibm.com>, "marko.kovacevic@intel.com" <marko.kovacevic@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>, Malvika Gupta <Malvika.Gupta@arm.com>, nd <nd@arm.com> Message-ID: <20190412160629.670eacd1@shemminger-XPS-13-9360> In-Reply-To: <VE1PR08MB51497C4B9E164CD07AC6EB5298280@VE1PR08MB5149.eurprd08.prod.outlook.com> References: <20181122033055.3431-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-1-honnappa.nagarahalli@arm.com> <20190412202039.46902-2-honnappa.nagarahalli@arm.com> <20190412150650.3709358e@shemminger-XPS-13-9360> <VE1PR08MB51497C4B9E164CD07AC6EB5298280@VE1PR08MB5149.eurprd08.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190412230629.VCb0x1qL_myaZ_U4EO5knUq4TiCkSovsdGLHG3c7dCw@z> On Fri, 12 Apr 2019 22:24:45 +0000 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote: > > > > On Fri, 12 Apr 2019 15:20:37 -0500 > > Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote: > > > > > Add RCU library supporting quiescent state based memory reclamation > > method. > > > This library helps identify the quiescent state of the reader threads > > > so that the writers can free the memory associated with the lock less > > > data structures. > > > > > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> > > > Reviewed-by: Steve Capper <steve.capper@arm.com> > > > Reviewed-by: Gavin Hu <gavin.hu@arm.com> > > > Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com> > > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > > > > After evaluating long term API/ABI issues, I think you need to get rid of almost > > all use of inline and visible structures. Yes it might be marginally slower, but > > you thank me the first time you have to fix something. > > > Agree, I was planning on another version to address this (I am yet to take a look at your patch addressing the ABI). > The structure visibility definitely needs to be addressed. > For the inline functions, is the plan to convert all the inline functions in DPDK? If yes, I think we need to consider the performance difference. May be consider L3-fwd application, change all the inline functions in its path and run a test? Every function that is not in the direct datapath should not be inline. Exceptions or things like rx/tx burst, ring enqueue/dequeue, and packet alloc/free