From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5275EA00E6 for ; Mon, 15 Apr 2019 17:51:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28B0F1B2AD; Mon, 15 Apr 2019 17:51:23 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5C78B1B296 for ; Mon, 15 Apr 2019 17:51:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 08:50:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,354,1549958400"; d="scan'208";a="135988818" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.210.157]) ([10.237.210.157]) by orsmga006.jf.intel.com with ESMTP; 15 Apr 2019 08:50:41 -0700 To: Lukasz Gosiewski Cc: dev@dpdk.org, lukaszx.krakowiak@intel.com References: <20190403115251.10768-1-lukaszx.krakowiak@intel.com> <20190415100109.6240-1-lukaszx.gosiewski@intel.com> From: "Hunt, David" Message-ID: Date: Mon, 15 Apr 2019 16:50:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190415100109.6240-1-lukaszx.gosiewski@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3] power: update for handling fifo path string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190415155040.TOLN1ZczL0bkIV4YZuVT_8JakSIr5Isx5pgW3ClYfrE@z> Hi Lukasz, On 15/4/2019 11:01 AM, Lukasz Gosiewski wrote: > From: Lukasz Krakowiak > > Removed doubled created fifo path string for channel info. > > --- > v3: > *improvement to coding style > > v2: > * rebase to master changes > > Signed-off-by: Lukasz Krakowiak > Signed-off-by: Lukasz Gosiewski > --- > examples/vm_power_manager/channel_manager.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c > index 0187f79ab..05c0eea44 100644 > --- a/examples/vm_power_manager/channel_manager.c > +++ b/examples/vm_power_manager/channel_manager.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > > #include > > @@ -362,8 +363,6 @@ setup_host_channel_info(struct channel_info **chan_info_dptr, > chan_info->status = CHANNEL_MGR_CHANNEL_DISCONNECTED; > chan_info->type = CHANNEL_TYPE_JSON; > > - fifo_path(chan_info->channel_path, sizeof(chan_info->channel_path)); > - > if (open_host_channel(chan_info) < 0) { > RTE_LOG(ERR, CHANNEL_MANAGER, "Could not open host channel: " > "'%s'\n", > @@ -563,8 +562,8 @@ add_host_channel(void) > "channel '%s'\n", socket_path); > return 0; > } > - strlcpy(chan_info->channel_path, socket_path, > - sizeof(chan_info->channel_path)); > + rte_strlcpy(chan_info->channel_path, socket_path, UNIX_PATH_MAX); > + > if (setup_host_channel_info(&chan_info, 0) < 0) { > rte_free(chan_info); > return 0; I'm not seeing this patch in patchwork, I'm seeing the original v1 from Lukasz K. Can you try re-sending to mailing list? If it's not in patchwork, it won't get applied. Rgds, Dave.