From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 405C61B45D; Tue, 16 Apr 2019 07:20:29 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 22:20:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,355,1549958400"; d="scan'208";a="337861185" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by fmsmga006.fm.intel.com with ESMTP; 15 Apr 2019 22:20:25 -0700 Date: Tue, 16 Apr 2019 13:19:57 +0800 From: Tiwei Bie To: Aaron Conole Cc: dev@dpdk.org, stable@dpdk.org, Maxime Coquelin , Zhihong Wang , Pengzhen Liu Message-ID: <20190416051957.GA7907@dpdk-tbie.sh.intel.com> References: <20190415144818.26600-1-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190415144818.26600-1-aconole@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix dangling pointer on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 05:20:29 -0000 On Mon, Apr 15, 2019 at 10:48:18AM -0400, Aaron Conole wrote: > When eth_virtio_dev_init() is cleaning up, it does not correctly set > the mac_addrs variable to NULL, which will lead to a double free. > > Found during unit-test fixes. > > Fixes: 43d18765c027 ("net/virtio: fix memory leak on failure") > Cc: stable@dpdk.org > Reported-by: Michael Santana > Signed-off-by: Aaron Conole > --- > drivers/net/virtio/virtio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Tiwei Bie From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 67A85A00E6 for ; Tue, 16 Apr 2019 07:20:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB9421B45E; Tue, 16 Apr 2019 07:20:31 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 405C61B45D; Tue, 16 Apr 2019 07:20:29 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Apr 2019 22:20:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,355,1549958400"; d="scan'208";a="337861185" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by fmsmga006.fm.intel.com with ESMTP; 15 Apr 2019 22:20:25 -0700 Date: Tue, 16 Apr 2019 13:19:57 +0800 From: Tiwei Bie To: Aaron Conole Cc: dev@dpdk.org, stable@dpdk.org, Maxime Coquelin , Zhihong Wang , Pengzhen Liu Message-ID: <20190416051957.GA7907@dpdk-tbie.sh.intel.com> References: <20190415144818.26600-1-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190415144818.26600-1-aconole@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix dangling pointer on failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416051957.o_XLEiX8ZzGm3bEsBhT4N7HeXdG7D1vDw4PmvkSo0iw@z> On Mon, Apr 15, 2019 at 10:48:18AM -0400, Aaron Conole wrote: > When eth_virtio_dev_init() is cleaning up, it does not correctly set > the mac_addrs variable to NULL, which will lead to a double free. > > Found during unit-test fixes. > > Fixes: 43d18765c027 ("net/virtio: fix memory leak on failure") > Cc: stable@dpdk.org > Reported-by: Michael Santana > Signed-off-by: Aaron Conole > --- > drivers/net/virtio/virtio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Tiwei Bie