From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
Ayuj Verma <ayverma@marvell.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Cc: "shallyv@marvell.com" <shallyv@marvell.com>,
"ssahu@marvell.com" <ssahu@marvell.com>,
"kkotamarthy@marvell.com" <kkotamarthy@marvell.com>,
"adesai@marvell.com" <adesai@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers
Date: Tue, 16 Apr 2019 07:40:03 +0000 [thread overview]
Message-ID: <VI1PR04MB4893462002C246FAD6A48FCEE6240@VI1PR04MB4893.eurprd04.prod.outlook.com> (raw)
Message-ID: <20190416074003.nluzk2mNw8T3ZUsP9iJAUxmOl7MYg5YlxJFTmuBikq0@z> (raw)
Hi Ayuj,
> > rte_crypto_sym.h is included prior to rte_crypto_asym.h
> > in rte_crypto.h, which breaks alphabetical order.
> >
> > include rte_crypto_sym.h in rte_crypto_asym.h fixes this.
> [Fiona] I presume you tried just swapping the order and it broke?
> If something in rte_crypto_asym.h depends on something from
> rte_crypto_sym.h, it
> probably shouldn't. What's the dependency and can/should it be moved to
> rte_crypto.h?
Could you please reply to Fiona's comment?
Thanks,
Akhil
next reply other threads:[~2019-04-16 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 7:40 Akhil Goyal [this message]
2019-04-16 7:40 ` Akhil Goyal
-- strict thread matches above, loose matches on Subject: below --
2019-04-17 9:57 Akhil Goyal
2019-04-17 9:57 ` Akhil Goyal
2019-04-17 11:24 ` Trahe, Fiona
2019-04-17 11:24 ` Trahe, Fiona
2019-04-12 7:03 Ayuj Verma
2019-04-12 7:03 ` Ayuj Verma
2019-04-12 15:17 ` Trahe, Fiona
2019-04-12 15:17 ` Trahe, Fiona
2019-04-16 16:15 ` Ayuj Verma
2019-04-16 16:15 ` Ayuj Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB4893462002C246FAD6A48FCEE6240@VI1PR04MB4893.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=adesai@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=ayverma@marvell.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=kkotamarthy@marvell.com \
--cc=shallyv@marvell.com \
--cc=ssahu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).