DPDK patches and discussions
 help / color / mirror / Atom feed
* Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers
@ 2019-04-16  7:40 Akhil Goyal
  2019-04-16  7:40 ` Akhil Goyal
  0 siblings, 1 reply; 12+ messages in thread
From: Akhil Goyal @ 2019-04-16  7:40 UTC (permalink / raw)
  To: Trahe, Fiona, Ayuj Verma, Kusztal, ArkadiuszX
  Cc: shallyv, ssahu, kkotamarthy, adesai, dev

Hi Ayuj,

> > rte_crypto_sym.h is included prior to rte_crypto_asym.h
> > in rte_crypto.h, which breaks alphabetical order.
> >
> > include rte_crypto_sym.h in rte_crypto_asym.h fixes this.
> [Fiona] I presume you tried just swapping the order and it broke?
> If something in rte_crypto_asym.h depends on something from
> rte_crypto_sym.h, it
> probably shouldn't. What's the dependency and can/should it be moved to
> rte_crypto.h?

Could you please reply to Fiona's comment?

Thanks,
Akhil

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers
@ 2019-04-17  9:57 Akhil Goyal
  2019-04-17  9:57 ` Akhil Goyal
  2019-04-17 11:24 ` Trahe, Fiona
  0 siblings, 2 replies; 12+ messages in thread
From: Akhil Goyal @ 2019-04-17  9:57 UTC (permalink / raw)
  To: Ayuj Verma, Trahe, Fiona, Kusztal, ArkadiuszX
  Cc: Shally Verma, Sunila Sahu, Kanaka Durga Kotamarthy, Arvind Desai, dev


Hi Ayuj,

> -----Original Message-----
> From: Ayuj Verma [mailto:ayverma@marvell.com]
> Sent: Friday, April 12, 2019 8:03 AM
> To: akhil.goyal@nxp.com<mailto:akhil.goyal@nxp.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com<mailto:arkadiuszx.kusztal@intel.com>>; Trahe, Fiona
> <fiona.trahe@intel.com<mailto:fiona.trahe@intel.com>>
> Cc: shallyv@marvell.com<mailto:shallyv@marvell.com>; ssahu@marvell.com<mailto:ssahu@marvell.com>; kkotamarthy@marvell.com<mailto:kkotamarthy@marvell.com>; adesai@marvell.com<mailto:adesai@marvell.com>;
> dev@dpdk.org<mailto:dev@dpdk.org>; Ayuj Verma <ayverma@marvell.com<mailto:ayverma@marvell.com>>
> Subject: [PATCH v1] fix alphabetical ordering of headers
>
> rte_crypto_sym.h is included prior to rte_crypto_asym.h
> in rte_crypto.h, which breaks alphabetical order.
>
> include rte_crypto_sym.h in rte_crypto_asym.h fixes this.
[Fiona] I presume you tried just swapping the order and it broke?
If something in rte_crypto_asym.h depends on something from rte_crypto_sym.h, it
probably shouldn't. What's the dependency and can/should it be moved to rte_crypto.h?
[Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So do you suggest to move it to rte_crypto.h?

[Akhil] moving the enum is not a good idea. I believe we do not need this change at all. Keeping the headers in alphabetical order may be a preferred way,
But it should not be mandatory, there may be some dependencies like this.

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers
@ 2019-04-12  7:03 Ayuj Verma
  2019-04-12  7:03 ` Ayuj Verma
  2019-04-12 15:17 ` Trahe, Fiona
  0 siblings, 2 replies; 12+ messages in thread
From: Ayuj Verma @ 2019-04-12  7:03 UTC (permalink / raw)
  To: akhil.goyal, arkadiuszx.kusztal, fiona.trahe
  Cc: shallyv, ssahu, kkotamarthy, adesai, dev, Ayuj Verma

rte_crypto_sym.h is included prior to rte_crypto_asym.h
in rte_crypto.h, which breaks alphabetical order.

include rte_crypto_sym.h in rte_crypto_asym.h fixes this.

Ayuj Verma (1):
  lib/crypto: fix alphabetical ordering of headers

 lib/librte_cryptodev/rte_crypto.h      | 1 -
 lib/librte_cryptodev/rte_crypto_asym.h | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-04-17 11:24 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-16  7:40 [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers Akhil Goyal
2019-04-16  7:40 ` Akhil Goyal
  -- strict thread matches above, loose matches on Subject: below --
2019-04-17  9:57 Akhil Goyal
2019-04-17  9:57 ` Akhil Goyal
2019-04-17 11:24 ` Trahe, Fiona
2019-04-17 11:24   ` Trahe, Fiona
2019-04-12  7:03 Ayuj Verma
2019-04-12  7:03 ` Ayuj Verma
2019-04-12 15:17 ` Trahe, Fiona
2019-04-12 15:17   ` Trahe, Fiona
2019-04-16 16:15   ` Ayuj Verma
2019-04-16 16:15     ` Ayuj Verma

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).