From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8081B1B4CD; Tue, 16 Apr 2019 16:37:20 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 07:37:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,358,1549958400"; d="scan'208";a="224018098" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.220.103]) by orsmga001.jf.intel.com with SMTP; 16 Apr 2019 07:37:16 -0700 Received: by (sSMTP sendmail emulation); Tue, 16 Apr 2019 15:37:16 +0100 Date: Tue, 16 Apr 2019 15:37:15 +0100 From: Bruce Richardson To: Kevin Traynor Cc: dev@dpdk.org, Ferruh Yigit , Reshma Pattan , "stable@dpdk.org" Message-ID: <20190416143715.GA1870@bricha3-MOBL.ger.corp.intel.com> References: <20190116124836.40132-1-bruce.richardson@intel.com> <20190117173032.42076-1-bruce.richardson@intel.com> <0170cda4-fe5b-a8f1-d3b5-64d6504ea43a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0170cda4-fe5b-a8f1-d3b5-64d6504ea43a@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v3] eal: support strlcat function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 14:37:21 -0000 On Tue, Apr 16, 2019 at 03:29:52PM +0100, Kevin Traynor wrote: > On 17/01/2019 17:30, Bruce Richardson wrote: > > Add the strlcat function to DPDK to exist alongside the strlcpy one. > > While strncat is generally safe for use for concatenation, the API for the > > strlcat function is perhaps a little nicer to use, and supports truncation > > detection. > > > > See commit 5364de644a4b ("eal: support strlcpy function") for more > > details on the function selection logic, since we only should be using the > > DPDK-provided version when no system-provided version is present. > > > > Signed-off-by: Bruce Richardson > > Reviewed-by: Ferruh Yigit > > Hi - I'd like to backport this to 18.11 stable branch. Not having it is > starting to cause build failures with backports. Let me know if any > objection. > Go for it! No objections here, I think it makes sense. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 439BBA00E6 for ; Tue, 16 Apr 2019 16:37:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FE811B4D0; Tue, 16 Apr 2019 16:37:22 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8081B1B4CD; Tue, 16 Apr 2019 16:37:20 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 07:37:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,358,1549958400"; d="scan'208";a="224018098" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.220.103]) by orsmga001.jf.intel.com with SMTP; 16 Apr 2019 07:37:16 -0700 Received: by (sSMTP sendmail emulation); Tue, 16 Apr 2019 15:37:16 +0100 Date: Tue, 16 Apr 2019 15:37:15 +0100 From: Bruce Richardson To: Kevin Traynor Cc: dev@dpdk.org, Ferruh Yigit , Reshma Pattan , "stable@dpdk.org" Message-ID: <20190416143715.GA1870@bricha3-MOBL.ger.corp.intel.com> References: <20190116124836.40132-1-bruce.richardson@intel.com> <20190117173032.42076-1-bruce.richardson@intel.com> <0170cda4-fe5b-a8f1-d3b5-64d6504ea43a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <0170cda4-fe5b-a8f1-d3b5-64d6504ea43a@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v3] eal: support strlcat function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416143715.xjxNm_12fzwY0aKmlG0tJVmPWAlq2E_L2JF3uCz94nY@z> On Tue, Apr 16, 2019 at 03:29:52PM +0100, Kevin Traynor wrote: > On 17/01/2019 17:30, Bruce Richardson wrote: > > Add the strlcat function to DPDK to exist alongside the strlcpy one. > > While strncat is generally safe for use for concatenation, the API for the > > strlcat function is perhaps a little nicer to use, and supports truncation > > detection. > > > > See commit 5364de644a4b ("eal: support strlcpy function") for more > > details on the function selection logic, since we only should be using the > > DPDK-provided version when no system-provided version is present. > > > > Signed-off-by: Bruce Richardson > > Reviewed-by: Ferruh Yigit > > Hi - I'd like to backport this to 18.11 stable branch. Not having it is > starting to cause build failures with backports. Let me know if any > objection. > Go for it! No objections here, I think it makes sense. /Bruce