From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3205FA00E6 for ; Tue, 16 Apr 2019 18:08:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08E301B50D; Tue, 16 Apr 2019 18:08:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B05EB1B50C for ; Tue, 16 Apr 2019 18:08:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 09:08:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,358,1549958400"; d="scan'208";a="338015808" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.46]) ([10.237.221.46]) by fmsmga006.fm.intel.com with ESMTP; 16 Apr 2019 09:08:55 -0700 To: Yong Wang , Eduard Serra Miralles Cc: "dev@dpdk.org" References: <1554957873-12549-1-git-send-email-eserra@vmware.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl 1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx 5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+ aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj 0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4 YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7 llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86 lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6 LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D 2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE 56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8= Message-ID: Date: Tue, 16 Apr 2019 17:08:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416160854.FQ--JNwyAAVf1jtdhSSbX4cSwm98Ol-dAZfJwvyyd6o@z> On 4/12/2019 7:13 PM, Yong Wang wrote: > -----Original Message----- > From: Eduard Serra Miralles > Date: Wednesday, April 10, 2019 at 9:44 PM > To: Yong Wang > Cc: "dev@dpdk.org" , Eduard Serra Miralles > Subject: [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration > > From: Eduard Serra > > This patch introduces: > - VMxnet3 v4 negotiation and, > - entirely guest-driven UDP RSS support. > > VMxnet3 v3 already has UDP RSS support, however it > depends on hypervisor provisioning on the VM through > ESX specific flags, which are not transparent or known > to the guest later on. > > Vmxnet3 v4 introduces a new API transaction which allows > configuring RSS entirely from the guest. This API must be > invoked after device shared mem region init. > > IPv4 ESP RSS (SPI based) is also available, but currently > there are no ESP RSS definitions on rte_eth layer to > handle that. > > Signed-off-by: Eduard Serra > --- > > Acked-by: Yong Wang > > One comment below. > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 21 +++++++++++++++++- > drivers/net/vmxnet3/vmxnet3_ethdev.h | 8 +++++++ > drivers/net/vmxnet3/vmxnet3_rxtx.c | 41 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 69 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index 93e5de9..846d7fd 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -266,7 +266,11 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev) > ver = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_VRRS); > PMD_INIT_LOG(DEBUG, "Hardware version : %d", ver); > > - if (ver & (1 << VMXNET3_REV_3)) { > + if (ver & (1 << VMXNET3_REV_4)) { > + VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS, > + 1 << VMXNET3_REV_4); > + hw->version = VMXNET3_REV_4 + 1; > + } else if (ver & (1 << VMXNET3_REV_3)) { > VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS, > 1 << VMXNET3_REV_3); > hw->version = VMXNET3_REV_3 + 1; > @@ -764,6 +768,15 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) > PMD_INIT_LOG(DEBUG, "Failed to setup memory region\n"); > } > > + if (VMXNET3_VERSION_GE_4(hw)) { > + /* Check for additional RSS */ > + ret = vmxnet3_v4_rss_configure(dev); > + if (ret != VMXNET3_SUCCESS) { > + PMD_INIT_LOG(ERR, "Failed to configure v4 RSS"); > + return ret; > + } > + } > + > /* Disable interrupts */ > vmxnet3_disable_intr(hw); > > @@ -1141,6 +1154,8 @@ static void > vmxnet3_dev_info_get(struct rte_eth_dev *dev __rte_unused, > struct rte_eth_dev_info *dev_info) > { > + struct vmxnet3_hw *hw = dev->data->dev_private; > + > dev_info->max_rx_queues = VMXNET3_MAX_RX_QUEUES; > dev_info->max_tx_queues = VMXNET3_MAX_TX_QUEUES; > dev_info->min_rx_bufsize = 1518 + RTE_PKTMBUF_HEADROOM; > @@ -1150,6 +1165,10 @@ vmxnet3_dev_info_get(struct rte_eth_dev *dev __rte_unused, > > dev_info->flow_type_rss_offloads = VMXNET3_RSS_OFFLOAD_ALL; > > + if (VMXNET3_VERSION_GE_4(hw)) { > + dev_info->flow_type_rss_offloads |= VMXNET3_V4_RSS_MASK; > + } > + > dev_info->rx_desc_lim = (struct rte_eth_desc_lim) { > .nb_max = VMXNET3_RX_RING_MAX_SIZE, > .nb_min = VMXNET3_DEF_RX_RING_SIZE, > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.h b/drivers/net/vmxnet3/vmxnet3_ethdev.h > index 5bc3a84..319d739 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.h > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.h > @@ -34,6 +34,10 @@ > ETH_RSS_IPV6 | \ > ETH_RSS_NONFRAG_IPV6_TCP) > > +#define VMXNET3_V4_RSS_MASK ( \ > + ETH_RSS_NONFRAG_IPV4_UDP | \ > + ETH_RSS_NONFRAG_IPV6_UDP) > + > /* RSS configuration structure - shared with device through GPA */ > typedef struct VMXNET3_RSSConf { > uint16_t hashType; > @@ -103,10 +107,12 @@ struct vmxnet3_hw { > UPT1_RxStats snapshot_rx_stats[VMXNET3_MAX_RX_QUEUES]; > }; > > +#define VMXNET3_REV_4 3 /* Vmxnet3 Rev. 4 */ > #define VMXNET3_REV_3 2 /* Vmxnet3 Rev. 3 */ > #define VMXNET3_REV_2 1 /* Vmxnet3 Rev. 2 */ > #define VMXNET3_REV_1 0 /* Vmxnet3 Rev. 1 */ > > +#define VMXNET3_VERSION_GE_4(hw) ((hw)->version >= VMXNET3_REV_4 + 1) > #define VMXNET3_VERSION_GE_3(hw) ((hw)->version >= VMXNET3_REV_3 + 1) > #define VMXNET3_VERSION_GE_2(hw) ((hw)->version >= VMXNET3_REV_2 + 1) > > @@ -162,6 +168,8 @@ void vmxnet3_dev_clear_queues(struct rte_eth_dev *dev); > void vmxnet3_dev_rx_queue_release(void *rxq); > void vmxnet3_dev_tx_queue_release(void *txq); > > +int vmxnet3_v4_rss_configure(struct rte_eth_dev *dev); > + > int vmxnet3_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id, > uint16_t nb_rx_desc, unsigned int socket_id, > const struct rte_eth_rxconf *rx_conf, > diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c > index d30914a..9d80646 100644 > --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c > +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c > @@ -1292,6 +1292,47 @@ static uint8_t rss_intel_key[40] = { > }; > > /* > + * Additional RSS configurations based on vmxnet v4+ APIs > + */ > +int > +vmxnet3_v4_rss_configure(struct rte_eth_dev *dev) > +{ > + struct vmxnet3_hw *hw = dev->data->dev_private; > + Vmxnet3_DriverShared *shared = hw->shared; > + Vmxnet3_CmdInfo *cmdInfo = &shared->cu.cmdInfo; > + struct rte_eth_rss_conf *port_rss_conf; > + uint64_t rss_hf; > + uint32_t ret; > + > + PMD_INIT_FUNC_TRACE(); > + > + cmdInfo->setRSSFields = 0; > + port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf; > + rss_hf = port_rss_conf->rss_hf & > + (VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL); > + > + if (rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) > + cmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_TCPIP4; > + if (rss_hf & ETH_RSS_NONFRAG_IPV6_TCP) > + cmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_TCPIP6; > + if (rss_hf & ETH_RSS_NONFRAG_IPV4_UDP) > + cmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_UDPIP4; > + if (rss_hf & ETH_RSS_NONFRAG_IPV6_UDP) > + cmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_UDPIP6; > + /* TODO: ESP RSS is currently not define in rte_eth layer */ > > Let's just remove this as it has nothing to do with this change. Reminder that this patch is waiting for this change request.