From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 709A4A00E6 for <public@inbox.dpdk.org>; Tue, 16 Apr 2019 18:16:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49B901B514; Tue, 16 Apr 2019 18:16:03 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 2DE931B511 for <dev@dpdk.org>; Tue, 16 Apr 2019 18:16:02 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3GGAW2Q014485; Tue, 16 Apr 2019 09:16:01 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=Y3tVFycpSzEAmPQ0kL5r+OV+GFqF2FcdjzZnnpFZcwo=; b=T0u+KqXkQHMiFTpzWkXZg8+H3Rml1Xc7V+8n61+1c+yxh5s2bCiZRvG/I4bnqGYohxnB CRmyDS7k6UgRDbuRvX1yBEo2LxRD/UN/75kdxINuU8qAwhtTu9lUmMEF5zDWbk2qivpQ ezkG4+jb2CcJ8toRoLBO+URFaCi6C3dUswtL2sUf9ec4M4tsBXJKM/+XIMvsWGJJezAW OGHjZ6CmoSU52OLJXUPiNtvGaz5as3T3N2277uLLXiW4kT93UXQVDuyRbyMytZcJjJoI l7a9ccXTS5p7IiRFJU5c8eyl3uefHJhkQi2oMJD20EK/1CKNysDP6zOrVzO4OItHE7nH Dw== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2rw5ydb0gx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 16 Apr 2019 09:16:01 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 16 Apr 2019 09:16:00 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.50) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 16 Apr 2019 09:16:00 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y3tVFycpSzEAmPQ0kL5r+OV+GFqF2FcdjzZnnpFZcwo=; b=NNidCGcZZQ2XvuTuUCt62mg7xr5eqi3adpt/jqLOi5a+TRX4L+SwABJwbx/1bXKBy5efyYedLcDp/jvzQDHK0gBWd+G1jlIXF0MCXJlX3hOVIlykmCynPUXMA/td2Wk9VeTQgM1DqPBFFLPL95+T7TgPHCp1QNhYkVe5amHVyXw= Received: from MN2PR18MB2542.namprd18.prod.outlook.com (20.179.82.221) by MN2PR18MB2592.namprd18.prod.outlook.com (20.179.83.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.12; Tue, 16 Apr 2019 16:15:55 +0000 Received: from MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90]) by MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90%6]) with mapi id 15.20.1792.018; Tue, 16 Apr 2019 16:15:55 +0000 From: Ayuj Verma <ayverma@marvell.com> To: "Trahe, Fiona" <fiona.trahe@intel.com>, "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com> CC: Shally Verma <shallyv@marvell.com>, Sunila Sahu <ssahu@marvell.com>, Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>, Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [PATCH v1] fix alphabetical ordering of headers Thread-Index: AQHU8P3fmhBexq3vuU+QDmqZmqM/JKY4o74AgAZY0/c= Date: Tue, 16 Apr 2019 16:15:55 +0000 Message-ID: <MN2PR18MB25427C462B53137B77330221AD240@MN2PR18MB2542.namprd18.prod.outlook.com> References: <1555052602-19155-1-git-send-email-ayverma@marvell.com>, <348A99DA5F5B7549AA880327E580B4358973F9C4@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B4358973F9C4@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c3ffec0-c448-4c4d-436d-08d6c286cdfe x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(2017052603328)(7193020); SRVR:MN2PR18MB2592; x-ms-traffictypediagnostic: MN2PR18MB2592: x-microsoft-antispam-prvs: <MN2PR18MB25921AB594C7450477275569AD240@MN2PR18MB2592.namprd18.prod.outlook.com> x-forefront-prvs: 000947967F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(136003)(39860400002)(346002)(13464003)(199004)(189003)(486006)(8676002)(11346002)(74316002)(476003)(81166006)(99946001)(256004)(14444005)(446003)(4326008)(478600001)(81156014)(25786009)(14454004)(6436002)(229853002)(6606003)(33656002)(97736004)(66066001)(2501003)(53936002)(3846002)(106356001)(6116002)(52536014)(2906002)(105586002)(55016002)(9686003)(76176011)(54896002)(236005)(86362001)(99286004)(7696005)(71200400001)(19627405001)(71190400001)(186003)(316002)(102836004)(55236004)(110136005)(26005)(54906003)(5660300002)(6246003)(7736002)(53546011)(68736007)(6506007)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2592; H:MN2PR18MB2542.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: JnlWmtecKl00ICyOJS+gzHhWwoN5sTr26h7ahoRnznT4hroB9tO5d7XWAc5CrZtJbOUY68vfBMsGudlwo6RyYciw+0LspNZFWN+L3fVex7w1FHpWZXdY9b19J5C2JoKdO6QYfObfpjkBFU8TRgN+KOUHtpNJeN5QuhxJ0hHSWCxSESi+qAD29BAl0D6uCLU+ixhTzHJGKD+USA5i5teBEnAyyAvZNcaaoPgRMrqOP5Ljzxr1jxmJ1jDdzbmjlHcFeR14o2zodjXwMxz7vH7E2Bd1yMMc4ms76/u24gSmqTuVkBY+kIXq7v8x/Y5eIlAo1+QMv3SdNEk7rA+DevPmEwoSSqFgnMyJrI5klts4dyY3wlRpduy8E4A/c7eilxVY6FCytER9dkmzmA6t7YrtarYRTyZlWVCV11m4AdwRt/U= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9c3ffec0-c448-4c4d-436d-08d6c286cdfe X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 16:15:55.5601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2592 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-16_06:, , signatures=0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190416161555.v1husIh4fSNV_4JDjh06tsURncpM31NOp43rIF7RdAA@z> Hi Fiona, Sorry for delay in response. Please see inline. Thanks and regards Ayuj Verma ________________________________ From: Trahe, Fiona <fiona.trahe@intel.com> Sent: 12 April 2019 20:47 To: Ayuj Verma; akhil.goyal@nxp.com; Kusztal, ArkadiuszX Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev@d= pdk.org; Trahe, Fiona Subject: RE: [PATCH v1] fix alphabetical ordering of headers Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.goyal@nxp.com; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.co= m>; Trahe, Fiona > <fiona.trahe@intel.com> > Cc: shallyv@marvell.com; ssahu@marvell.com; kkotamarthy@marvell.com; ades= ai@marvell.com; > dev@dpdk.org; Ayuj Verma <ayverma@marvell.com> > Subject: [PATCH v1] fix alphabetical ordering of headers > > rte_crypto_sym.h is included prior to rte_crypto_asym.h > in rte_crypto.h, which breaks alphabetical order. > > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. [Fiona] I presume you tried just swapping the order and it broke? If something in rte_crypto_asym.h depends on something from rte_crypto_sym.= h, it probably shouldn't. What's the dependency and can/should it be moved to rte= _crypto.h? [Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So = do you suggest to move it to rte_crypto.h?