From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8C59FA00E6 for <public@inbox.dpdk.org>; Tue, 16 Apr 2019 23:50:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 469C11B561; Tue, 16 Apr 2019 23:50:48 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id B53DA1B55B for <dev@dpdk.org>; Tue, 16 Apr 2019 23:50:46 +0200 (CEST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3GLYBOG116787 for <dev@dpdk.org>; Tue, 16 Apr 2019 17:50:45 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rwpn5hfa3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for <dev@dpdk.org>; Tue, 16 Apr 2019 17:50:45 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for <dev@dpdk.org> from <drc@linux.vnet.ibm.com>; Tue, 16 Apr 2019 22:50:44 +0100 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 16 Apr 2019 22:50:41 +0100 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x3GLoeJl28639430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 Apr 2019 21:50:40 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 67498112061; Tue, 16 Apr 2019 21:50:40 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A8A44112062; Tue, 16 Apr 2019 21:50:39 +0000 (GMT) Received: from davids-mbp.usor.ibm.com (unknown [9.70.85.36]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 16 Apr 2019 21:50:39 +0000 (GMT) To: Stephen Hemminger <stephen@networkplumber.org>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Cc: Andrew Rybchenko <arybchenko@solarflare.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, "radhika.chirra@ibm.com" <radhika.chirra@ibm.com>, "stable@dpdk.org" <stable@dpdk.org> References: <1554927376-93022-1-git-send-email-drc@linux.vnet.ibm.com> <1554932214-96522-1-git-send-email-drc@linux.vnet.ibm.com> <51c69c8b-9b23-4c48-bf70-2f4881ce873b@intel.com> <c003e650-c62d-fec6-d886-f643dee35bbd@solarflare.com> <2601191342CEEE43887BDE71AB9772580148A98822@irsmsx105.ger.corp.intel.com> <20190416141919.523b4c8b@xps13.lan> From: David Christensen <drc@linux.vnet.ibm.com> Date: Tue, 16 Apr 2019 14:50:39 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190416141919.523b4c8b@xps13.lan> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19041621-0040-0000-0000-000004E1E58C X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010940; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000284; SDB=6.01190074; UDB=6.00623590; IPR=6.00970869; MB=3.00026473; MTD=3.00000008; XFM=3.00000015; UTC=2019-04-16 21:50:43 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19041621-0041-0000-0000-000008ECF023 Message-Id: <adb2aed7-9793-66e2-7e98-94a0dbe17857@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-16_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904160130 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ethdev: missing typecast causes C++ build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190416215039._0fcwygIGXeZxJeCyhQrvd4GPPeIkv5aMBvpDTiBuF0@z> >>>>> In file included from drivers/pmd.cc:7:0: >>>>> /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h: >>>>> In function ‘int eth_dev_pci_specific_init(rte_eth_dev*, void*)’: >>>>> /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:75:35:· >>>>> error: invalid conversion from ‘void*’ to ‘rte_pci_device*’ >>>>> [-fpermissive] >>>>> struct rte_pci_device *pci_dev = bus_device; >>>>> ^~~~~~~~~~ >>>>> make[1]: *** [drivers/pmd.o] Error 1 >>>>> >>>>> $ g++ --version >>>>> g++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0 >>>> This problem is while building a driver with c++ compiler, but since the >>>> solution is a simple casting, which doesn't have any side affect, I am for >>>> getting the patch, any objection? >>> >>> It should be a decision that we support PMDs in C++ (if I understand >>> the usage correctly) and it will require all headers to be compatible and >>> ideally it should be checked by build automation (otherwise we will break >>> and fix it pretty often). >> >> Or as alternative, we probably can claim that PMDs in C++ are not supported, >> and if people like to do that - they have to deal with it on their own >> (create a C wrapper file, or so). >> Konstantin >> > +1 no drivers or other parts of EAL in C++ > I've learned more about the intended usage in this case and it turns out not to be a PMD at all, it's an application that's reaching into the EAL in what I consider an inappropriate way. As a result I'm withdrawing the patch request and I'll work with the developers to find an alternate solution to their problem. Dave