From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60059.outbound.protection.outlook.com [40.107.6.59]) by dpdk.org (Postfix) with ESMTP id 89ED71B55B for ; Wed, 17 Apr 2019 02:01:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=orqFVwL2jHHXliiuq7sV1/18m2q2dybM63FUpnhRiHk=; b=PQxH9eQ1Bcx3flAw0iQMsWSRx2ZmF9uHJHQm8L6NohqU2Fz5cpk3vb0GQ2eMtyQVckJ5FhhMOuxtV1agioctiWtSPoocJ9sPOasqLu+KgPyl8sZZ8tH7JgKbyNNswr6asQGki04dyoxRvKNCei8/Ovf1MQ1gSp8U+l0jvs7nDG0= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3978.eurprd05.prod.outlook.com (52.134.65.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.11; Wed, 17 Apr 2019 00:01:15 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a%3]) with mapi id 15.20.1813.011; Wed, 17 Apr 2019 00:01:15 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules Thread-Index: AQHU8wb0aAWsEJikrkmcJadZcLDK+qY/e0KA Date: Wed, 17 Apr 2019 00:01:15 +0000 Message-ID: <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-3-git-send-email-orika@mellanox.com> In-Reply-To: <1555276357-4892-3-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR02CA0059.namprd02.prod.outlook.com (2603:10b6:a03:54::36) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6fee6cfa-61f2-4aec-3fc7-08d6c2c7cf81 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:DB3PR0502MB3978; x-ms-traffictypediagnostic: DB3PR0502MB3978: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(136003)(376002)(346002)(39860400002)(189003)(199004)(229853002)(7736002)(305945005)(2906002)(5660300002)(86362001)(76176011)(99286004)(6636002)(14454004)(106356001)(97736004)(478600001)(105586002)(6436002)(6862004)(4326008)(54906003)(6486002)(33656002)(6246003)(66066001)(1076003)(102836004)(71190400001)(25786009)(9686003)(6512007)(186003)(6116002)(8936002)(71200400001)(3846002)(386003)(6506007)(26005)(256004)(81156014)(53936002)(8676002)(52116002)(81166006)(476003)(11346002)(486006)(446003)(68736007)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3978; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 8Xx6fjvfCQa2hHnFOOMRSjwHTpFZMUD9Omuf1+rcT2TPrsnMrUi5NgDhc3z0iajPMjF7jR6o4bP2+3GIT+IDT02XCr9yXjF809ASFLdlz2Pu6m57pH1IEG1SfDcnagMGLmq4SS2oXz6t18Ch7QlNXcaq1T8evmQt0BZmRNxLZieyEe36TjeAsEtjVscX1eqhKaqdpETQowR46dtJTj5Z5yi3IH+kdldafNaGsQWbxdqU0wI8tH7ovv29PxyIw2cD/dv+BSyTnct1XiHGVeLCrPtlS7iXjI2h3hu/2NcxpTUxWPbO3kBe7SPwq4vQYY+q8dt486OAN2vaOM7qzeq1kdSrL0DS35Dyh8UwC5UzAIXRqsal3LNq7y0ZbLR536ijJOVsaoPMF2RVSziVjfQGCMcGfNb02Ba5rY+Sv15ckoc= Content-Type: text/plain; charset="us-ascii" Content-ID: <7DE353EC905813469ACCAFA18EDF8960@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fee6cfa-61f2-4aec-3fc7-08d6c2c7cf81 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 00:01:15.7950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3978 Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 00:01:18 -0000 On Sun, Apr 14, 2019 at 09:12:30PM +0000, Ori Kam wrote: > The meson build was missing the define for Direct Rules. >=20 > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > Cc: orika@mellanox.com >=20 > Signed-off-by: Ori Kam > --- > drivers/net/mlx5/meson.build | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build > index a4c684e..0037e15 100644 > --- a/drivers/net/mlx5/meson.build > +++ b/drivers/net/mlx5/meson.build > @@ -111,6 +111,8 @@ if build > 'mlx5dv_devx_obj_create' ], > [ 'HAVE_IBV_FLOW_DEVX_COUNTERS', 'infiniband/mlx5dv.h', > 'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ], > + [ 'HAVE_MLX5DV_DR', 'infiniband/mlx5dv.h', > + 'MLX5DV_DR_NS_TYPE_TERMINATING' ], Better to change the inconsistent naming? HAVE_MLX5DV_DR -> HAVE_IBV_FLOW_DV_DIRECT_RULES And I want it to be at a similar location to Makefile. Let's put it next to HAVE_IBV_FLOW_DV_SUPPORT. thanks Yongseok > [ 'HAVE_SUPPORTED_40000baseKR4_Full', 'linux/ethtool.h', > 'SUPPORTED_40000baseKR4_Full' ], > [ 'HAVE_SUPPORTED_40000baseCR4_Full', 'linux/ethtool.h', > --=20 > 1.8.3.1 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F3E85A00E6 for ; Wed, 17 Apr 2019 02:01:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BE9F1B561; Wed, 17 Apr 2019 02:01:20 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60059.outbound.protection.outlook.com [40.107.6.59]) by dpdk.org (Postfix) with ESMTP id 89ED71B55B for ; Wed, 17 Apr 2019 02:01:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=orqFVwL2jHHXliiuq7sV1/18m2q2dybM63FUpnhRiHk=; b=PQxH9eQ1Bcx3flAw0iQMsWSRx2ZmF9uHJHQm8L6NohqU2Fz5cpk3vb0GQ2eMtyQVckJ5FhhMOuxtV1agioctiWtSPoocJ9sPOasqLu+KgPyl8sZZ8tH7JgKbyNNswr6asQGki04dyoxRvKNCei8/Ovf1MQ1gSp8U+l0jvs7nDG0= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3978.eurprd05.prod.outlook.com (52.134.65.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1813.11; Wed, 17 Apr 2019 00:01:15 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::6072:43be:7c2d:103a%3]) with mapi id 15.20.1813.011; Wed, 17 Apr 2019 00:01:15 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules Thread-Index: AQHU8wb0aAWsEJikrkmcJadZcLDK+qY/e0KA Date: Wed, 17 Apr 2019 00:01:15 +0000 Message-ID: <20190417000101.GE21044@mtidpdk.mti.labs.mlnx> References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555276357-4892-3-git-send-email-orika@mellanox.com> In-Reply-To: <1555276357-4892-3-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR02CA0059.namprd02.prod.outlook.com (2603:10b6:a03:54::36) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6fee6cfa-61f2-4aec-3fc7-08d6c2c7cf81 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600140)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:DB3PR0502MB3978; x-ms-traffictypediagnostic: DB3PR0502MB3978: x-microsoft-antispam-prvs: x-forefront-prvs: 0010D93EFE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(136003)(376002)(346002)(39860400002)(189003)(199004)(229853002)(7736002)(305945005)(2906002)(5660300002)(86362001)(76176011)(99286004)(6636002)(14454004)(106356001)(97736004)(478600001)(105586002)(6436002)(6862004)(4326008)(54906003)(6486002)(33656002)(6246003)(66066001)(1076003)(102836004)(71190400001)(25786009)(9686003)(6512007)(186003)(6116002)(8936002)(71200400001)(3846002)(386003)(6506007)(26005)(256004)(81156014)(53936002)(8676002)(52116002)(81166006)(476003)(11346002)(486006)(446003)(68736007)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3978; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 8Xx6fjvfCQa2hHnFOOMRSjwHTpFZMUD9Omuf1+rcT2TPrsnMrUi5NgDhc3z0iajPMjF7jR6o4bP2+3GIT+IDT02XCr9yXjF809ASFLdlz2Pu6m57pH1IEG1SfDcnagMGLmq4SS2oXz6t18Ch7QlNXcaq1T8evmQt0BZmRNxLZieyEe36TjeAsEtjVscX1eqhKaqdpETQowR46dtJTj5Z5yi3IH+kdldafNaGsQWbxdqU0wI8tH7ovv29PxyIw2cD/dv+BSyTnct1XiHGVeLCrPtlS7iXjI2h3hu/2NcxpTUxWPbO3kBe7SPwq4vQYY+q8dt486OAN2vaOM7qzeq1kdSrL0DS35Dyh8UwC5UzAIXRqsal3LNq7y0ZbLR536ijJOVsaoPMF2RVSziVjfQGCMcGfNb02Ba5rY+Sv15ckoc= Content-Type: text/plain; charset="UTF-8" Content-ID: <7DE353EC905813469ACCAFA18EDF8960@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fee6cfa-61f2-4aec-3fc7-08d6c2c7cf81 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2019 00:01:15.7950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3978 Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417000115.rehVtSauFQQNFLpNqeSsMwL_urxlLWglgbN8l-LopO0@z> On Sun, Apr 14, 2019 at 09:12:30PM +0000, Ori Kam wrote: > The meson build was missing the define for Direct Rules. >=20 > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > Cc: orika@mellanox.com >=20 > Signed-off-by: Ori Kam > --- > drivers/net/mlx5/meson.build | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build > index a4c684e..0037e15 100644 > --- a/drivers/net/mlx5/meson.build > +++ b/drivers/net/mlx5/meson.build > @@ -111,6 +111,8 @@ if build > 'mlx5dv_devx_obj_create' ], > [ 'HAVE_IBV_FLOW_DEVX_COUNTERS', 'infiniband/mlx5dv.h', > 'MLX5DV_FLOW_ACTION_COUNTERS_DEVX' ], > + [ 'HAVE_MLX5DV_DR', 'infiniband/mlx5dv.h', > + 'MLX5DV_DR_NS_TYPE_TERMINATING' ], Better to change the inconsistent naming? HAVE_MLX5DV_DR -> HAVE_IBV_FLOW_DV_DIRECT_RULES And I want it to be at a similar location to Makefile. Let's put it next to HAVE_IBV_FLOW_DV_SUPPORT. thanks Yongseok > [ 'HAVE_SUPPORTED_40000baseKR4_Full', 'linux/ethtool.h', > 'SUPPORTED_40000baseKR4_Full' ], > [ 'HAVE_SUPPORTED_40000baseCR4_Full', 'linux/ethtool.h', > --=20 > 1.8.3.1 >=20