From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C1DD51B5D4 for ; Wed, 17 Apr 2019 11:02:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 02:02:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,361,1549958400"; d="scan'208";a="165467608" Received: from yexl-server.sh.intel.com ([10.67.110.206]) by fmsmga001.fm.intel.com with ESMTP; 17 Apr 2019 02:02:42 -0700 From: Xiaolong Ye To: dev@dpdk.org, Ferruh Yigit , David Marchand Cc: Qi Zhang , Karlsson Magnus , Topel Bjorn , Xiaolong Ye Date: Wed, 17 Apr 2019 16:56:51 +0800 Message-Id: <20190417085653.110559-3-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190417085653.110559-1-xiaolong.ye@intel.com> References: <20190417085653.110559-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH v3 2/4] net/af_xdp: specify minimal and maximal MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 09:02:45 -0000 Since AF_XDP pmd doesn't support multi segment, we need to add a valid check in eth_dev_mtu_set. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 5cc643ce2..8430921af 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -351,6 +351,9 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->max_rx_queues = 1; dev_info->max_tx_queues = 1; + dev_info->min_mtu = ETHER_MIN_MTU; + dev_info->max_mtu = ETH_AF_XDP_FRAME_SIZE - ETH_AF_XDP_DATA_HEADROOM; + dev_info->default_rxportconf.nb_queues = 1; dev_info->default_txportconf.nb_queues = 1; dev_info->default_rxportconf.ring_size = ETH_AF_XDP_DFLT_NUM_DESCS; @@ -654,6 +657,15 @@ eth_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) int ret; int s; + if (mtu > ETH_AF_XDP_FRAME_SIZE - ETH_AF_XDP_DATA_HEADROOM || + mtu < ETHER_MIN_MTU) { + AF_XDP_LOG(ERR, "Unsupported MTU of %d. " + "max mtu: %d, min mtu: %d", mtu, + ETH_AF_XDP_FRAME_SIZE - ETH_AF_XDP_DATA_HEADROOM, + ETHER_MIN_MTU); + return -EINVAL; + } + s = socket(PF_INET, SOCK_DGRAM, 0); if (s < 0) return -EINVAL; -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BEDF8A00E6 for ; Wed, 17 Apr 2019 11:02:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A3FB1B5E0; Wed, 17 Apr 2019 11:02:48 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C1DD51B5D4 for ; Wed, 17 Apr 2019 11:02:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 02:02:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,361,1549958400"; d="scan'208";a="165467608" Received: from yexl-server.sh.intel.com ([10.67.110.206]) by fmsmga001.fm.intel.com with ESMTP; 17 Apr 2019 02:02:42 -0700 From: Xiaolong Ye To: dev@dpdk.org, Ferruh Yigit , David Marchand Cc: Qi Zhang , Karlsson Magnus , Topel Bjorn , Xiaolong Ye Date: Wed, 17 Apr 2019 16:56:51 +0800 Message-Id: <20190417085653.110559-3-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190417085653.110559-1-xiaolong.ye@intel.com> References: <20190417085653.110559-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH v3 2/4] net/af_xdp: specify minimal and maximal MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190417085651.x09jS3rxqv_OrTMvVc8qk632RnumVkxH9ZvR3e3r_1o@z> Since AF_XDP pmd doesn't support multi segment, we need to add a valid check in eth_dev_mtu_set. Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 5cc643ce2..8430921af 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -351,6 +351,9 @@ eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->max_rx_queues = 1; dev_info->max_tx_queues = 1; + dev_info->min_mtu = ETHER_MIN_MTU; + dev_info->max_mtu = ETH_AF_XDP_FRAME_SIZE - ETH_AF_XDP_DATA_HEADROOM; + dev_info->default_rxportconf.nb_queues = 1; dev_info->default_txportconf.nb_queues = 1; dev_info->default_rxportconf.ring_size = ETH_AF_XDP_DFLT_NUM_DESCS; @@ -654,6 +657,15 @@ eth_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) int ret; int s; + if (mtu > ETH_AF_XDP_FRAME_SIZE - ETH_AF_XDP_DATA_HEADROOM || + mtu < ETHER_MIN_MTU) { + AF_XDP_LOG(ERR, "Unsupported MTU of %d. " + "max mtu: %d, min mtu: %d", mtu, + ETH_AF_XDP_FRAME_SIZE - ETH_AF_XDP_DATA_HEADROOM, + ETHER_MIN_MTU); + return -EINVAL; + } + s = socket(PF_INET, SOCK_DGRAM, 0); if (s < 0) return -EINVAL; -- 2.17.1