* [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
@ 2019-04-17 7:41 Arek Kusztal
2019-04-17 7:41 ` Arek Kusztal
` (3 more replies)
0 siblings, 4 replies; 18+ messages in thread
From: Arek Kusztal @ 2019-04-17 7:41 UTC (permalink / raw)
To: dev; +Cc: akhil.goyal, fiona.trahe, pablo.de.lara.guarch, Arek Kusztal
This patch adds deprecation notice of changing iv behaviour
when using Galois Counter Mode of operation. Right now IV of
all supported sizes can be used.
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ba39c2d..76eb166 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -87,3 +87,9 @@ Deprecation Notices
* cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
+
+* cryptodev: support for using IV with all sizes is added, J0 still can
+ be used but only when IV length in following structs ``rte_crypto_auth_xform``,
+ ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
+ to one it means it represents IV, when is set to zero it means J0 is used
+ directly, in this case 16 bytes of J0 need to be passed.
--
2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-04-17 7:41 [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice Arek Kusztal
@ 2019-04-17 7:41 ` Arek Kusztal
2019-04-17 11:32 ` Trahe, Fiona
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Arek Kusztal @ 2019-04-17 7:41 UTC (permalink / raw)
To: dev; +Cc: akhil.goyal, fiona.trahe, pablo.de.lara.guarch, Arek Kusztal
This patch adds deprecation notice of changing iv behaviour
when using Galois Counter Mode of operation. Right now IV of
all supported sizes can be used.
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ba39c2d..76eb166 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -87,3 +87,9 @@ Deprecation Notices
* cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
+
+* cryptodev: support for using IV with all sizes is added, J0 still can
+ be used but only when IV length in following structs ``rte_crypto_auth_xform``,
+ ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
+ to one it means it represents IV, when is set to zero it means J0 is used
+ directly, in this case 16 bytes of J0 need to be passed.
--
2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-04-17 7:41 [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice Arek Kusztal
2019-04-17 7:41 ` Arek Kusztal
@ 2019-04-17 11:32 ` Trahe, Fiona
2019-04-17 11:32 ` Trahe, Fiona
2019-05-13 21:25 ` Thomas Monjalon
2019-05-08 8:23 ` De Lara Guarch, Pablo
2019-05-09 11:31 ` Anoob Joseph
3 siblings, 2 replies; 18+ messages in thread
From: Trahe, Fiona @ 2019-04-17 11:32 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev; +Cc: akhil.goyal, De Lara Guarch, Pablo, Trahe, Fiona
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, April 17, 2019 8:41 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> This patch adds deprecation notice of changing iv behaviour
> when using Galois Counter Mode of operation. Right now IV of
> all supported sizes can be used.
[Fiona] nit - I would say "With this change..." rather than "Right now..."
Apart from this
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ba39c2d..76eb166 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -87,3 +87,9 @@ Deprecation Notices
> * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> +
> +* cryptodev: support for using IV with all sizes is added, J0 still can
> + be used but only when IV length in following structs ``rte_crypto_auth_xform``,
> + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
> + to one it means it represents IV, when is set to zero it means J0 is used
> + directly, in this case 16 bytes of J0 need to be passed.
> --
> 2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-04-17 11:32 ` Trahe, Fiona
@ 2019-04-17 11:32 ` Trahe, Fiona
2019-05-13 21:25 ` Thomas Monjalon
1 sibling, 0 replies; 18+ messages in thread
From: Trahe, Fiona @ 2019-04-17 11:32 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev; +Cc: akhil.goyal, De Lara Guarch, Pablo, Trahe, Fiona
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, April 17, 2019 8:41 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> This patch adds deprecation notice of changing iv behaviour
> when using Galois Counter Mode of operation. Right now IV of
> all supported sizes can be used.
[Fiona] nit - I would say "With this change..." rather than "Right now..."
Apart from this
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ba39c2d..76eb166 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -87,3 +87,9 @@ Deprecation Notices
> * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> +
> +* cryptodev: support for using IV with all sizes is added, J0 still can
> + be used but only when IV length in following structs ``rte_crypto_auth_xform``,
> + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
> + to one it means it represents IV, when is set to zero it means J0 is used
> + directly, in this case 16 bytes of J0 need to be passed.
> --
> 2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-04-17 7:41 [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice Arek Kusztal
2019-04-17 7:41 ` Arek Kusztal
2019-04-17 11:32 ` Trahe, Fiona
@ 2019-05-08 8:23 ` De Lara Guarch, Pablo
2019-05-08 8:23 ` De Lara Guarch, Pablo
2019-05-09 9:03 ` Akhil Goyal
2019-05-09 11:31 ` Anoob Joseph
3 siblings, 2 replies; 18+ messages in thread
From: De Lara Guarch, Pablo @ 2019-05-08 8:23 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev; +Cc: akhil.goyal, Trahe, Fiona, Anoob Joseph
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, April 17, 2019 8:41 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> This patch adds deprecation notice of changing iv behaviour when using
> Galois Counter Mode of operation. Right now IV of all supported sizes can
> be used.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Also, I am CC'ing Anoob, since he acked the patch that is actually making changes in the comments of the API,
so I assume he agrees with this patch (needed for the other patch).
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-05-08 8:23 ` De Lara Guarch, Pablo
@ 2019-05-08 8:23 ` De Lara Guarch, Pablo
2019-05-09 9:03 ` Akhil Goyal
1 sibling, 0 replies; 18+ messages in thread
From: De Lara Guarch, Pablo @ 2019-05-08 8:23 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev; +Cc: akhil.goyal, Trahe, Fiona, Anoob Joseph
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, April 17, 2019 8:41 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> This patch adds deprecation notice of changing iv behaviour when using
> Galois Counter Mode of operation. Right now IV of all supported sizes can
> be used.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Also, I am CC'ing Anoob, since he acked the patch that is actually making changes in the comments of the API,
so I assume he agrees with this patch (needed for the other patch).
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-05-08 8:23 ` De Lara Guarch, Pablo
2019-05-08 8:23 ` De Lara Guarch, Pablo
@ 2019-05-09 9:03 ` Akhil Goyal
2019-05-09 9:03 ` Akhil Goyal
1 sibling, 1 reply; 18+ messages in thread
From: Akhil Goyal @ 2019-05-09 9:03 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Kusztal, ArkadiuszX, dev
Cc: Trahe, Fiona, Anoob Joseph
> -----Original Message-----
> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Sent: Wednesday, May 8, 2019 1:53 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> Anoob Joseph <anoobj@marvell.com>
> Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
>
>
> > -----Original Message-----
> > From: Kusztal, ArkadiuszX
> > Sent: Wednesday, April 17, 2019 8:41 AM
> > To: dev@dpdk.org
> > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; De Lara
> > Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Kusztal, ArkadiuszX
> > <arkadiuszx.kusztal@intel.com>
> > Subject: [PATCH] doc: add cryptodev gcm iv deprecation notice
> >
> > This patch adds deprecation notice of changing iv behaviour when using
> > Galois Counter Mode of operation. Right now IV of all supported sizes can
> > be used.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Also, I am CC'ing Anoob, since he acked the patch that is actually making
> changes in the comments of the API,
> so I assume he agrees with this patch (needed for the other patch).
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-05-09 9:03 ` Akhil Goyal
@ 2019-05-09 9:03 ` Akhil Goyal
0 siblings, 0 replies; 18+ messages in thread
From: Akhil Goyal @ 2019-05-09 9:03 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Kusztal, ArkadiuszX, dev
Cc: Trahe, Fiona, Anoob Joseph
> -----Original Message-----
> From: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Sent: Wednesday, May 8, 2019 1:53 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> Anoob Joseph <anoobj@marvell.com>
> Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
>
>
> > -----Original Message-----
> > From: Kusztal, ArkadiuszX
> > Sent: Wednesday, April 17, 2019 8:41 AM
> > To: dev@dpdk.org
> > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; De Lara
> > Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Kusztal, ArkadiuszX
> > <arkadiuszx.kusztal@intel.com>
> > Subject: [PATCH] doc: add cryptodev gcm iv deprecation notice
> >
> > This patch adds deprecation notice of changing iv behaviour when using
> > Galois Counter Mode of operation. Right now IV of all supported sizes can
> > be used.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Also, I am CC'ing Anoob, since he acked the patch that is actually making
> changes in the comments of the API,
> so I assume he agrees with this patch (needed for the other patch).
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-04-17 7:41 [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice Arek Kusztal
` (2 preceding siblings ...)
2019-05-08 8:23 ` De Lara Guarch, Pablo
@ 2019-05-09 11:31 ` Anoob Joseph
2019-05-09 11:31 ` Anoob Joseph
3 siblings, 1 reply; 18+ messages in thread
From: Anoob Joseph @ 2019-05-09 11:31 UTC (permalink / raw)
To: Arek Kusztal, dev; +Cc: akhil.goyal, fiona.trahe, pablo.de.lara.guarch
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Arek Kusztal
> Sent: Wednesday, April 17, 2019 1:11 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com;
> pablo.de.lara.guarch@intel.com; Arek Kusztal
> <arkadiuszx.kusztal@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> This patch adds deprecation notice of changing iv behaviour when using
> Galois Counter Mode of operation. Right now IV of all supported sizes can be
> used.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-05-09 11:31 ` Anoob Joseph
@ 2019-05-09 11:31 ` Anoob Joseph
0 siblings, 0 replies; 18+ messages in thread
From: Anoob Joseph @ 2019-05-09 11:31 UTC (permalink / raw)
To: Arek Kusztal, dev; +Cc: akhil.goyal, fiona.trahe, pablo.de.lara.guarch
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Arek Kusztal
> Sent: Wednesday, April 17, 2019 1:11 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com;
> pablo.de.lara.guarch@intel.com; Arek Kusztal
> <arkadiuszx.kusztal@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> This patch adds deprecation notice of changing iv behaviour when using
> Galois Counter Mode of operation. Right now IV of all supported sizes can be
> used.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-04-17 11:32 ` Trahe, Fiona
2019-04-17 11:32 ` Trahe, Fiona
@ 2019-05-13 21:25 ` Thomas Monjalon
2019-05-13 21:25 ` Thomas Monjalon
1 sibling, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2019-05-13 21:25 UTC (permalink / raw)
To: Kusztal, ArkadiuszX
Cc: dev, Trahe, Fiona, akhil.goyal, De Lara Guarch, Pablo, Anoob Joseph
> > This patch adds deprecation notice of changing iv behaviour
> > when using Galois Counter Mode of operation. Right now IV of
> > all supported sizes can be used.
> [Fiona] nit - I would say "With this change..." rather than "Right now..."
> Apart from this
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Updated and applied, thanks
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-05-13 21:25 ` Thomas Monjalon
@ 2019-05-13 21:25 ` Thomas Monjalon
0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2019-05-13 21:25 UTC (permalink / raw)
To: Kusztal, ArkadiuszX
Cc: dev, Trahe, Fiona, akhil.goyal, De Lara Guarch, Pablo, Anoob Joseph
> > This patch adds deprecation notice of changing iv behaviour
> > when using Galois Counter Mode of operation. Right now IV of
> > all supported sizes can be used.
> [Fiona] nit - I would say "With this change..." rather than "Right now..."
> Apart from this
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Updated and applied, thanks
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-05-03 18:09 ` Trahe, Fiona
2019-05-03 18:09 ` Trahe, Fiona
@ 2019-05-04 18:06 ` Liron Himi
2019-05-04 18:06 ` Liron Himi
1 sibling, 1 reply; 18+ messages in thread
From: Liron Himi @ 2019-05-04 18:06 UTC (permalink / raw)
To: Trahe, Fiona, Doherty, Declan, ravi1.kumar, tdu
Cc: De Lara Guarch, Pablo, dev, Kusztal, ArkadiuszX, Anoob Joseph,
Shally Verma, akhil.goyal, Liron Himi
+1
Regards,
Liron
-----Original Message-----
From: Trahe, Fiona <fiona.trahe@intel.com>
Sent: Friday, May 3, 2019 9:10 PM
To: Doherty, Declan <declan.doherty@intel.com>; ravi1.kumar@amd.com; tdu@semihalf.com; Liron Himi <lironh@marvell.com>; Alan Winkowski <walan@marvell.com>
Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Anoob Joseph <anoobj@marvell.com>; Shally Verma <shallyv@marvell.com>; akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>
Subject: [EXT] RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
External Email
----------------------------------------------------------------------
Forwarding to maintainers of the following crypto PMDs which may be affected by this:
mvsam
ccp
openssl
Can you review the 19.05 deprecation notice below and if in agreement, ack please - 3 acks are needed
This is the related API change targeted at 19.08:
https://patches.dpdk.org/patch/52886/
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Tuesday, April 30, 2019 7:59 AM
> To: Anoob Joseph <anoobj@marvell.com>; shallyv@marvell.com
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> Hi Anoob/Shally,
>
> Could you please review this patch and provide Ack.
>
> Thanks,
> Akhil
>
>
> >
> >
> > This patch adds deprecation notice of changing iv behaviour when
> > using Galois Counter Mode of operation. Right now IV of all
> > supported sizes can be used.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index ba39c2d..76eb166 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -87,3 +87,9 @@ Deprecation Notices
> > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> > +
> > +* cryptodev: support for using IV with all sizes is added, J0 still
> > +can
> > + be used but only when IV length in following structs
> > +``rte_crypto_auth_xform``,
> > + ``rte_crypto_aead_xform`` is set to zero. When IV length is
> > +greater or equal
> > + to one it means it represents IV, when is set to zero it means J0
> > +is used
> > + directly, in this case 16 bytes of J0 need to be passed.
> > --
> > 2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-05-04 18:06 ` Liron Himi
@ 2019-05-04 18:06 ` Liron Himi
0 siblings, 0 replies; 18+ messages in thread
From: Liron Himi @ 2019-05-04 18:06 UTC (permalink / raw)
To: Trahe, Fiona, Doherty, Declan, ravi1.kumar, tdu
Cc: De Lara Guarch, Pablo, dev, Kusztal, ArkadiuszX, Anoob Joseph,
Shally Verma, akhil.goyal, Liron Himi
+1
Regards,
Liron
-----Original Message-----
From: Trahe, Fiona <fiona.trahe@intel.com>
Sent: Friday, May 3, 2019 9:10 PM
To: Doherty, Declan <declan.doherty@intel.com>; ravi1.kumar@amd.com; tdu@semihalf.com; Liron Himi <lironh@marvell.com>; Alan Winkowski <walan@marvell.com>
Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Anoob Joseph <anoobj@marvell.com>; Shally Verma <shallyv@marvell.com>; akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>
Subject: [EXT] RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
External Email
----------------------------------------------------------------------
Forwarding to maintainers of the following crypto PMDs which may be affected by this:
mvsam
ccp
openssl
Can you review the 19.05 deprecation notice below and if in agreement, ack please - 3 acks are needed
This is the related API change targeted at 19.08:
https://patches.dpdk.org/patch/52886/
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Tuesday, April 30, 2019 7:59 AM
> To: Anoob Joseph <anoobj@marvell.com>; shallyv@marvell.com
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> Hi Anoob/Shally,
>
> Could you please review this patch and provide Ack.
>
> Thanks,
> Akhil
>
>
> >
> >
> > This patch adds deprecation notice of changing iv behaviour when
> > using Galois Counter Mode of operation. Right now IV of all
> > supported sizes can be used.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index ba39c2d..76eb166 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -87,3 +87,9 @@ Deprecation Notices
> > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> > +
> > +* cryptodev: support for using IV with all sizes is added, J0 still
> > +can
> > + be used but only when IV length in following structs
> > +``rte_crypto_auth_xform``,
> > + ``rte_crypto_aead_xform`` is set to zero. When IV length is
> > +greater or equal
> > + to one it means it represents IV, when is set to zero it means J0
> > +is used
> > + directly, in this case 16 bytes of J0 need to be passed.
> > --
> > 2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-04-30 6:59 Akhil Goyal
2019-04-30 6:59 ` Akhil Goyal
@ 2019-05-03 18:09 ` Trahe, Fiona
2019-05-03 18:09 ` Trahe, Fiona
2019-05-04 18:06 ` Liron Himi
1 sibling, 2 replies; 18+ messages in thread
From: Trahe, Fiona @ 2019-05-03 18:09 UTC (permalink / raw)
To: Doherty, Declan, ravi1.kumar, tdu, lironh, walan
Cc: De Lara Guarch, Pablo, dev, Kusztal, ArkadiuszX, Anoob Joseph,
shallyv, akhil.goyal, Trahe, Fiona
Forwarding to maintainers of the following crypto PMDs which may be affected by this:
mvsam
ccp
openssl
Can you review the 19.05 deprecation notice below and if in agreement, ack please - 3 acks are needed
This is the related API change targeted at 19.08:
https://patches.dpdk.org/patch/52886/
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Tuesday, April 30, 2019 7:59 AM
> To: Anoob Joseph <anoobj@marvell.com>; shallyv@marvell.com
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> Hi Anoob/Shally,
>
> Could you please review this patch and provide Ack.
>
> Thanks,
> Akhil
>
>
> >
> >
> > This patch adds deprecation notice of changing iv behaviour
> > when using Galois Counter Mode of operation. Right now IV of
> > all supported sizes can be used.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index ba39c2d..76eb166 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -87,3 +87,9 @@ Deprecation Notices
> > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> > +
> > +* cryptodev: support for using IV with all sizes is added, J0 still can
> > + be used but only when IV length in following structs ``rte_crypto_auth_xform``,
> > + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
> > + to one it means it represents IV, when is set to zero it means J0 is used
> > + directly, in this case 16 bytes of J0 need to be passed.
> > --
> > 2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-05-03 18:09 ` Trahe, Fiona
@ 2019-05-03 18:09 ` Trahe, Fiona
2019-05-04 18:06 ` Liron Himi
1 sibling, 0 replies; 18+ messages in thread
From: Trahe, Fiona @ 2019-05-03 18:09 UTC (permalink / raw)
To: Doherty, Declan, ravi1.kumar, tdu, lironh, walan
Cc: De Lara Guarch, Pablo, dev, Kusztal, ArkadiuszX, Anoob Joseph,
shallyv, akhil.goyal, Trahe, Fiona
Forwarding to maintainers of the following crypto PMDs which may be affected by this:
mvsam
ccp
openssl
Can you review the 19.05 deprecation notice below and if in agreement, ack please - 3 acks are needed
This is the related API change targeted at 19.08:
https://patches.dpdk.org/patch/52886/
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Tuesday, April 30, 2019 7:59 AM
> To: Anoob Joseph <anoobj@marvell.com>; shallyv@marvell.com
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice
>
> Hi Anoob/Shally,
>
> Could you please review this patch and provide Ack.
>
> Thanks,
> Akhil
>
>
> >
> >
> > This patch adds deprecation notice of changing iv behaviour
> > when using Galois Counter Mode of operation. Right now IV of
> > all supported sizes can be used.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index ba39c2d..76eb166 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -87,3 +87,9 @@ Deprecation Notices
> > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> > +
> > +* cryptodev: support for using IV with all sizes is added, J0 still can
> > + be used but only when IV length in following structs ``rte_crypto_auth_xform``,
> > + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
> > + to one it means it represents IV, when is set to zero it means J0 is used
> > + directly, in this case 16 bytes of J0 need to be passed.
> > --
> > 2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
@ 2019-04-30 6:59 Akhil Goyal
2019-04-30 6:59 ` Akhil Goyal
2019-05-03 18:09 ` Trahe, Fiona
0 siblings, 2 replies; 18+ messages in thread
From: Akhil Goyal @ 2019-04-30 6:59 UTC (permalink / raw)
To: Anoob Joseph, shallyv
Cc: fiona.trahe, pablo.de.lara.guarch, dev, Arek Kusztal
Hi Anoob/Shally,
Could you please review this patch and provide Ack.
Thanks,
Akhil
>
>
> This patch adds deprecation notice of changing iv behaviour
> when using Galois Counter Mode of operation. Right now IV of
> all supported sizes can be used.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index ba39c2d..76eb166 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -87,3 +87,9 @@ Deprecation Notices
> * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> +
> +* cryptodev: support for using IV with all sizes is added, J0 still can
> + be used but only when IV length in following structs ``rte_crypto_auth_xform``,
> + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
> + to one it means it represents IV, when is set to zero it means J0 is used
> + directly, in this case 16 bytes of J0 need to be passed.
> --
> 2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice
2019-04-30 6:59 Akhil Goyal
@ 2019-04-30 6:59 ` Akhil Goyal
2019-05-03 18:09 ` Trahe, Fiona
1 sibling, 0 replies; 18+ messages in thread
From: Akhil Goyal @ 2019-04-30 6:59 UTC (permalink / raw)
To: Anoob Joseph, shallyv
Cc: fiona.trahe, pablo.de.lara.guarch, dev, Arek Kusztal
Hi Anoob/Shally,
Could you please review this patch and provide Ack.
Thanks,
Akhil
>
>
> This patch adds deprecation notice of changing iv behaviour
> when using Galois Counter Mode of operation. Right now IV of
> all supported sizes can be used.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index ba39c2d..76eb166 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -87,3 +87,9 @@ Deprecation Notices
> * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
> structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> +
> +* cryptodev: support for using IV with all sizes is added, J0 still can
> + be used but only when IV length in following structs ``rte_crypto_auth_xform``,
> + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
> + to one it means it represents IV, when is set to zero it means J0 is used
> + directly, in this case 16 bytes of J0 need to be passed.
> --
> 2.1.0
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2019-05-13 21:25 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 7:41 [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice Arek Kusztal
2019-04-17 7:41 ` Arek Kusztal
2019-04-17 11:32 ` Trahe, Fiona
2019-04-17 11:32 ` Trahe, Fiona
2019-05-13 21:25 ` Thomas Monjalon
2019-05-13 21:25 ` Thomas Monjalon
2019-05-08 8:23 ` De Lara Guarch, Pablo
2019-05-08 8:23 ` De Lara Guarch, Pablo
2019-05-09 9:03 ` Akhil Goyal
2019-05-09 9:03 ` Akhil Goyal
2019-05-09 11:31 ` Anoob Joseph
2019-05-09 11:31 ` Anoob Joseph
2019-04-30 6:59 Akhil Goyal
2019-04-30 6:59 ` Akhil Goyal
2019-05-03 18:09 ` Trahe, Fiona
2019-05-03 18:09 ` Trahe, Fiona
2019-05-04 18:06 ` Liron Himi
2019-05-04 18:06 ` Liron Himi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).