From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 875AC1B6F7 for ; Wed, 17 Apr 2019 17:33:02 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 08:33:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,362,1549958400"; d="scan'208";a="162439516" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga002.fm.intel.com with ESMTP; 17 Apr 2019 08:33:00 -0700 Date: Wed, 17 Apr 2019 23:27:15 +0800 From: Ye Xiaolong To: David Marchand Cc: dev , Ferruh Yigit , Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190417152715.GA2139@intel.com> References: <20190417134946.1250-1-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4 0/4] some fixes for AF_XDP pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 15:33:02 -0000 On 04/17, David Marchand wrote: >On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye wrote: > >> This patchset provides some fixes to af_xdp pmd, at first, I just added >> a simple error handling when Tx queue allocation fails, then David >> suggested a better way to do it and pointed out the inconsistent issue >> of reserve/submit ops (for Tx queue) and peek/release ops (for Rx >> queue), the third patch addressed this. >> >> v4 changes: >> >> - remove unnecessary mtu valid check in eth_dev_mtu_set >> - add Reported-by and Reviewed-by tags of David >> >> v3 changes: >> >> - address David's review comments >> - add one patch to specify the mtu range >> - add one fix patch for typo >> >> v2 changes: >> >> - adopt David's suggestion to refactor the code >> >> Xiaolong Ye (4): >> net/af_xdp: enqueue buf ring when allocate Tx queue fails >> net/af_xdp: specify minimal and maximal MTU >> net/af_xdp: make reserve/submit peek/release consistent >> net/af_xdp: fix typos in Rx function >> >> drivers/net/af_xdp/rte_eth_af_xdp.c | 87 +++++++++++++++-------------- >> 1 file changed, 46 insertions(+), 41 deletions(-) >> >> -- >> 2.17.1 >> >> >LGTM. >Thanks Xiaolong. Thanks a lot for your guidance. :) > > >-- >David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3CA86A00E6 for ; Wed, 17 Apr 2019 17:33:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07A311B70D; Wed, 17 Apr 2019 17:33:04 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 875AC1B6F7 for ; Wed, 17 Apr 2019 17:33:02 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 08:33:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,362,1549958400"; d="scan'208";a="162439516" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga002.fm.intel.com with ESMTP; 17 Apr 2019 08:33:00 -0700 Date: Wed, 17 Apr 2019 23:27:15 +0800 From: Ye Xiaolong To: David Marchand Cc: dev , Ferruh Yigit , Qi Zhang , Karlsson Magnus , Topel Bjorn Message-ID: <20190417152715.GA2139@intel.com> References: <20190417134946.1250-1-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4 0/4] some fixes for AF_XDP pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417152715.od4AE1cvTIafObjkE2IlUlvCqaJIhJhsZf-AFB3HDl0@z> On 04/17, David Marchand wrote: >On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye wrote: > >> This patchset provides some fixes to af_xdp pmd, at first, I just added >> a simple error handling when Tx queue allocation fails, then David >> suggested a better way to do it and pointed out the inconsistent issue >> of reserve/submit ops (for Tx queue) and peek/release ops (for Rx >> queue), the third patch addressed this. >> >> v4 changes: >> >> - remove unnecessary mtu valid check in eth_dev_mtu_set >> - add Reported-by and Reviewed-by tags of David >> >> v3 changes: >> >> - address David's review comments >> - add one patch to specify the mtu range >> - add one fix patch for typo >> >> v2 changes: >> >> - adopt David's suggestion to refactor the code >> >> Xiaolong Ye (4): >> net/af_xdp: enqueue buf ring when allocate Tx queue fails >> net/af_xdp: specify minimal and maximal MTU >> net/af_xdp: make reserve/submit peek/release consistent >> net/af_xdp: fix typos in Rx function >> >> drivers/net/af_xdp/rte_eth_af_xdp.c | 87 +++++++++++++++-------------- >> 1 file changed, 46 insertions(+), 41 deletions(-) >> >> -- >> 2.17.1 >> >> >LGTM. >Thanks Xiaolong. Thanks a lot for your guidance. :) > > >-- >David Marchand