* Re: [dpdk-dev] [PATCH] net/iavf: fix info get
2019-04-17 16:08 [dpdk-dev] [PATCH] net/iavf: fix info get Qiming Yang
@ 2019-04-17 8:46 ` David Marchand
2019-04-17 8:46 ` David Marchand
2019-04-17 12:34 ` Ferruh Yigit
2019-04-17 16:08 ` Qiming Yang
1 sibling, 2 replies; 6+ messages in thread
From: David Marchand @ 2019-04-17 8:46 UTC (permalink / raw)
To: Qiming Yang; +Cc: dev, dpdk stable
On Wed, Apr 17, 2019 at 10:41 AM Qiming Yang <qiming.yang@intel.com> wrote:
> iavf driver reset the dev_info structure. This action will clear
> the setting in core library. This patch fix that issue.
>
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
>
"Cc: stable@dpdk.org" is supposed to be part of the commitlog.
See
http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
> drivers/net/iavf/iavf_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c
> b/drivers/net/iavf/iavf_ethdev.c
> index 846e604..7825cbc 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> {
> struct iavf_info *vf =
> IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>
> - memset(dev_info, 0, sizeof(*dev_info));
> dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
> dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
> dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN;
> --
> 2.9.5
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/iavf: fix info get
2019-04-17 8:46 ` David Marchand
@ 2019-04-17 8:46 ` David Marchand
2019-04-17 12:34 ` Ferruh Yigit
1 sibling, 0 replies; 6+ messages in thread
From: David Marchand @ 2019-04-17 8:46 UTC (permalink / raw)
To: Qiming Yang; +Cc: dev, dpdk stable
On Wed, Apr 17, 2019 at 10:41 AM Qiming Yang <qiming.yang@intel.com> wrote:
> iavf driver reset the dev_info structure. This action will clear
> the setting in core library. This patch fix that issue.
>
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
>
"Cc: stable@dpdk.org" is supposed to be part of the commitlog.
See
http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
> drivers/net/iavf/iavf_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c
> b/drivers/net/iavf/iavf_ethdev.c
> index 846e604..7825cbc 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
> {
> struct iavf_info *vf =
> IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
>
> - memset(dev_info, 0, sizeof(*dev_info));
> dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
> dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
> dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN;
> --
> 2.9.5
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/iavf: fix info get
2019-04-17 8:46 ` David Marchand
2019-04-17 8:46 ` David Marchand
@ 2019-04-17 12:34 ` Ferruh Yigit
2019-04-17 12:34 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2019-04-17 12:34 UTC (permalink / raw)
To: David Marchand, Qiming Yang; +Cc: dev, dpdk stable
On 4/17/2019 9:46 AM, David Marchand wrote:
> On Wed, Apr 17, 2019 at 10:41 AM Qiming Yang <qiming.yang@intel.com> wrote:
>
>> iavf driver reset the dev_info structure. This action will clear
>> the setting in core library. This patch fix that issue.
>>
>> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
>>
> "Cc: stable@dpdk.org" is supposed to be part of the commitlog.
>
> See
> http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported
>
>
>> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/iavf: fix info get
2019-04-17 12:34 ` Ferruh Yigit
@ 2019-04-17 12:34 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-04-17 12:34 UTC (permalink / raw)
To: David Marchand, Qiming Yang; +Cc: dev, dpdk stable
On 4/17/2019 9:46 AM, David Marchand wrote:
> On Wed, Apr 17, 2019 at 10:41 AM Qiming Yang <qiming.yang@intel.com> wrote:
>
>> iavf driver reset the dev_info structure. This action will clear
>> the setting in core library. This patch fix that issue.
>>
>> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
>>
> "Cc: stable@dpdk.org" is supposed to be part of the commitlog.
>
> See
> http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported
>
>
>> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] net/iavf: fix info get
@ 2019-04-17 16:08 Qiming Yang
2019-04-17 8:46 ` David Marchand
2019-04-17 16:08 ` Qiming Yang
0 siblings, 2 replies; 6+ messages in thread
From: Qiming Yang @ 2019-04-17 16:08 UTC (permalink / raw)
To: dev; +Cc: stable, Qiming Yang
iavf driver reset the dev_info structure. This action will clear
the setting in core library. This patch fix that issue.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/iavf/iavf_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 846e604..7825cbc 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
{
struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
- memset(dev_info, 0, sizeof(*dev_info));
dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN;
--
2.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] net/iavf: fix info get
2019-04-17 16:08 [dpdk-dev] [PATCH] net/iavf: fix info get Qiming Yang
2019-04-17 8:46 ` David Marchand
@ 2019-04-17 16:08 ` Qiming Yang
1 sibling, 0 replies; 6+ messages in thread
From: Qiming Yang @ 2019-04-17 16:08 UTC (permalink / raw)
To: dev; +Cc: stable, Qiming Yang
iavf driver reset the dev_info structure. This action will clear
the setting in core library. This patch fix that issue.
Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
drivers/net/iavf/iavf_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 846e604..7825cbc 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -498,7 +498,6 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
{
struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
- memset(dev_info, 0, sizeof(*dev_info));
dev_info->max_rx_queues = vf->vsi_res->num_queue_pairs;
dev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;
dev_info->min_rx_bufsize = IAVF_BUF_SIZE_MIN;
--
2.9.5
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-17 12:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17 16:08 [dpdk-dev] [PATCH] net/iavf: fix info get Qiming Yang
2019-04-17 8:46 ` David Marchand
2019-04-17 8:46 ` David Marchand
2019-04-17 12:34 ` Ferruh Yigit
2019-04-17 12:34 ` Ferruh Yigit
2019-04-17 16:08 ` Qiming Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).