From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140079.outbound.protection.outlook.com [40.107.14.79]) by dpdk.org (Postfix) with ESMTP id 832A41B9C4 for ; Thu, 18 Apr 2019 14:06:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e8BGmvxJo6AD61Z3KMwmKztdljxJuu2z9Qcxwbq3B6c=; b=olueg9ws4T0Hp6jG4u+Rhr+5khdsieF4v+41/AfaskIWNrc5+pxel5zgYPxtjkbcfoihFH6Tki9LhVpQUkwe6KESJVLzV6BN1vN6obZUwgmAgTercHMU/Nv581be53Nn5Rea2jA6pPSa5mRFI/j/l8UcfMiGZjvGqWWkMdDHAb0= Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com (52.133.40.151) by AM0PR0502MB3843.eurprd05.prod.outlook.com (52.133.47.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Thu, 18 Apr 2019 12:06:47 +0000 Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::7da6:9e13:922a:9d88]) by AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::7da6:9e13:922a:9d88%5]) with mapi id 15.20.1813.013; Thu, 18 Apr 2019 12:06:47 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH v2 1/9] net/mlx5: fix translate vport function name Thread-Index: AQHU9doRGJkTY5bFikCQpxoXwJ+Tb6ZB0qUA Date: Thu, 18 Apr 2019 12:06:46 +0000 Message-ID: <20190418120637.GG31179@mtidpdk.mti.labs.mlnx> References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555586930-109097-1-git-send-email-orika@mellanox.com> <1555586930-109097-2-git-send-email-orika@mellanox.com> In-Reply-To: <1555586930-109097-2-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR01CA0061.prod.exchangelabs.com (2603:10b6:a03:94::38) To AM0PR0502MB3971.eurprd05.prod.outlook.com (2603:10a6:208:11::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17645751-93fb-469b-0260-08d6c3f6545c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3843; x-ms-traffictypediagnostic: AM0PR0502MB3843: x-microsoft-antispam-prvs: x-forefront-prvs: 0011612A55 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(136003)(346002)(396003)(39860400002)(199004)(189003)(71200400001)(14454004)(71190400001)(229853002)(6636002)(33656002)(6436002)(6486002)(99286004)(305945005)(1076003)(52116002)(6862004)(53936002)(54906003)(9686003)(316002)(6512007)(6246003)(478600001)(97736004)(25786009)(7736002)(4326008)(76176011)(476003)(386003)(5660300002)(102836004)(6506007)(6116002)(66066001)(3846002)(86362001)(81166006)(446003)(81156014)(8676002)(2906002)(8936002)(11346002)(186003)(486006)(26005)(256004)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3843; H:AM0PR0502MB3971.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: C4p6fHz3bhz1PUhsqDjASjnKhrDYbS8sRt6Y9Jmx3/lzEWETRmDcm3hyADisslohEGKTGWt4lHOjwskr/7E1J0F6yH+zCZJG1GpSbX7x/w7e3TtQl0o1FfeX6WArM3UlcWLHHENj3W7DMDtpvO4rw86MYByrn3tk0Z1maeYoXgjdQwHDhd5yL8eNxwZkF0+OGhwvhSfXEvH+0O92P8NCO8L9ZLhUqUs2kTVdceAFaJ7Nj4jevzjjiXrjRi4aIZ3CKjcmMj2Yy19PN9uASTLykWTo/AtXUCQoBAX9VtGjdYThdv8dTHgQ8h7dnWVRjMe8mCEMITmAxoKTh2vy0Sds1RJWdM2XGoNORTLiiyVRvkfwvvw3nH8uUs89IZwyHKG/Fspo0tZkmpXMrm/ZBN7t7RYRKPE6A+2bRM6oYcdNIXM= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17645751-93fb-469b-0260-08d6c3f6545c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 12:06:46.7123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3843 Subject: Re: [dpdk-dev] [PATCH v2 1/9] net/mlx5: fix translate vport function name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 12:06:48 -0000 On Thu, Apr 18, 2019 at 11:28:42AM +0000, Ori Kam wrote: > Modify the translate vport function to match other translate items > naming convestions. >=20 > Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rul= es") > Cc: viacheslavo@mellanox.com >=20 > Signed-off-by: Ori Kam You were supposed to change the name to flow_dv_translate_item_src_vport, b= ut that's fine. Acked-by: Yongseok Koh > --- > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5_flow_dv.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow= _dv.c > index 04ab3d6..1e25e0b 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -3087,8 +3087,8 @@ struct field_modify_info modify_tcp[] =3D { > * Mask > */ > static void > -flow_dv_translate_source_vport(void *matcher, void *key, > - int16_t port, uint16_t mask) > +flow_dv_translate_item_source_vport(void *matcher, void *key, > + int16_t port, uint16_t mask) > { > void *misc_m =3D MLX5_ADDR_OF(fte_match_param, matcher, misc_parameters= ); > void *misc_v =3D MLX5_ADDR_OF(fte_match_param, key, misc_parameters); > @@ -3492,10 +3492,10 @@ struct field_modify_info modify_tcp[] =3D { > * Add matching on source vport index only > * for ingress rules in E-Switch configurations. > */ > - flow_dv_translate_source_vport(matcher.mask.buf, > - dev_flow->dv.value.buf, > - priv->vport_id, > - 0xffff); > + flow_dv_translate_item_source_vport(matcher.mask.buf, > + dev_flow->dv.value.buf, > + priv->vport_id, > + 0xffff); > } > for (; items->type !=3D RTE_FLOW_ITEM_TYPE_END; items++) { > int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > --=20 > 1.8.3.1 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1713EA00E6 for ; Thu, 18 Apr 2019 14:06:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E331C1B9CD; Thu, 18 Apr 2019 14:06:49 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140079.outbound.protection.outlook.com [40.107.14.79]) by dpdk.org (Postfix) with ESMTP id 832A41B9C4 for ; Thu, 18 Apr 2019 14:06:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e8BGmvxJo6AD61Z3KMwmKztdljxJuu2z9Qcxwbq3B6c=; b=olueg9ws4T0Hp6jG4u+Rhr+5khdsieF4v+41/AfaskIWNrc5+pxel5zgYPxtjkbcfoihFH6Tki9LhVpQUkwe6KESJVLzV6BN1vN6obZUwgmAgTercHMU/Nv581be53Nn5Rea2jA6pPSa5mRFI/j/l8UcfMiGZjvGqWWkMdDHAb0= Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com (52.133.40.151) by AM0PR0502MB3843.eurprd05.prod.outlook.com (52.133.47.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.19; Thu, 18 Apr 2019 12:06:47 +0000 Received: from AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::7da6:9e13:922a:9d88]) by AM0PR0502MB3971.eurprd05.prod.outlook.com ([fe80::7da6:9e13:922a:9d88%5]) with mapi id 15.20.1813.013; Thu, 18 Apr 2019 12:06:47 +0000 From: Yongseok Koh To: Ori Kam CC: Shahaf Shuler , Matan Azrad , Slava Ovsiienko , Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [PATCH v2 1/9] net/mlx5: fix translate vport function name Thread-Index: AQHU9doRGJkTY5bFikCQpxoXwJ+Tb6ZB0qUA Date: Thu, 18 Apr 2019 12:06:46 +0000 Message-ID: <20190418120637.GG31179@mtidpdk.mti.labs.mlnx> References: <1555276357-4892-1-git-send-email-orika@mellanox.com> <1555586930-109097-1-git-send-email-orika@mellanox.com> <1555586930-109097-2-git-send-email-orika@mellanox.com> In-Reply-To: <1555586930-109097-2-git-send-email-orika@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR01CA0061.prod.exchangelabs.com (2603:10b6:a03:94::38) To AM0PR0502MB3971.eurprd05.prod.outlook.com (2603:10a6:208:11::23) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17645751-93fb-469b-0260-08d6c3f6545c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3843; x-ms-traffictypediagnostic: AM0PR0502MB3843: x-microsoft-antispam-prvs: x-forefront-prvs: 0011612A55 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(136003)(346002)(396003)(39860400002)(199004)(189003)(71200400001)(14454004)(71190400001)(229853002)(6636002)(33656002)(6436002)(6486002)(99286004)(305945005)(1076003)(52116002)(6862004)(53936002)(54906003)(9686003)(316002)(6512007)(6246003)(478600001)(97736004)(25786009)(7736002)(4326008)(76176011)(476003)(386003)(5660300002)(102836004)(6506007)(6116002)(66066001)(3846002)(86362001)(81166006)(446003)(81156014)(8676002)(2906002)(8936002)(11346002)(186003)(486006)(26005)(256004)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3843; H:AM0PR0502MB3971.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: C4p6fHz3bhz1PUhsqDjASjnKhrDYbS8sRt6Y9Jmx3/lzEWETRmDcm3hyADisslohEGKTGWt4lHOjwskr/7E1J0F6yH+zCZJG1GpSbX7x/w7e3TtQl0o1FfeX6WArM3UlcWLHHENj3W7DMDtpvO4rw86MYByrn3tk0Z1maeYoXgjdQwHDhd5yL8eNxwZkF0+OGhwvhSfXEvH+0O92P8NCO8L9ZLhUqUs2kTVdceAFaJ7Nj4jevzjjiXrjRi4aIZ3CKjcmMj2Yy19PN9uASTLykWTo/AtXUCQoBAX9VtGjdYThdv8dTHgQ8h7dnWVRjMe8mCEMITmAxoKTh2vy0Sds1RJWdM2XGoNORTLiiyVRvkfwvvw3nH8uUs89IZwyHKG/Fspo0tZkmpXMrm/ZBN7t7RYRKPE6A+2bRM6oYcdNIXM= Content-Type: text/plain; charset="UTF-8" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17645751-93fb-469b-0260-08d6c3f6545c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2019 12:06:46.7123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3843 Subject: Re: [dpdk-dev] [PATCH v2 1/9] net/mlx5: fix translate vport function name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418120646.0piQGQqgE2Bff4IE1hTyaXJnW5WsmKQZ0phiva2wfdQ@z> On Thu, Apr 18, 2019 at 11:28:42AM +0000, Ori Kam wrote: > Modify the translate vport function to match other translate items > naming convestions. >=20 > Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rul= es") > Cc: viacheslavo@mellanox.com >=20 > Signed-off-by: Ori Kam You were supposed to change the name to flow_dv_translate_item_src_vport, b= ut that's fine. Acked-by: Yongseok Koh > --- > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5_flow_dv.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow= _dv.c > index 04ab3d6..1e25e0b 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -3087,8 +3087,8 @@ struct field_modify_info modify_tcp[] =3D { > * Mask > */ > static void > -flow_dv_translate_source_vport(void *matcher, void *key, > - int16_t port, uint16_t mask) > +flow_dv_translate_item_source_vport(void *matcher, void *key, > + int16_t port, uint16_t mask) > { > void *misc_m =3D MLX5_ADDR_OF(fte_match_param, matcher, misc_parameters= ); > void *misc_v =3D MLX5_ADDR_OF(fte_match_param, key, misc_parameters); > @@ -3492,10 +3492,10 @@ struct field_modify_info modify_tcp[] =3D { > * Add matching on source vport index only > * for ingress rules in E-Switch configurations. > */ > - flow_dv_translate_source_vport(matcher.mask.buf, > - dev_flow->dv.value.buf, > - priv->vport_id, > - 0xffff); > + flow_dv_translate_item_source_vport(matcher.mask.buf, > + dev_flow->dv.value.buf, > + priv->vport_id, > + 0xffff); > } > for (; items->type !=3D RTE_FLOW_ITEM_TYPE_END; items++) { > int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > --=20 > 1.8.3.1 >=20