From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F0EE7A00E6 for ; Thu, 18 Apr 2019 17:23:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2ACAE1BBDE; Thu, 18 Apr 2019 17:23:58 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 486231BBD0; Thu, 18 Apr 2019 17:23:55 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2019 08:23:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,366,1549958400"; d="scan'208";a="292639444" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga004.jf.intel.com with ESMTP; 18 Apr 2019 08:23:53 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.82]) by IRSMSX106.ger.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0415.000; Thu, 18 Apr 2019 16:23:52 +0100 From: "Iremonger, Bernard" To: "Iremonger, Bernard" , Akhil Goyal , "dev@dpdk.org" , "Ananyev, Konstantin" CC: "stable@dpdk.org" Thread-Topic: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto Thread-Index: AdT17cOXTZn2OC8PMkWGDcNcFHiBSwABq5WwAAFlbyA= Date: Thu, 18 Apr 2019 15:23:51 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D8B72B@IRSMSX108.ger.corp.intel.com> References: <8CEF83825BEC744B83065625E567D7C260D8B6D9@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D8B6D9@IRSMSX108.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWVmMGZkZWYtOGIxZS00YjRmLTlkNDEtYjgyNzVkMmJmMDA5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUXN3bUVxZlwvbWFnTDVIN2tIQ3hjS2tjYk02RXRIdXgxMmJuRDczcWMrMmxXbnpzSjdHQXBqcXVmMzhtemVCb1IifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418152351.tc0ZLHHic4UKMXJUHOl3jdUtv3wJjEe6mpcpfMe16Bs@z> Hi Akhil, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Iremonger, Bernard > Sent: Thursday, April 18, 2019 3:59 PM > To: Akhil Goyal ; dev@dpdk.org; Ananyev, > Konstantin > Cc: stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st pack= et > dropped for inline crypto >=20 > Hi Akhil, >=20 > >=20 > > Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet > > dropped for inline crypto >=20 > > > > + if (sa->type =3D=3D > > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) { > > > + ctx =3D (struct rte_security_ctx *) > > > + rte_eth_dev_get_sec_ctx(sa->portid); > > > > This is breaking the lookaside mode. Ctx was retrieved using the > > ipsec_ctx- > > >tbl struct rte_security_ctx *ctx =3D (struct rte_security_ctx *) > > rte_cryptodev_get_sec_ctx( > > ipsec_ctx->tbl[cdev_id_qp].id); > > > > I am looking into it, but I don't have time left to get it integrated > > in RC2. So this has to be pushed to RC3 >=20 > >=20 > Unfortunately we do not have the HW to test this feature. > What HW are you using to test this? >=20 > Having looked at the code previously > ipsec_ctx->tbl[cdev_id_qp].id turned out to be the port_id. >=20 > So we had expected it to work. >=20 > We will need your help with this. >=20 > Regards, >=20 > Bernard. Just had another look at the 19.05.rc1 code Line 1546 in ipsec-secgw.c:=20 ipsec_ctx->tbl[i].id =3D cdev_id; The id is the cryptodev id, not the port_id Regards, Bernard.