From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9FA7FA00E6 for ; Fri, 19 Apr 2019 12:17:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C5231BB5A; Fri, 19 Apr 2019 12:17:32 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5E2841BB2E; Fri, 19 Apr 2019 12:17:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AFD54263C3; Fri, 19 Apr 2019 06:17:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 06:17:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=g7nUm8NCrfT9JaP/Zj+A05s3waKRLsWRTTmPK6nAJpQ=; b=Px5aqxhCZB7b 1XkXJDdyK2YTOvuSwiA7KVdiV0Ih7giq0DjichT0XCtDzsZUwrp+pMsV/IMeJHG5 dfBrEX5OXS2Oqu47XtwKQyJj32P4iAnvuc+bcuNIHGr/AIX9kWN3KHmsQSa+3vFQ W3ZP9oOwaOIMYBPnUUtRj7Qh8/XUveA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=g7nUm8NCrfT9JaP/Zj+A05s3waKRLsWRTTmPK6nAJ pQ=; b=oxbfPP3lFymbdgXgrdP+/ycPHOQ4skhIKsQQVU8HuxThaXBGnbDwSwrg3 QTWL9Mnvz1M76oO0CBV806fo5/pYq9Ey0EMdRVRC9l8Vhx3yg01dMF/VhiYDq4SF 7DSTQrNMk4aOBdaq5EGMY9oNSjG7l8hZ4wpiUNiPXXzXmSE0iC5GCdGN4LioZQ1N gqOgt5y83i5I3E3rzYNNQQNa9DIkGGrK15cSjz92WvvqAta+/2pRCUUgx2/GUHsU lfGepG8hPvDL6kgkDRUI1INiWhvUnmban1ubcsbAaZLL2kR98t6OJhYvBx1Lbb+n zWQKQTqsnbvywKEVNH0lVyMRC9jrg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepohhpvghnshhushgvrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudek geenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DD502E4561; Fri, 19 Apr 2019 06:17:27 -0400 (EDT) From: Thomas Monjalon To: Tomasz Jozwiak Cc: dev@dpdk.org, stable@dpdk.org, fiona.trahe@intel.com, yskoh@mellanox.com, bruce.richardson@intel.com Date: Fri, 19 Apr 2019 12:17:26 +0200 Message-ID: <4602312.zkvPNgCjdN@xps> In-Reply-To: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com> References: <1555667827-3715-1-git-send-email-tomaszx.jozwiak@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419101726.4N86ZZwgavqqJE24qUvHj-6mnXMJNIv9ltevMvmLLDE@z> Please check my comments below: 19/04/2019 11:57, Tomasz Jozwiak: > Fixed the compilation error on gcc (GCC) > 4.8.5 20150623 (Red Hat 4.8.5-28) It is seen with more compilers: https://build.opensuse.org/project/show/home:bluca:dpdk Please add the log of the error. > Fixes: 355b02eedc65 ("test/compress: add max mbuf size test case") > Cc: stable@dpdk.org It is a recent commit, no need to Cc stable for backport. > Signed-off-by: Tomasz Jozwiak > --- > app/test/test_compressdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c > index 404b98f..603eeea 100644 > --- a/app/test/test_compressdev.c > +++ b/app/test/test_compressdev.c > @@ -1948,6 +1948,7 @@ test_compressdev_deflate_stateless_dynamic_big(void) > struct comp_testsuite_params *ts_params = &testsuite_params; > uint16_t i = 0; > int ret = TEST_SUCCESS; > + int j = 0; > const struct rte_compressdev_capabilities *capab; > char *test_buffer = NULL; > > @@ -1989,8 +1990,8 @@ test_compressdev_deflate_stateless_dynamic_big(void) > > /* fill the buffer with data based on rand. data */ > srand(BIG_DATA_TEST_SIZE); > - for (uint32_t i = 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > - test_buffer[i] = (uint8_t)(rand() % ((uint8_t)-1)) | 1; > + for (j = 0; j < BIG_DATA_TEST_SIZE - 1; ++j) > + test_buffer[j] = (uint8_t)(rand() % ((uint8_t)-1)) | 1; > > test_buffer[BIG_DATA_TEST_SIZE-1] = 0; > int_data.buf_idx = &i; What is supposed to be "i"? It is initialized at 0 and never touched.