DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Nirranjan Kirubaharan <nirranjan@chelsio.com>,
	Indranil Choudhury <indranil@chelsio.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Kevin Traynor <ktraynor@redhat.com>,
	Luca Boccassi <bluca@debian.org>,
	Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/cxgbe: update Chelsio T5/T6 NIC device ids
Date: Fri, 19 Apr 2019 17:40:59 +0530	[thread overview]
Message-ID: <20190419121054.GB12160@chelsio.com> (raw)
Message-ID: <20190419121059.9_bBkOMOBGN-EC4TuXe401dRfM4ePvvSQRQzVhmWIYo@z> (raw)
In-Reply-To: <21fc74df-e565-64fd-1f58-03bb3512a0ea@intel.com>

On Friday, April 04/19/19, 2019 at 16:48:55 +0530, Ferruh Yigit wrote:
> On 4/19/2019 10:49 AM, Rahul Lakkireddy wrote:
> > Hi Ferruh,
> > 
> > On Friday, April 04/19/19, 2019 at 15:00:32 +0530, Ferruh Yigit wrote:
> >> On 4/19/2019 10:22 AM, Rahul Lakkireddy wrote:
> >>> Fixes: 04868e5bfddd ("net/cxgbe: add support to run Chelsio T6 cards")
> >>
> >> Why this is a fix, isn't this just adding new device ids?
> >>
> >>
> >>> Cc: stable@dpdk.org
> >>
> >> What about keeping 'stable' tag to request the backport but remove the fix?
> >>
> > 
> > It's fixing probe for these new devices. Let me know if this particular
> > case doesn't require the fixes line and I will send v2 with only the
> > stable tag.
> 
> No need a v2, if you are agree I can remove while merging.
> 
> The commit is not fixing any old code in DPDK, if the intention of making this
> patch a fix is to backport the patch, we can do same via stable tag, fix not needed.
> If these devices were ready at that time, in 17.08, but forgotten in that commit
> to be added, than I see the fix but this looks unlikely since it is almost two
> years ago.
> 

Ok, please remove the fixes line during merge.

> > 
> >>>
> >>> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> >>
> > 

Thanks,
Rahul

  parent reply	other threads:[~2019-04-19 12:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19  9:22 Rahul Lakkireddy
2019-04-19  9:22 ` Rahul Lakkireddy
2019-04-19  9:30 ` Ferruh Yigit
2019-04-19  9:30   ` Ferruh Yigit
2019-04-19  9:49   ` Rahul Lakkireddy
2019-04-19  9:49     ` Rahul Lakkireddy
2019-04-19 11:18     ` Ferruh Yigit
2019-04-19 11:18       ` Ferruh Yigit
2019-04-19 12:10       ` Rahul Lakkireddy [this message]
2019-04-19 12:10         ` Rahul Lakkireddy
2019-04-19 12:24 ` Ferruh Yigit
2019-04-19 12:24   ` Ferruh Yigit
2019-05-09  8:59 ` Kevin Traynor
2019-05-09  8:59   ` Kevin Traynor
2019-05-09 10:03   ` Rahul Lakkireddy
2019-05-09 10:03     ` Rahul Lakkireddy
2019-05-09 10:38     ` Kevin Traynor
2019-05-09 10:38       ` Kevin Traynor
2019-05-09 11:11       ` Rahul Lakkireddy
2019-05-09 11:11         ` Rahul Lakkireddy
2019-05-09 11:55         ` Kevin Traynor
2019-05-09 11:55           ` Kevin Traynor
2019-05-09 12:19           ` Rahul Lakkireddy
2019-05-09 12:19             ` Rahul Lakkireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190419121054.GB12160@chelsio.com \
    --to=rahul.lakkireddy@chelsio.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=indranil@chelsio.com \
    --cc=ktraynor@redhat.com \
    --cc=nirranjan@chelsio.com \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).