From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 49424A00E6
for <public@inbox.dpdk.org>; Fri, 19 Apr 2019 14:12:59 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 89EB81BBF2;
Fri, 19 Apr 2019 14:12:58 +0200 (CEST)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id DE70F1B5A7;
Fri, 19 Apr 2019 14:12:56 +0200 (CEST)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
19 Apr 2019 05:12:42 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,369,1549958400"; d="scan'208";a="152203882"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.220.103])
by orsmga002.jf.intel.com with SMTP; 19 Apr 2019 05:12:40 -0700
Received: by (sSMTP sendmail emulation); Fri, 19 Apr 2019 13:12:39 +0100
Date: Fri, 19 Apr 2019 13:12:39 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Pablo de Lara <pablo.de.lara.guarch@intel.com>,
dpdk stable <stable@dpdk.org>
Message-ID: <20190419121239.GA1843@bricha3-MOBL.ger.corp.intel.com>
References: <20190419120327.29752-1-bruce.richardson@intel.com>
<CAJFAV8y9OjwGwUD-N2uqFgyZTEMGDvpwnX=KBCr+k+K7jfr0vA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <CAJFAV8y9OjwGwUD-N2uqFgyZTEMGDvpwnX=KBCr+k+K7jfr0vA@mail.gmail.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix missing header
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190419121239.tAUkhW8toN6x8es3fpSNAnBaaDiMtGU4F6gIgCmPKws@z>
On Fri, Apr 19, 2019 at 02:09:51PM +0200, David Marchand wrote:
> nit: "test/compress:" for the title prefix ?
maybe so, half the time I never know what to prefix autotest stuff like
this with! :-) Thomas, please fix on apply, if possible.
> On Fri, Apr 19, 2019 at 2:03 PM Bruce Richardson
> <[1]bruce.richardson@intel.com> wrote:
>
> Build of test_compressdev.c fails on FreeBSD due to the missing
> include of unistd.h, to provide the function usleep.
> Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
> Cc: [2]pablo.de.lara.guarch@intel.com
> Cc: [3]stable@dpdk.org
> Signed-off-by: Bruce Richardson <[4]bruce.richardson@intel.com>
> ---
> I sent this previously, but I don't think it made the public list,
> so resending.
> Apologies to anyone who gets this twice!
> ---
> app/test/test_compressdev.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/app/test/test_compressdev.c
> b/app/test/test_compressdev.c
> index 404b98f60..121514af5 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -5,6 +5,7 @@
> #include <zlib.h>
> #include <math.h>
> #include <stdlib.h>
> +#include <unistd.h>
> #include <rte_cycles.h>
> #include <rte_malloc.h>
> --
> 2.20.1
>
> Tested on FreeBSD 10.4.
> Reviewed-by: David Marchand <[5]david.marchand@redhat.com>
> --
> David Marchand
>
Thanks,
/Bruce