From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 257] ipc: rte_mp_request_sync return 0 on error.
Date: Fri, 19 Apr 2019 16:53:56 +0000 [thread overview]
Message-ID: <bug-257-3@http.bugs.dpdk.org/> (raw)
Message-ID: <20190419165356.XnbReSKXw7bZIENwr4S2LO5oyOVxp2XtPbhGkXK03i0@z> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=257
Bug ID: 257
Summary: ipc: rte_mp_request_sync return 0 on error.
Product: DPDK
Version: 18.11
Hardware: All
OS: All
Status: CONFIRMED
Severity: normal
Priority: Normal
Component: core
Assignee: dev@dpdk.org
Reporter: herakliusz.lipiec@intel.com
Target Milestone: ---
API can return success (0), but reply buffer might be invalid.
There are three code paths that can return a success, but have no (valid)
message.
In case of two I think it should be a failure.
In rte_mp_request_sync there is a call to mp_request_sync which may return 0
with no message in case of:
- failure to send the message on behalf of remote
- the caller not caring about reply message. (this is probably fine)
This is then returned as 0 by rte_mp_request_sync (docs say that it will return
0 on success).
If IPC is disabled rte_mp_request_sync also return 0, but i think it should be
a failure (it did not send anything, it did not received anything because
operation is not supported).
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2019-04-19 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 16:53 bugzilla [this message]
2019-04-19 16:53 ` bugzilla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-257-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).