DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Hunt, David" <david.hunt@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun
Date: Tue, 23 Apr 2019 09:21:16 +0100	[thread overview]
Message-ID: <92c0a8fa-f05b-827b-a34b-5e403dd3177d@intel.com> (raw)
Message-ID: <20190423082116.qml9sGvTbX6oOViZBYiO5MHVjfzu10hZjUhPCNVBVeQ@z> (raw)
In-Reply-To: <2785627.VT4d78UdPe@xps>

Hi Thomas,

On 22/4/2019 10:54 PM, Thomas Monjalon wrote:
> 10/04/2019 14:49, David Hunt:
>> The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,
>> yet the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS,
>> which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to
>> RTE_MAX_LCORE_FREQS.
>>
>> Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")
>>       Coverity issue: 337660
>>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
> It seems to have been fixed in another patch, isn't it?
>

It was not fixed in another patch, although I can see the confusion.

A previous patch made the #defines more consistent, and 
POWER_MGR_MAX_CPUS was changed to RTE_MAX_LCORE on the affected line. 
However, this was later revealed as a coverity issue, and was fixed in 
this patch to be RTE_LCORE_MAX_FREQS, which is the size of the array 
it's trying to index into.

So looking at RC2, this patch is still needed.

Rgds,
Dave.






  parent reply	other threads:[~2019-04-23  8:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-10 12:49 David Hunt
2019-04-10 12:49 ` David Hunt
2019-04-18 15:14 ` Pattan, Reshma
2019-04-18 15:14   ` Pattan, Reshma
2019-04-23 10:26   ` Kevin Traynor
2019-04-23 10:26     ` Kevin Traynor
2019-04-23 10:31     ` Hunt, David
2019-04-23 10:31       ` Hunt, David
2019-04-23 10:42       ` Kevin Traynor
2019-04-23 10:42         ` Kevin Traynor
2019-04-22 21:54 ` Thomas Monjalon
2019-04-22 21:54   ` Thomas Monjalon
2019-04-23  8:21   ` Hunt, David [this message]
2019-04-23  8:21     ` Hunt, David
2019-04-23  8:33     ` Thomas Monjalon
2019-04-23  8:33       ` Thomas Monjalon
2019-04-23  8:35       ` Hunt, David
2019-04-23  8:35         ` Hunt, David
2019-04-23  8:53 ` [dpdk-dev] [PATCH v2] " David Hunt
2019-04-23  8:53   ` David Hunt
2019-04-26  8:42   ` [dpdk-dev] [PATCH v3] " David Hunt
2019-04-26  8:42     ` David Hunt
2019-05-02 23:38     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-02 23:38       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92c0a8fa-f05b-827b-a34b-5e403dd3177d@intel.com \
    --to=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).