From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 35FAAA05D3
	for <public@inbox.dpdk.org>; Tue, 23 Apr 2019 10:45:10 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id CE2101B4E3;
	Tue, 23 Apr 2019 10:45:08 +0200 (CEST)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com
 [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id BEAE01B4D8;
 Tue, 23 Apr 2019 10:45:06 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 2D6FD37B;
 Tue, 23 Apr 2019 04:45:05 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 23 Apr 2019 04:45:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=2yZKwzCdNs5wqUdhwouBzGAOwZg5bWCpGwz+GI3NyDs=; b=AMbI6zKYzAL0
 J85zOEc34TrnYCe+MXO6Znzt7B313KNw/CyD7IWhyzsbvrtfHQxDqBV97CqxAi8D
 QG6Bgu4M7pjzi8R3vDg/icC3+Krg7YKUEA1juZ25iXPH0Q3KKU7fpj6M1EW4/BwU
 HJRaZCEPfBc76fyu5jBR6kjpSPiNI+8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=2yZKwzCdNs5wqUdhwouBzGAOwZg5bWCpGwz+GI3Ny
 Ds=; b=I/sznUaIYjAF42HkBU7jKLe9/N0jOagHOUpzW9vOfGqgiBmvayCe+qhYO
 VgVJUnCqm2tjcTeuE/Jvaj6Qf3AbvD+HXt8nD6Rbb6uw3EiolTv5qBanKcxTkui4
 5VP1/eRoBtaoYt7rA/oz8lcetdYTWmt9RYbNTwy/0DYwuaNGql2JWV0871wpNjL2
 cn0Ob2gNr+DdmZ9+zHhQUOQ3IsWA8rdz7Z3giIMz7WV2MpmQCdjRkR13IalGAbEG
 MjH9c1XrLdyHAQZGbJ6kNQ7zAIpspmJdiP9Ln8JLYOZDY2L1q5rm7dCe55u58iwT
 GelkU3bTSJ0TT/6bpt9cL0ECfob9w==
X-ME-Sender: <xms:kNC-XAlknsSbXj-xi_kPiGgpi7Y5tT8DRZUPr_y-wXVF5fhFIUdanQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeekgddthecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
 epkeefrdduudehrdduheehrddufeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho
 mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:kNC-XJr1B380MAM_EoXBTTVEkQ_wKTEYWuO68aEV70OXV4G-8EZ0hw>
 <xmx:kNC-XNfZrDiQlUO4IuU0MSJ-uN5MCXfcTPDTkA_WnwrjtItKP7p5_Q>
 <xmx:kNC-XH8U6U-goUGY5C4ARD5ezniA7cUE86FuE0HFuF64rdwX_63rSA>
 <xmx:kNC-XE1_vAA7W8gi9c9gvRltaxekFghyhrGfUGdq68V87SNBLvY7TQ>
Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr
 [83.115.155.138])
 by mail.messagingengine.com (Postfix) with ESMTPA id A1E6FE455C;
 Tue, 23 Apr 2019 04:45:02 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Pei, Andy" <andy.pei@intel.com>
Cc: "Xu, Rosen" <rosen.xu@intel.com>, "stable@dpdk.org" <stable@dpdk.org>,
 "dev@dpdk.org" <dev@dpdk.org>, "Kovacevic, Marko" <marko.kovacevic@intel.com>,
 "liq3ea@163.com" <liq3ea@163.com>
Date: Tue, 23 Apr 2019 10:45:00 +0200
Message-ID: <2416997.dOrgfSpHr6@xps>
In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A6CE8A2@SHSMSX104.ccr.corp.intel.com>
References: <1555483757-48188-1-git-send-email-andy.pei@intel.com>
 <5941F446C088714A85408FA3132CFCBB0100B26D@SHSMSX105.ccr.corp.intel.com>
 <0E78D399C70DA940A335608C6ED296D73A6CE8A2@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd
	leak in rte fpga do pr
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190423084500.UjcygN0CXQWZNzNUNc2Xc2kpSHroz06kCeW2-e_Ibjs@z>

When you need to re-send a patch, please apply it with "git am"
so the original author is kept.

Another nit: the title is full of abbreviation, it is hard to read.
The title prefix should be "raw/ifpga", even if checkpatch complains.

Please re-send, thanks.


23/04/2019 03:36, Xu, Rosen:
> Hi Thomas,
> 
> Qian has some problem with his email. So some patch can't be found in patch work.
> For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks.
> 
> > -----Original Message-----
> > From: Pei, Andy
> > Sent: Tuesday, April 23, 2019 9:19
> > To: Thomas Monjalon <thomas@monjalon.net>; Xu, Rosen
> > <rosen.xu@intel.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko
> > <marko.kovacevic@intel.com>; liq3ea@163.com
> > Subject: RE: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte
> > fpga do pr
> > 
> > Hi Thomas,
> > 
> > My patch is the same as LI Qiang's patch.
> > I was told that Qiang's patch cannot get onto the patchwork, so I just help
> > him do this.
> > 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Tuesday, April 23, 2019 1:52 AM
> > To: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; Kovacevic, Marko
> > <marko.kovacevic@intel.com>; liq3ea@163.com
> > Subject: Re: [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte
> > fpga do pr
> > 
> > > > In rte_fpga_do_pr() function, if 'stat' returns error,
> > > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that
> > > > has been opened.
> > > > After this patch, 'file_fd' is closed before rte_fpga_do_pr()
> > > > returns -EINVAL when 'stat' returns error
> > > >
> > > > Coverity issue: 279441
> > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > > > Cc: rosen.xu@intel.com
> > > > Cc: marko.kovacevic@intel.com
> > > > Cc: liq3ea@163.com
> > > > Cc: andy.pei@intel.com
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Andy Pei <andy.pei@intel.com>
> > >
> > > Acked-by: Rosen Xu <rosen.xu@intel.com>
> > 
> > Li Qiang <liq3ea@163.com> proposed the same patch.
> > Why he is not referenced here?
> > Which patch should I merge?