From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 2F55E493D for ; Tue, 23 Apr 2019 13:34:21 +0200 (CEST) Received: from cpe-2606-a000-111b-405a-0-0-0-188a.dyn6.twc.com ([2606:a000:111b:405a::188a] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1hItgk-0008DO-K5; Tue, 23 Apr 2019 07:34:17 -0400 Date: Tue, 23 Apr 2019 07:33:47 -0400 From: Neil Horman To: Mattias =?iso-8859-1?Q?R=F6nnblom?= Cc: dev@dpdk.org, stephen@networkplumber.org Message-ID: <20190423113347.GB30923@hmswarspite.think-freely.org> References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Apr 2019 11:34:22 -0000 On Mon, Apr 22, 2019 at 07:44:39PM +0200, Mattias Rönnblom wrote: > On 2019-04-22 17:52, Mattias Rönnblom wrote: > > On 2019-04-22 13:34, Neil Horman wrote: > > > > > > +uint64_t __rte_experimental > > > > +rte_rand(void) > > > Do you really want to mark this as experimental?  I know it will > > > trigger the > > > symbol checker with a warning if you don't, but this function > > > already existed > > > previously and was accepted as part of the ABI.  Given that the > > > prototype hasn't > > > changed, I think you just need to accept it as a non-experimental > > > function > > > > > > > I'll remove the experimental tag and move it into the 19_05 section > > (without suggesting it should go into 19.05). That maneuver seems not to > > trigger any build warnings/errors. > > > > OK, so that wasn't true. It does trigger a build error, courtesy of > buildtools/check-experimental-syms.sh. > > I can't see any obvious way around it. Ideas, anyone? > No, we would have to waive it. But its pretty clear that This function has been around forever, so I think it would be worse to demote it to an experimental symbol. The only thing you're doing here is moving it from an inline function (which is arguably part of the ABI, even if it never appeared as a symbol in the ELF file), to a fully fleged symbol with a new implementation. Neil From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F262BA05D3 for ; Tue, 23 Apr 2019 13:34:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 73D161B437; Tue, 23 Apr 2019 13:34:23 +0200 (CEST) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 2F55E493D for ; Tue, 23 Apr 2019 13:34:21 +0200 (CEST) Received: from cpe-2606-a000-111b-405a-0-0-0-188a.dyn6.twc.com ([2606:a000:111b:405a::188a] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1hItgk-0008DO-K5; Tue, 23 Apr 2019 07:34:17 -0400 Date: Tue, 23 Apr 2019 07:33:47 -0400 From: Neil Horman To: Mattias =?iso-8859-1?Q?R=F6nnblom?= Cc: dev@dpdk.org, stephen@networkplumber.org Message-ID: <20190423113347.GB30923@hmswarspite.think-freely.org> References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <75537445-7cf0-f86a-4052-5ee69c83f7eb@ericsson.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190423113347.x677D01l1EuwPjZt-yyDMWgCgOUqWTn5xpZX2mBxfio@z> On Mon, Apr 22, 2019 at 07:44:39PM +0200, Mattias Rönnblom wrote: > On 2019-04-22 17:52, Mattias Rönnblom wrote: > > On 2019-04-22 13:34, Neil Horman wrote: > > > > > > +uint64_t __rte_experimental > > > > +rte_rand(void) > > > Do you really want to mark this as experimental?  I know it will > > > trigger the > > > symbol checker with a warning if you don't, but this function > > > already existed > > > previously and was accepted as part of the ABI.  Given that the > > > prototype hasn't > > > changed, I think you just need to accept it as a non-experimental > > > function > > > > > > > I'll remove the experimental tag and move it into the 19_05 section > > (without suggesting it should go into 19.05). That maneuver seems not to > > trigger any build warnings/errors. > > > > OK, so that wasn't true. It does trigger a build error, courtesy of > buildtools/check-experimental-syms.sh. > > I can't see any obvious way around it. Ideas, anyone? > No, we would have to waive it. But its pretty clear that This function has been around forever, so I think it would be worse to demote it to an experimental symbol. The only thing you're doing here is moving it from an inline function (which is arguably part of the ABI, even if it never appeared as a symbol in the ELF file), to a fully fleged symbol with a new implementation. Neil