From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D020D29D2 for ; Wed, 24 Apr 2019 10:54:13 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 01:54:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="143176777" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by fmsmga008.fm.intel.com with SMTP; 24 Apr 2019 01:54:06 -0700 Received: by (sSMTP sendmail emulation); Wed, 24 Apr 2019 09:54:05 +0100 Date: Wed, 24 Apr 2019 09:54:05 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20190424085405.GB1871@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190423160449.40f3c3f8@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190423160449.40f3c3f8@hermes.lan> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2019 08:54:14 -0000 On Tue, Apr 23, 2019 at 04:04:49PM -0700, Stephen Hemminger wrote: > On Tue, 23 Apr 2019 23:06:40 +0100 > Bruce Richardson wrote: > > > As part of the meson build, a pkg-config file for libdpdk is created, which > > allows apps to be compiled and linked against DPDK by taking the cflags and > > lib parameter from pkgconfig. The example app makefiles have been reworked > > to take account of this support, but the build of them against the .pc file > > was not regularly tested. > > > > To rectify this, and give us greater confidence in the correctness of the > > .pc file, this set adds in the sample apps to the installation set for > > "ninja install" and then builds a subset of those apps against the > > pkg-config file to test it. In the process a small error when compiling > > the cmdline sample app using the .pc file was fixed. > > > > Bruce Richardson (4): > > examples: install examples as part of ninja install > > examples: simplify getting list of all examples > > devtools/test-meson-builds: add testing of pkg-config file > > build: add libbsd to pkg-config file if enabled > > > > config/meson.build | 10 ++++------ > > devtools/test-meson-builds.sh | 17 +++++++++++++++++ > > examples/meson.build | 17 +++++++++++++---- > > meson.build | 2 ++ > > 4 files changed, 36 insertions(+), 10 deletions(-) > > > > My experiments with Ubuntu 18.04 showed the default version of meson > was too old (broken) and generated bad cflags. > > Getting later one for Debian stable-backports worked. Thanks for the info - it's things like that that this scripting is needed to catch. How old was the older version and what was the diff from it vs newer? Personally, to update meson, I'd always just use pip to get the latest. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 74C8DA05D3 for ; Wed, 24 Apr 2019 10:54:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5E181B4D5; Wed, 24 Apr 2019 10:54:14 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D020D29D2 for ; Wed, 24 Apr 2019 10:54:13 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2019 01:54:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,389,1549958400"; d="scan'208";a="143176777" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.48]) by fmsmga008.fm.intel.com with SMTP; 24 Apr 2019 01:54:06 -0700 Received: by (sSMTP sendmail emulation); Wed, 24 Apr 2019 09:54:05 +0100 Date: Wed, 24 Apr 2019 09:54:05 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20190424085405.GB1871@bricha3-MOBL.ger.corp.intel.com> References: <20190423220644.54589-1-bruce.richardson@intel.com> <20190423160449.40f3c3f8@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190423160449.40f3c3f8@hermes.lan> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190424085405.TbghcoK0XitZmfuQ4UNR1KjNXkAKod4bdCXNCzPvrdE@z> On Tue, Apr 23, 2019 at 04:04:49PM -0700, Stephen Hemminger wrote: > On Tue, 23 Apr 2019 23:06:40 +0100 > Bruce Richardson wrote: > > > As part of the meson build, a pkg-config file for libdpdk is created, which > > allows apps to be compiled and linked against DPDK by taking the cflags and > > lib parameter from pkgconfig. The example app makefiles have been reworked > > to take account of this support, but the build of them against the .pc file > > was not regularly tested. > > > > To rectify this, and give us greater confidence in the correctness of the > > .pc file, this set adds in the sample apps to the installation set for > > "ninja install" and then builds a subset of those apps against the > > pkg-config file to test it. In the process a small error when compiling > > the cmdline sample app using the .pc file was fixed. > > > > Bruce Richardson (4): > > examples: install examples as part of ninja install > > examples: simplify getting list of all examples > > devtools/test-meson-builds: add testing of pkg-config file > > build: add libbsd to pkg-config file if enabled > > > > config/meson.build | 10 ++++------ > > devtools/test-meson-builds.sh | 17 +++++++++++++++++ > > examples/meson.build | 17 +++++++++++++---- > > meson.build | 2 ++ > > 4 files changed, 36 insertions(+), 10 deletions(-) > > > > My experiments with Ubuntu 18.04 showed the default version of meson > was too old (broken) and generated bad cflags. > > Getting later one for Debian stable-backports worked. Thanks for the info - it's things like that that this scripting is needed to catch. How old was the older version and what was the diff from it vs newer? Personally, to update meson, I'd always just use pip to get the latest. /Bruce