DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Bernard Iremonger <bernard.iremonger@intel.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
	WenjieX A Li <wenjiex.a.li@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"
Date: Wed, 24 Apr 2019 23:03:09 +0100	[thread overview]
Message-ID: <20190424220309.84270-1-ferruh.yigit@intel.com> (raw)

This reverts commit bdca79053b6aea504d02691d9319fa976062457f.

Not all PMDs support the fixed link speed set, and link speed can be set
even with auto negotiation enabled. Reverting the patch to not break
existing usage.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: WenjieX A Li <wenjiex.a.li@intel.com>
Cc: Bernard Iremonger <bernard.iremonger@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>
---
 app/test-pmd/cmdline.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f45ef8a1c..c1042dd98 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1533,17 +1533,17 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed)
 			return -1;
 		}
 		if (!strcmp(speedstr, "1000")) {
-			*speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED;
+			*speed = ETH_LINK_SPEED_1G;
 		} else if (!strcmp(speedstr, "10000")) {
-			*speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED;
+			*speed = ETH_LINK_SPEED_10G;
 		} else if (!strcmp(speedstr, "25000")) {
-			*speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED;
+			*speed = ETH_LINK_SPEED_25G;
 		} else if (!strcmp(speedstr, "40000")) {
-			*speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED;
+			*speed = ETH_LINK_SPEED_40G;
 		} else if (!strcmp(speedstr, "50000")) {
-			*speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED;
+			*speed = ETH_LINK_SPEED_50G;
 		} else if (!strcmp(speedstr, "100000")) {
-			*speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED;
+			*speed = ETH_LINK_SPEED_100G;
 		} else if (!strcmp(speedstr, "auto")) {
 			*speed = ETH_LINK_SPEED_AUTONEG;
 		} else {
-- 
2.20.1

             reply	other threads:[~2019-04-24 22:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 22:03 Ferruh Yigit [this message]
2019-04-24 22:03 ` Ferruh Yigit
2019-04-25  8:19 ` Thomas Monjalon
2019-04-25  8:19   ` Thomas Monjalon
2019-04-25 11:47   ` Ferruh Yigit
2019-04-25 11:47     ` Ferruh Yigit
2019-04-25 13:29     ` Thomas Monjalon
2019-04-25 13:29       ` Thomas Monjalon
2019-04-25 15:27       ` Ferruh Yigit
2019-04-25 15:27         ` Ferruh Yigit
2019-04-29  9:52         ` Thomas Monjalon
2019-04-29  9:52           ` Thomas Monjalon
2019-05-02 18:31           ` Ferruh Yigit
2019-05-02 18:31             ` Ferruh Yigit
2019-05-02 20:27             ` Thomas Monjalon
2019-05-02 20:27               ` Thomas Monjalon
2019-05-04 20:45               ` Thomas Monjalon
2019-05-04 20:45                 ` Thomas Monjalon
2019-05-06  8:09                 ` Andrew Rybchenko
2019-05-06  8:09                   ` Andrew Rybchenko
2019-05-07 10:09                   ` Ferruh Yigit
2019-05-07 10:09                     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190424220309.84270-1-ferruh.yigit@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenjiex.a.li@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).