From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 8BB35A05D3
for <public@inbox.dpdk.org>; Thu, 25 Apr 2019 08:00:27 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 4A4AE1B52A;
Thu, 25 Apr 2019 08:00:26 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by dpdk.org (Postfix) with ESMTP id 44A6A1B520;
Thu, 25 Apr 2019 08:00:24 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
24 Apr 2019 23:00:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,392,1549958400"; d="scan'208";a="145549083"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
by orsmga003.jf.intel.com with ESMTP; 24 Apr 2019 23:00:22 -0700
Received: from lcsmsx154.ger.corp.intel.com (10.186.165.229) by
FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Wed, 24 Apr 2019 23:00:22 -0700
Received: from hasmsx105.ger.corp.intel.com ([169.254.1.47]) by
LCSMSX154.ger.corp.intel.com ([169.254.7.189]) with mapi id 14.03.0415.000;
Thu, 25 Apr 2019 09:00:21 +0300
From: "Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>
To: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Lipiec, Herakliusz"
<herakliusz.lipiec@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak
Thread-Index: AQHU+fwnzsa1IRiDi0K1FNjXtBa16KZMY0Ew
Date: Thu, 25 Apr 2019 06:00:20 +0000
Message-ID:
<FBE7E039FA50BF47A673AD0BD3CD56A846325171@HASMSX105.ger.corp.intel.com>
References: <20190417143822.21276-1-herakliusz.lipiec@intel.com>
<20190423174334.19612-1-herakliusz.lipiec@intel.com>
<20190423174334.19612-3-herakliusz.lipiec@intel.com>
In-Reply-To: <20190423174334.19612-3-herakliusz.lipiec@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.102.11.37]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190425060020.c--8i0OpWko2pBe1HYY7XIOA51JuzKf2mw835b-0Fsc@z>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Herakliusz Lipiec
> Sent: Tuesday, April 23, 2019 7:43 PM
> Cc: dev@dpdk.org; Lipiec, Herakliusz <herakliusz.lipiec@intel.com>; Zhang=
,
> Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 2/8] ipc: fix hotplug memleak
>=20
> When sending synchronous IPC requests, the caller must free the response
> buffer even if the request returned failure. Fix the code to correctly
> use the IPC API.
>=20
> Bugzilla ID: 228
> Fixes: ac9e4a17370f ("eal: support attach/detach shared device from
> secondary")
> Cc: qi.z.zhang@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> ---
Shouldn't the commit title be something like "hotplug: fix ipc memleak"?
Or even more specifically "hotplug: fix memleak on ipc failure".
For the patch itself:
Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>