From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
WenjieX A Li <wenjiex.a.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"
Date: Thu, 25 Apr 2019 15:29:22 +0200 [thread overview]
Message-ID: <1838455.hGyFdCOQE1@xps> (raw)
Message-ID: <20190425132922.H0XN53TdKnpwToa27SWOfr9aEzfOrZw7iTmp5pivZFk@z> (raw)
In-Reply-To: <ab2f5a90-fa45-b43e-8ded-0c294e0facb4@intel.com>
25/04/2019 13:47, Ferruh Yigit:
> On 4/25/2019 9:19 AM, Thomas Monjalon wrote:
> > 25/04/2019 00:03, Ferruh Yigit:
> >> This reverts commit bdca79053b6aea504d02691d9319fa976062457f.
> >>
> >> Not all PMDs support the fixed link speed set, and link speed can be set
> >> even with auto negotiation enabled. Reverting the patch to not break
> >> existing usage.
> >
> > Which PMDs do not support this flag?
> > Why not fixing the PMDs?
> >
>
> At least ixgbe and i40e is not supporting setting a fixed speed.
> But I am not sure if this is something to fix, the command in testpmd is to set
> the link speed, what is the problem with setting the link speed without
> disabling the auto-negotiation?
It means it will negotiate with only one speed proposed.
The real issue is to not support the fixed flag.
next prev parent reply other threads:[~2019-04-25 13:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 22:03 Ferruh Yigit
2019-04-24 22:03 ` Ferruh Yigit
2019-04-25 8:19 ` Thomas Monjalon
2019-04-25 8:19 ` Thomas Monjalon
2019-04-25 11:47 ` Ferruh Yigit
2019-04-25 11:47 ` Ferruh Yigit
2019-04-25 13:29 ` Thomas Monjalon [this message]
2019-04-25 13:29 ` Thomas Monjalon
2019-04-25 15:27 ` Ferruh Yigit
2019-04-25 15:27 ` Ferruh Yigit
2019-04-29 9:52 ` Thomas Monjalon
2019-04-29 9:52 ` Thomas Monjalon
2019-05-02 18:31 ` Ferruh Yigit
2019-05-02 18:31 ` Ferruh Yigit
2019-05-02 20:27 ` Thomas Monjalon
2019-05-02 20:27 ` Thomas Monjalon
2019-05-04 20:45 ` Thomas Monjalon
2019-05-04 20:45 ` Thomas Monjalon
2019-05-06 8:09 ` Andrew Rybchenko
2019-05-06 8:09 ` Andrew Rybchenko
2019-05-07 10:09 ` Ferruh Yigit
2019-05-07 10:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1838455.hGyFdCOQE1@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wenjiex.a.li@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).