From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, Shreyansh Jain <shreyansh.jain@nxp.com>,
sunil.kori@nxp.com
Subject: [dpdk-dev] [PATCH] net/dpaa2: fix incorrect loop increment
Date: Thu, 25 Apr 2019 19:04:56 +0530 [thread overview]
Message-ID: <20190425133456.23074-1-shreyansh.jain@nxp.com> (raw)
Identified by LGTM, the loop was incorrectly incrementing a different
variable and conditional on another.
Fixes: fe2b986ac662 ("net/dpaa2: support generic flow")
Cc: sunil.kori@nxp.com
Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
drivers/net/dpaa2/dpaa2_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c
index 98f68139b..9ef46d47e 100644
--- a/drivers/net/dpaa2/dpaa2_flow.c
+++ b/drivers/net/dpaa2/dpaa2_flow.c
@@ -1734,7 +1734,7 @@ dpaa2_dev_verify_patterns(struct dpaa2_dev_priv *dev_priv,
/* more than DPKG_MAX_NUM_OF_EXTRACTS. Verify this limitation too. */
for (i = 0; pattern[i].type != RTE_FLOW_ITEM_TYPE_END; i++) {
for (j = 0; j < MAX_TCS + 1; j++) {
- for (k = 0; k < DPKG_MAX_NUM_OF_EXTRACTS; j++) {
+ for (k = 0; k < DPKG_MAX_NUM_OF_EXTRACTS; k++) {
if (dev_priv->pattern[j].pattern_type[k] == pattern[i].type)
break;
}
--
2.17.1
next reply other threads:[~2019-04-25 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 13:34 Shreyansh Jain [this message]
2019-04-25 13:34 ` Shreyansh Jain
2019-04-25 15:49 ` Ferruh Yigit
2019-04-25 15:49 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425133456.23074-1-shreyansh.jain@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=sunil.kori@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).