From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D5EB2A0679 for ; Sun, 28 Apr 2019 08:58:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0DEE1B48E; Sun, 28 Apr 2019 08:58:06 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20062.outbound.protection.outlook.com [40.107.2.62]) by dpdk.org (Postfix) with ESMTP id BEC921B462 for ; Sun, 28 Apr 2019 08:58:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHJKP849DhXb39+pzjVq1AoHqM2mJzyMJ2UGKwzRyMo=; b=tqxBUlP6kAZci7twSogNszP6j0PnBU7NReS5DdFaBV/xAzFvukVbPQKpvdjGlSSR1cfSy0kqyjr47qVYesX0KC30WQAWFIVCUr23m7U+4fSs1LT/lghceckbbYe3bODC5VemzmXl4A4k5Vc3MgCCaJT5dkZAJxuPPJjjr7j97o0= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3842.eurprd05.prod.outlook.com (52.133.49.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13; Sun, 28 Apr 2019 06:58:00 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::dd0b:b2ed:19ed:7c1]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::dd0b:b2ed:19ed:7c1%2]) with mapi id 15.20.1835.015; Sun, 28 Apr 2019 06:58:00 +0000 From: Matan Azrad To: Thomas Monjalon , "John W. Linville" , Xiaolong Ye , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Gagandeep Singh , Pankaj Chauhan , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Ferruh Yigit , Shijith Thotton , Srisivasubramanian Srinivasan , Shahaf Shuler , Yongseok Koh , Zyta Szpak , Liron Himi , Alan Winkowski , Tomasz Duszynski , Stephen Hemminger , kys , haiyangz , Rastislav Cernay , Jan Remes , Alejandro Lucero , Tetsuya Mukawa , Jerin Jacob , Bruce Richardson , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Anatoly Burakov CC: "dev@dpdk.org" Thread-Topic: CALL to eth PMD maintainers: complete closing of port Thread-Index: AQHU9dXZeO2FHazATkm6oWHDmoDrIKZRMw1Q Date: Sun, 28 Apr 2019 06:57:59 +0000 Message-ID: References: <30528485.5cHeq7CNxZ@xps> In-Reply-To: <30528485.5cHeq7CNxZ@xps> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 526a0b02-313f-4fe2-815e-08d6cba6da16 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3842; x-ms-traffictypediagnostic: AM0PR0502MB3842: x-ms-exchange-purlcount: 1 x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-forefront-prvs: 0021920B5A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(39850400004)(396003)(136003)(189003)(199004)(53754006)(53936002)(99286004)(25786009)(966005)(14454004)(11346002)(71200400001)(74316002)(55016002)(6246003)(305945005)(4326008)(316002)(1191002)(110136005)(8676002)(76176011)(68736007)(446003)(186003)(6506007)(102836004)(86362001)(71190400001)(476003)(7696005)(52536014)(7406005)(7416002)(7366002)(5660300002)(33656002)(26005)(3846002)(6116002)(486006)(66556008)(73956011)(76116006)(2906002)(45080400002)(66446008)(66476007)(64756008)(66946007)(97736004)(478600001)(66066001)(81166006)(256004)(81156014)(1511001)(6306002)(9686003)(7736002)(6436002)(229853002)(14444005)(8936002)(156664002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3842; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ko/7dLPD/OC58WhLbnWLZ6l87496pDEQslmBW4IdUo8ZAeIM9kH2gveTtJOnmFpP0Hg9qkcCWBiuC03c2n5QSfOJiK8HGQlJmcFgmIPigvVBH6UINlGvCrFziHA1KhYExWKAZLDic2p9dkiFDbxfF8DDFGApf4MiFOoiL7+/uI3ytZ2Iv14g1B0HCGpxnkXyNEvMAPYPCP2u8+Zkrh2wk2y/5by/Libt3EXBK6s9IL8nlKNx2iR/qbqm77jg0ezUlwaSor5LKZ4uBLaHMFlfv9/S2sqncaYcYeAMKA4ldHgHJgpjqzJKo6HbK/leVfI5kBj/ryEI8fhkQ2vf6vnPL/jxy+EkIw4NGqmB3PjDTczaVsGmb+CaDLno/1iQKxXWWswbXBa5+1TqiOoFarO21diTN8jhFu+peBAhYlc0JJ8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 526a0b02-313f-4fe2-815e-08d6cba6da16 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2019 06:58:00.0419 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3842 Subject: Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190428065759.V_hdPIcLzJ5BaaMTzjwHsN9QyCcAbjC5tHc3prQ2QAA@z> Hi Thomas vdev_netvsc has no close API - should I change something there? > From: Thomas Monjalon > Hi all, >=20 > Since DPDK 18.11, the behaviour of the close operation is changed if > RTE_ETH_DEV_CLOSE_REMOVE is enabled in the driver: > port is released (i.e. totally freed and data erased) on close. > This new behaviour is enabled per driver for a migration period. >=20 > Looking at the code, you can see these comments: > /* old behaviour: only free queue arrays */ RTE_ETHDEV_LOG(DEBUG, "Port > closing is using an old behaviour.\n" > "The driver %s should migrate to the new behaviour.\n", > /* new behaviour: send event + reset state + free all data */ >=20 > You can find an advice in the commit: > https://eur03.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2 > Fgit.dpdk.org%2Fdpdk%2Fcommit%2F%3Fid%3D23ea57a2a&data=3D02%7 > C01%7Cmatan%40mellanox.com%7C3fea370ec31f4d22be8708d6c3ecf74b%7 > Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636911819926371170&a > mp;sdata=3D%2BHLHG6VK2gNLejSHRKLYtS4Qelqg%2FOD%2FUQbZwOIT9%2BA > %3D&reserved=3D0 > " > When enabling RTE_ETH_DEV_CLOSE_REMOVE, > the PMD must free all its private resources for the port, in its dev_clos= e > function. > It is advised to call the dev_close function in the remove function in or= der to > support removing a device without closing its ports. > " >=20 > It would be great to complete this migration for the next LTS version, wh= ich > will be 19.11. > It means the work should be ideally finished during the summer. >=20 > The migration to the new behaviour is done in 4 drivers: > git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 > ena > enic > mlx5 > vmxnet3 >=20 > Following drivers should be migrated: > ( find drivers/net -mindepth 1 -maxdepth 1 -type d | cut -d/ -f3 ; git gr= ep -l > RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 ) | sort | uniq -u > af_packet > af_xdp > ark > atlantic > avp > axgbe > bnx2x > bnxt > bonding > cxgbe > dpaa > dpaa2 > e1000 > enetc > failsafe > fm10k > i40e > iavf > ice > ifc > ixgbe > kni > liquidio > mlx4 > mvneta > mvpp2 > netvsc > nfb > nfp > null > octeontx > pcap > qede > ring > sfc > softnic > szedata2 > tap > thunderx > vdev_netvsc > vhost > virtio >=20 > Please let's progress smoothly on this topic, thanks. >=20 > The concerned maintainers (Cc) can be found with the following command: > devtools/get-maintainer.sh $(( find drivers/net -mindepth 1 -maxdepth 1 - > type d | cut -d/ -f-3 ; git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers ) | > sort | uniq -u) >=20