From: Stephen Hemminger <stephen@networkplumber.org>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: dev@dpdk.org, thomas@monjalon.net, anatoly.burakov@intel.com,
wenzhuo.lu@intel.com, declan.doherty@intel.com,
jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com,
ferruh.yigit@intel.com, ranjit.menon@intel.com,
anand.rawat@intel.com, pallavi.kadam@intel.com,
harini.ramakrishnan@microsoft.com, cathal.ohare@intel.com,
arnonw@qwilt.com
Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni
Date: Sun, 28 Apr 2019 09:23:57 -0700 [thread overview]
Message-ID: <20190428092357.66ae2b80@hermes.lan> (raw)
In-Reply-To: <1556463528-22853-1-git-send-email-arnon@qwilt.com>
On Sun, 28 Apr 2019 17:58:48 +0300
Arnon Warshavsky <arnon@qwilt.com> wrote:
These deprecation notices are unnecessary. These are not public API's.
> +* eal: Modify function return value for the sake of removing rte_panic
> + from the init sequence in version 19.08.
> + - In ``lib/librte_eal/common/eal_thread.h`` replace
> + ``void eal_thread_init_master(unsigned lcore_id)``
> + to return ``int``
This function is never exported (see rte_eal_version.map) and therefore be marked private to the EAL, and not a public API.
> +* kni: Modify function return value for the sake of removing rte_panic
> + from the init sequence in version 19.08.
> + - In ``lib/librte_kni/rte_kni_fifo.h`` replace
> + ``static void kni_fifo_init(struct rte_kni_fifo *fifo, unsigned size)``
> + to return ``int``
This is not a public API really so no deprecation needed.
It is just an include file used internally by library and the driver.
next prev parent reply other threads:[~2019-04-28 16:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 14:58 Arnon Warshavsky
2019-04-28 14:58 ` Arnon Warshavsky
2019-04-28 16:23 ` Stephen Hemminger [this message]
2019-04-28 16:23 ` Stephen Hemminger
2019-04-29 9:28 ` Ferruh Yigit
2019-04-29 9:28 ` Ferruh Yigit
2019-04-29 16:24 ` Stephen Hemminger
2019-04-29 16:24 ` Stephen Hemminger
2019-04-29 17:19 ` Ferruh Yigit
2019-04-29 17:19 ` Ferruh Yigit
2019-05-07 9:57 ` Arnon Warshavsky
2019-05-07 9:57 ` Arnon Warshavsky
2019-05-08 11:07 ` Thomas Monjalon
2019-05-08 11:07 ` Thomas Monjalon
2019-05-08 20:22 ` Arnon Warshavsky
2019-05-08 20:22 ` Arnon Warshavsky
2019-05-08 20:25 ` Thomas Monjalon
2019-05-08 20:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190428092357.66ae2b80@hermes.lan \
--to=stephen@networkplumber.org \
--cc=anand.rawat@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=arnon@qwilt.com \
--cc=arnonw@qwilt.com \
--cc=bruce.richardson@intel.com \
--cc=cathal.ohare@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).