From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id DA1C7493D for ; Tue, 30 Apr 2019 22:46:24 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id x15so7282997pln.9 for ; Tue, 30 Apr 2019 13:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NNrWb1fnOhVqVtA1i2TOnpi7wIjy09QrCWCU7CAYK/8=; b=cxCXxsh8jIIgpkvLAwUElWXlPUKJceVhJstMUAXLvo7Ea4eGvNLZkwmbJOgbswOrER lkp+/msxKHu5/LXV+pHNM77im3WmHklX4SY6KiqFUfC2V2V9AJU9h9wGYhAu5dJ4kE3A lLcYUO9nCqsb5+cjHRHbvCa/8ZDSYw0e4eK6B8ROp73CxScojUKyURz7wB9abmJLHcvo jQLPs/648cN99O6HZnVTHWg0RMcdbentRib+/3EQCKSN90bUXZMf6HkIZ1JKhEinLWeM NuD4Q/5DDMysoCU3etQR9MmaByb+zzpUmpCW1nxcFMcCelcTLN6AGRqb4i9NO3R5HUnh fe2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NNrWb1fnOhVqVtA1i2TOnpi7wIjy09QrCWCU7CAYK/8=; b=UFWSsmjIiS5C08ODk51VfP+gFHDclvt4GJmssIsfje/k4O5Sj6OvdqXN6zDzDm85LJ lkU6ku7+arFI+mzi2o/yA4jsBfysEpRKN9eI0kFd8q6DIVgKiT1jCrXqQnhAfSsRrRJb 4kZeSsoD/OT/Eh7RgdOjwe1M6S40AAoGQrOx3hqhx5vccRYxN3BBXcki2fed6Ul5wr4P DU3H3ZeHc8YHYUPnqfnSYv1M9h8WopBHCXFIS/N/55Sa3fo4i7jdG3JXeB2dNoyjozA2 bzAcpIzZphsKulbZQJrmdfDeGcFmftZh7M1k3IX5TzQJcyz0Wv0UjCyFHPfHU7Rp381X DRTA== X-Gm-Message-State: APjAAAXEpM7o33I2t1iUDXYaLKEMKcrfxgbBviCZM2myMQHII+GuelCC 1J+zXrIOaavz1MneDkS53eE6uA== X-Google-Smtp-Source: APXvYqz+agz7ph303QA5JdccmIr3zfOOxsT7kBiBxjTpvXaZ7KfYdot32pdJeB53wOvWv4oDXqQ1rQ== X-Received: by 2002:a17:902:9304:: with SMTP id bc4mr73267444plb.312.1556657183964; Tue, 30 Apr 2019 13:46:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e6sm39343426pfe.158.2019.04.30.13.46.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Apr 2019 13:46:23 -0700 (PDT) Date: Tue, 30 Apr 2019 13:46:19 -0700 From: Stephen Hemminger To: Yongseok Koh Cc: shahafs@mellanox.com, dev@dpdk.org Message-ID: <20190430134619.36cc9b21@hermes.lan> In-Reply-To: <20190430190426.44018-1-yskoh@mellanox.com> References: <20190430190426.44018-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 20:46:25 -0000 On Tue, 30 Apr 2019 12:04:26 -0700 Yongseok Koh wrote: > + priv->sh->device_attr.orig_attr.max_qp_wr) { > + DRV_LOG(DEBUG, > + "port %u Tx WQEBB count exceeds the limit (%d)," > + " try smaller queue size again", > + dev->data->port_id, The patch looks good, but it could be improved to make life easier for the users. This is an error, why not print it at NOTICE level since DEBUG messages are usually suppressed. Please don't break long lines in log messages. The latter part of the message is obvious, why not skip it. Also since max_qp_wr is __u32, the print format should be %u Instead: DRV_LOG(NOTICE, "port %u Tx WQEBB count (%u) exceeds the limit (%u)", dev->data->port_id, txq_calc_wqebb_cnt(tmpl), priv->sh->device_attr.orig_attr.max_qp_wr); Also, should it have a Fixes: tag to backport to stable? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3DFEDA0679 for ; Tue, 30 Apr 2019 22:46:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9BBA94C77; Tue, 30 Apr 2019 22:46:26 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id DA1C7493D for ; Tue, 30 Apr 2019 22:46:24 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id x15so7282997pln.9 for ; Tue, 30 Apr 2019 13:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NNrWb1fnOhVqVtA1i2TOnpi7wIjy09QrCWCU7CAYK/8=; b=cxCXxsh8jIIgpkvLAwUElWXlPUKJceVhJstMUAXLvo7Ea4eGvNLZkwmbJOgbswOrER lkp+/msxKHu5/LXV+pHNM77im3WmHklX4SY6KiqFUfC2V2V9AJU9h9wGYhAu5dJ4kE3A lLcYUO9nCqsb5+cjHRHbvCa/8ZDSYw0e4eK6B8ROp73CxScojUKyURz7wB9abmJLHcvo jQLPs/648cN99O6HZnVTHWg0RMcdbentRib+/3EQCKSN90bUXZMf6HkIZ1JKhEinLWeM NuD4Q/5DDMysoCU3etQR9MmaByb+zzpUmpCW1nxcFMcCelcTLN6AGRqb4i9NO3R5HUnh fe2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NNrWb1fnOhVqVtA1i2TOnpi7wIjy09QrCWCU7CAYK/8=; b=UFWSsmjIiS5C08ODk51VfP+gFHDclvt4GJmssIsfje/k4O5Sj6OvdqXN6zDzDm85LJ lkU6ku7+arFI+mzi2o/yA4jsBfysEpRKN9eI0kFd8q6DIVgKiT1jCrXqQnhAfSsRrRJb 4kZeSsoD/OT/Eh7RgdOjwe1M6S40AAoGQrOx3hqhx5vccRYxN3BBXcki2fed6Ul5wr4P DU3H3ZeHc8YHYUPnqfnSYv1M9h8WopBHCXFIS/N/55Sa3fo4i7jdG3JXeB2dNoyjozA2 bzAcpIzZphsKulbZQJrmdfDeGcFmftZh7M1k3IX5TzQJcyz0Wv0UjCyFHPfHU7Rp381X DRTA== X-Gm-Message-State: APjAAAXEpM7o33I2t1iUDXYaLKEMKcrfxgbBviCZM2myMQHII+GuelCC 1J+zXrIOaavz1MneDkS53eE6uA== X-Google-Smtp-Source: APXvYqz+agz7ph303QA5JdccmIr3zfOOxsT7kBiBxjTpvXaZ7KfYdot32pdJeB53wOvWv4oDXqQ1rQ== X-Received: by 2002:a17:902:9304:: with SMTP id bc4mr73267444plb.312.1556657183964; Tue, 30 Apr 2019 13:46:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e6sm39343426pfe.158.2019.04.30.13.46.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Apr 2019 13:46:23 -0700 (PDT) Date: Tue, 30 Apr 2019 13:46:19 -0700 From: Stephen Hemminger To: Yongseok Koh Cc: shahafs@mellanox.com, dev@dpdk.org Message-ID: <20190430134619.36cc9b21@hermes.lan> In-Reply-To: <20190430190426.44018-1-yskoh@mellanox.com> References: <20190430190426.44018-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190430204619.cE75PQy_OkAXX6yDOdWgDRVC4uTVHvzX3JRsPBt5fXI@z> On Tue, 30 Apr 2019 12:04:26 -0700 Yongseok Koh wrote: > + priv->sh->device_attr.orig_attr.max_qp_wr) { > + DRV_LOG(DEBUG, > + "port %u Tx WQEBB count exceeds the limit (%d)," > + " try smaller queue size again", > + dev->data->port_id, The patch looks good, but it could be improved to make life easier for the users. This is an error, why not print it at NOTICE level since DEBUG messages are usually suppressed. Please don't break long lines in log messages. The latter part of the message is obvious, why not skip it. Also since max_qp_wr is __u32, the print format should be %u Instead: DRV_LOG(NOTICE, "port %u Tx WQEBB count (%u) exceeds the limit (%u)", dev->data->port_id, txq_calc_wqebb_cnt(tmpl), priv->sh->device_attr.orig_attr.max_qp_wr); Also, should it have a Fixes: tag to backport to stable?